Stacked PR wipes approvals from the stack #210986
Unanswered
theblixguy
asked this question in
Pull Requests
Replies: 1 comment
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Bug
Body
From https://github.blog/changelog/2026-10-06-stacked-pull-requests-generally-available/
Assume we have the following settings on:
Now let's imagine this situation:
When something like this happens the base branch of the 6th PR is updated to
main(I see a "The merge-base changed after approval" message) and all approvals on that PR (along with approvals on the remaining 4) are wiped, even though there's no actual change to the diff, just the base branches got rebased and updated.I don't think the approvals should be wiped in this case, at least for stacks and even with those settings on, as it's a bit counter-intuitive.
All reactions