Repository navigation
fix: Preserve symbol visibility - #2415
Merged
Merged
Conversation
alexander-fenster
approved these changes
Aug 22, 2026
Merged
morgan-coded
added a commit
to morgan-coded/protobuf.js
that referenced
this pull request
Aug 27, 2026
Symbol visibility is parsed and preserved since protobufjs#2415, but nothing rejects a reference to a local symbol from another file. Field#resolve now checks the resolved type or enum and throws when it is local to a different file. References without a known file name on either side (programmatic construction, fromJSON, bundled common types) cannot be proven to cross files and are allowed. Refs protobufjs#2400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves Edition 2024
localandexportmodifiers on reflection objects and during descriptor conversion.Similar to #2401, but focused on preserving these modifiers without attempting to reimplement protoc's cross-file enforcement, which is less useful in protobuf.js's runtime schema loader respectively already performed by protoc when using the plugin.