Skip to content

Harden GitHub Action workflow permissions and pin build inputs - #2085

Open
jhodges10 wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
jhodges10:codex/harden-workflows
Open

jhodges10 wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
jhodges10:codex/harden-workflows

Conversation

@jhodges10

@jhodges10 jhodges10 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow up on a maintainer security audit by narrowing GitHub Actions token permissions and pinning direct build inputs.

Changes

  • Replace the deprecated ::set-output command in the release-preview workflow with GITHUB_OUTPUT.
  • Declare read-only permissions for test and docs jobs, actions: read for artifact downloads, and the specific write/read permissions needed for release preview. The release announcement job receives no repository token permissions.
  • Remove the unused load-repo checkout job and needs: [load-repo] dependency from release publishing. The Slack announcement uses no files or outputs from that separate job.
  • Include the published release body in the Slack announcement by passing it through the existing Markdown-to-Slack conversion alongside the release link.
  • Pin the five ASWF VFX CI images by digest, the Python build requirements and direct CI build tools by version, and the documentation theme.

The build-system pins use a setuptools release that supports Python 3.9 and CMake 3.31 to avoid the known Windows CMake 4/vcpkg ZLIB issue. Direct pins will need regular dependency updates.

Validation

  • actionlint -shellcheck= -color=false passed; the changed release and VFX workflows also passed full actionlint.
  • actionlint .github/workflows/release-publish.yml passed after the two release-announcement follow-up changes.
  • make lint passed.
  • An isolated source-distribution build passed with the pinned build requirements. The direct tool pins resolved for Python 3.9, and the docs requirements resolved.
  • Nine CTest targets and eleven bundle cases passed. The ZIP64 case was omitted because it needs roughly 24 GB of disk.
  • make test ran 487 Python tests: two skipped, one failure, and one error. The version-map generator failed because the local CMake-installed package lacked __version__; UnknownSchema.data raised bad any cast. Neither failing test exercises a changed workflow. No new unit tests were added for these configuration changes.
  • The release-publish workflow has not been triggered by a published release, so Slack delivery has not been tested live.

Assisted-by: OpenAI Codex / GPT-6 Daybreak (cyber-security model)

@jhodges10
jhodges10 requested a review from jminor October 30, 2026 19:27
@jhodges10 jhodges10 added ci security Security-related improvements labels Oct 30, 2026
@codecov-commenter

codecov-commenter commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.59%. Comparing base (0bfd9d6) to head (7e88871).
⚠️ Report is 1 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
- Coverage   83.62%   83.59%   -0.04%     
==========================================
  Files         184      184              
  Lines       13627    13632       +5     
  Branches     1270     1271       +1     
==========================================
  Hits        11395    11395              
- Misses       2059     2064       +5     
  Partials      173      173              
Flag Coverage Δ
py-unittests 83.59% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bfd9d6...7e88871. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# included as forward-looking support.
- platform: "2023"
cxx-standard: 17
image: "aswf/ci-otio:2023@sha256:888156204e68f3ced0ff277157423852c9330f0eed48419361a67fbf5ab48a53"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I acknowledge that this might be overkill, so I'll let whomever reviews this decide if it's really worth it or not.

Assisted-by: OpenAI Codex / GPT-6
Signed-off-by: Jeff Hodges <jeff@jeffhq.com>
@jhodges10
jhodges10 force-pushed the codex/harden-workflows branch from d22a7e0 to aab35c7 Compare October 30, 2026 20:20
Comment thread .github/workflows/release-publish.yml Resolved
The Slack announcement uses release context and remote actions only. The checkout ran in a separate job and provided no files or outputs to the announcement.

Assisted-by: OpenAI Codex / GPT-6
Signed-off-by: Jeff Hodges <jeff@jeffhq.com>
Pass the published release body through the existing Markdown-to-Slack conversion so the notification contains the notes as well as a link to the release.

Assisted-by: OpenAI Codex / GPT-6
Signed-off-by: Jeff Hodges <jeff@jeffhq.com>
@jhodges10 jhodges10 changed the title Harden workflow permissions and pin build inputs Harden GitHub Action workflow permissions and pin build inputs Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci security Security-related improvements

Projects

Development

Successfully merging this pull request may close these issues.

3 participants