Repository navigation
Conversation
Separate the unprivileged PR signal from trusted default-branch labeling. Apply managed labels incrementally to preserve concurrent unrelated label edits, with validation and regression tests. Assisted-by: OpenAI Codex / GPT-6 Signed-off-by: Jeff Hodges <jeff@jeffhq.com>
Restore the original YAML rule format using a pinned parser installed from the trusted lockfile with lifecycle scripts disabled. Preserve incremental label writes and add YAML validation coverage. Assisted-by: OpenAI Codex / GPT-6 Signed-off-by: Jeff Hodges <jeff@jeffhq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
- Coverage 83.62% 83.59% -0.04%
==========================================
Files 184 184
Lines 13627 13632 +5
Branches 1270 1271 +1
==========================================
Hits 11395 11395
- Misses 2059 2064 +5
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Pin the selective-label-update fix and retain the trusted workflow_run handoff. Remove custom label code, dependencies, and CI tests; download only trusted YAML to work around the pinned action configuration-path encoding bug. Assisted-by: OpenAI Codex / GPT-6 Signed-off-by: Jeff Hodges <jeff@jeffhq.com>
Use the existing repository taxonomy for build, CMake, packaging, Python, OpenTime, color, and maintenance changes. Wire every managed label into Release Drafter and remove inactive autolabeler configuration and the obsolete release-candidate rule. Assisted-by: OpenAI Codex Signed-off-by: Jeff Hodges <jeff@jeffhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore automatic file-based labels on PRs, including fork PRs, so Release Drafter can group them in the release-note categories. Release Preview keeps its existing manual release-branch and announcement controls.
This uses GitHub's
actions/labeler, a small inline API lookup, and YAML configuration. There are no repository-local JavaScript files, npm dependencies, package installs, or custom label-matching/update implementations.Background
pr-tools.yml. The discussion notes that a misleading PR could persuade a maintainer to approve a dangerous workflow, so contributor approval alone is insufficient.Why the security boundary is different
GitHub's secure-use guidance and workflow_run documentation warn that both
pull_request_targetandworkflow_runcan be privileged. Changing the trigger alone is not a security fix; keeping PR-controlled code out of the privileged job is essential.pull_requestworkflow emits a signal withpermissions: {}. It checks out no code, uses no secrets, and produces no artifacts or caches.workflow_runfollow-up executes the default-branch workflow. It validates the source event, workflow path, and repository, and has onlycontents: readandpull-requests: writepermissions.pull_requestslist. It skips superseded heads, foreign PRs, closed unmerged PRs, and PRs exceeding GitHub's file-list limit. Manual backfill accepts only a positive integer PR number and runs from the default branch..github/labeler.ymlat the trusted default-branchgithub.sha, through a fixed GitHub API route. PR metadata is passed as data and never interpolated into executable scripts.Upstream labeler and concurrent edits
The labeler is pinned to b7a88044754812b108a54feec878dd5c328bba59, which includes actions/labeler#957. That fix uses selective additions/removals instead of replacing the full label list, preserving concurrent changes to unrelated labels. It is newer than the current
v7.0.0release, so updating the pin must retain this fix.The runtime test also exposed double-encoding of path separators in this pin's remote configuration fetch. The metadata step therefore downloads the trusted YAML through a literal contents-API route and passes its temporary local path to the action. No PR file is checked out or executed.
Label coverage and release-note categories
The repository label inventory was reviewed, and
.github/labeler.ymlnow manages 14 existing labels using the upstream action'schanged-filessyntax:documentation: documentation trees, Doxygen, Markdown, and reStructuredText.ciandgithub_actions: CI settings and Actions workflows, scripts, and configuration.build,cmake, andwheels: build configuration, CMake, Python packaging, and wheel/publishing workflows.dependenciesandsubmodules: dependency declarations, requirements files, and submodule paths.pythonandpython-bindings: Python code and package/binding sources.opentime,time calculations, andcolor: their implementation, binding, and test paths.maintenance: maintainer tools or changes confined entirely totests/.All 14 automatically managed labels are connected to Release Drafter. Python & Bindings, Time, and Color get dedicated sections; build-related labels go into Maintenance. The existing
enhancementandmaintenancelabels are recognized. Release Drafter v7.1.1 may list a PR in multiple matching sections, such as Bug Fixes and Python & Bindings.Intent and triage labels such as
bug,enhancement,security,good first issue, andWIPstay manual. The stalerelease-candidaterule is removed because that label is absent from the repository. The inactive Release Drafterautolabelerblock is removed so the active automation has one configuration source.Configured labels remain automation-managed; concurrent edits to those same labels are not transactional. Rollout and backfill details are in
maintainers/release-notes.md.Validation
actionlint;git diff --checkpasses.actions/labeleraction was tested against a local mock GitHub API with dummy credentials. This used a temporary copy of the action's own bundled JavaScript outside the OTIO repository; no bundled JavaScript is added by this PR. It successfully consumed the migrated YAML and preserved a concurrently added unrelated label and a concurrently removed unrelated label while adding/removing the expected managed labels. No GitHub labels were changed by these tests.Assisted-by: OpenAI Codex / GPT-6.1 Sol