Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

Use duality serializers for EditorUserData - #860

Closed
Rick-van-Dam wants to merge 8 commits into
AdamsLair:masterfrom
Rick-van-Dam:feature/embeddockpaneldata
Closed

Rick-van-Dam wants to merge 8 commits into
AdamsLair:masterfrom
Rick-van-Dam:feature/embeddockpaneldata

Conversation

@Rick-van-Dam

@Rick-van-Dam Rick-van-Dam commented Jul 3, 2020 •

Copy link
Copy Markdown
Member

Changes:

  • Added a new way to save editoruserdata using duality serializers. Just serialize and deserialize models instead of XElements
  • Old system still works, it gets stored in a string field in PluginSettings. This prevents us from having to rewrite everything that uses this at the same time. Default settings have moved to their respective projects though with the use of EditorPlugin.GetDefaultUserData.
  • Dockpanel xml is stored in a separate string field on the DualityEditorUserData class

Issues:

  • Camview editor plugin has not been converted to the new api yet so for now keeping both systems intact. Refactorings where done in separate commits to make them easier to review or even split into a separate PR.

TODO

  • xml comments

@Rick-van-Dam Rick-van-Dam linked an issue Jul 3, 2020 that may be closed by this pull request
@Rick-van-Dam

Copy link
Copy Markdown
Member Author

rebase on master after #856 has been merged and then update it with the new changes introduced in that PR

@ilexp

ilexp commented Jul 18, 2020

Copy link
Copy Markdown
Member

Superseded by #865

@Barsonax Please document the relation of duplicate PRs / issues when closing them - makes it a lot easier to read when tracing back progress later on 🙂

@Rick-van-Dam

Copy link
Copy Markdown
Member Author

In case anyone in the future reads this. This PR was closed as I splitted up the changes into multiple PR's to make reviewing easier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Refactor/rethink how duality handles settings

2 participants