Skip to content

Allow template url to be modified via env - #1965

Closed
tarunwadhwa-paypay wants to merge 3 commits into
Agenta-AI:mainfrom
tarunwadhwa-paypay:tarunwadhwa/flexible_template_url
Closed

tarunwadhwa-paypay wants to merge 3 commits into
Agenta-AI:mainfrom
tarunwadhwa-paypay:tarunwadhwa/flexible_template_url

Conversation

@tarunwadhwa-paypay

@tarunwadhwa-paypay tarunwadhwa-paypay commented Aug 5, 2024 •

Copy link
Copy Markdown

Addresses - #1964

Allowing docker hub's template URL to be flexible to allow docker proxies to list tags without issues.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 5, 2024
@vercel

vercel Bot commented Aug 5, 2024

Copy link
Copy Markdown

@tarunwadhwa-paypay is attempting to deploy a commit to the mmabrouk's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Aug 5, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 7:05pm

@mmabrouk mmabrouk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good to me. The problem is probably something that a number of enterprises would have.

The DOCKER_HUB_URL and it's variable can be removed since they are not used anymore.

@aybruhm @aakrem what do you think? Are there changes in cloud / ee that would result from this?

@tarunwadhwa-paypay

Copy link
Copy Markdown
Author

Sorry for the inconvenience, I will be closing this PR and re-raising it again from my other GitHub account. 🙇

This branch had an error being deployed

1 failed deployment
oss — 631ba2a0 Deployed Aug 5, 2024 by tarunwadhwa-paypay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend devops size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants