Skip to content

[Enhancement] Enable automatic migration for first-time users and optionally for returning users - #1966

Merged
aakrem merged 10 commits into
mainfrom
feature/apply-migrations-for-first-time-users
Aug 6, 2024
Merged

aakrem merged 10 commits into
mainfrom
feature/apply-migrations-for-first-time-users

Conversation

@aybruhm

@aybruhm aybruhm commented Aug 5, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR introduces a db migration service that automatically applies Alembic migrations for first-time users. Returning users can also have migrations applied automatically, depending on the configured environment settings.

Related Issue

Closes AGE-506

QA

  • Clean Up Resources: Remove all containers, volumes, and images related to Agenta.
  • Start Services: Run docker-compose up to start the services.
  • Verify Backend Start: Wait until the backend services are fully started.
  • Test Application Creation: Navigate to http://localhost/apps and attempt to create an app from a template.
  • Check for Success: If the templates are visible, Alembic migrations were applied successfully.

@vercel

vercel Bot commented Aug 5, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 5:59pm

@aybruhm

aybruhm commented Aug 5, 2024 •

Copy link
Copy Markdown
Contributor Author

The fix for the failing tests is here.

@aybruhm
aybruhm marked this pull request as ready for review August 5, 2024 15:27
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. backend documentation Improvements or additions to documentation enhancement New feature or request labels Aug 5, 2024
@aybruhm
aybruhm requested review from aakrem and jp-agenta August 5, 2024 15:28

@aakrem aakrem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @aybruhm
I like the approach of utilizing a separate container. However, my concern is that users will always see the container listed as Exited, which may give the impression that something has gone wrong. Let's see how we can enhance this in the future.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 6, 2024
@aakrem
aakrem merged commit a261890 into main Aug 6, 2024
@aakrem
aakrem deleted the feature/apply-migrations-for-first-time-users branch August 6, 2024 05:30

This branch was successfully deployed

1 active and 1 inactive deployments
Preview — 8d17c0d5 Deployed Aug 5, 2024 by vercel[bot]
oss — 8d17c0d5 Deployed Aug 5, 2024 by aybruhm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants