Skip to content

fix(tool): AGE-512 fix issues in postgres container - #1968

Merged
aakrem merged 2 commits into
mainfrom
fix-postgres-issues
Aug 9, 2024
Merged

aakrem merged 2 commits into
mainfrom
fix-postgres-issues

Conversation

@aakrem

@aakrem aakrem commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

This PR fixes:

  • the clash of postgres containers between oss and cloud
  • the fatal error in the postgres error about role does not exist
2024-08-06 10:24:24.775 UTC [40] FATAL:  role "postgres" does not exist

NOTES:

  • Won't solve the issue of having cloud and oss run together.
  • postgres Volume should be deleted to have this working without issues.

@aakrem
aakrem requested review from aybruhm and jp-agenta August 6, 2024 11:05
@vercel

vercel Bot commented Aug 6, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 4:02pm

@aakrem
aakrem marked this pull request as ready for review August 6, 2024 15:08
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug labels Aug 6, 2024

@aybruhm aybruhm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @aakrem! Everything works and LGTM!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 6, 2024
@zenUnicorn

Copy link
Copy Markdown
Contributor

@aakrem, I have pulled the PR, but I still have issues with Docker.

@aybruhm

aybruhm commented Aug 6, 2024 •

Copy link
Copy Markdown
Contributor

@aakrem, I have pulled the PR, but I still have issues with Docker.

It would be really helpful if you could share a screenshot of the error you're getting or provide the full traceback. That way, anyone who can assist will have a clearer idea of what's going wrong and can provide a more accurate response.

Just saying you have issues with Docker doesn't give me enough detail to understand the problem you're facing.

@zenUnicorn

Copy link
Copy Markdown
Contributor

It would be really helpful if you could share a screenshot of the error you're getting or provide the full traceback. That way, anyone who can assist will have a clearer idea of what's going wrong and can provide a more accurate response.

Just saying you have issues with Docker doesn't give me enough detail to understand the problem you're facing.

@aybruhm Yeah, I attached the screenshot and the traceback to the thread on Slack.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
@aakrem
aakrem merged commit feb4b3a into main Aug 9, 2024
@aakrem
aakrem deleted the fix-postgres-issues branch August 9, 2024 06:55
@zenUnicorn

Copy link
Copy Markdown
Contributor

@aakrem Bug fixed ✅
Thanks.

This branch was successfully deployed

1 active deployment
Preview — 66606525 Deployed Aug 8, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants