Skip to content

chore(release): bring main (v0.124.2) into release/v0.125.0 - #7804

Merged
mmabrouk merged 14 commits into
release/v0.125.0from
sync/main-into-v0.125.0
Oct 25, 2026
Merged

mmabrouk merged 14 commits into
release/v0.125.0from
sync/main-into-v0.125.0

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

Brings main into release/v0.125.0 after the v0.124.2 release merged (#7800). It adds the Gemini stall fix (#7795), the start-up probe fix (#7801) and the changelog entries.

The merge had conflicts only on version strings (0.125.0 on the release branch, 0.124.2 on main). The merge keeps 0.125.0 and takes every other change from main unchanged.

mmabrouk and others added 14 commits October 25, 2026 16:21
… thoughts

Vertex's shared global pool leaves a few percent of gemini-3.7-flash calls
silent for minutes before the first byte. The gateway waited 300 s per
attempt and Pi retried once, so a stall cost the person up to 10 minutes.

- A streaming attempt on a route with first_byte_timeout_seconds is cut
  when it sends nothing for that long and sent again at once, from the
  existing retry budget and inside the route deadline. The built-in agenta
  route sets 60 s.
- The built-in Gemini stream asks for thought summaries, so a model that is
  thinking sends bytes and only a stall hits the limit. reasoning_effort
  moves into thinking_config (Vertex refuses both), minimal and none map to
  low (gemini-3.7-flash refuses minimal). Thoughts reach the caller as
  reasoning_content when it asked for reasoning, and lose their text when
  it did not.
- The runner reads the OpenAI client's 'Request timed out.' as the model
  provider not answering instead of an unclassified run error.
…extra_body

Review follow-ups: the limit bounds the wait for response headers (Vertex sends
them with the first output), a null extra_body still gets thought summaries, and
a reasoning_effort that is not a string is left for Vertex instead of raising.
…mini route

Off by default. When on, builtin/agenta calls ask for Vertex's Priority PayGo
tier. Google bills it above Standard and the wallet still charges Standard, so
the platform pays the difference.
….8 flash default on built-in Gemini

- The built-in route's response-headers limit is 90 s.
- Each retry of a stalled call ends the system prompt with one more newline.
  Vertex can stay stuck on one request and stall again on the identical body;
  any change the model sees answers in seconds.
- A built-in Gemini call that names no reasoning effort thinks at low instead
  of Vertex's default medium (streaming: thinking_level low; non-streaming:
  reasoning_effort low).
- gemini-3.8-flash is the first built-in model, so new agents default to it.
  Existing agents keep their saved model.
docs(docs): changelog entries for v0.123.0, v0.124.0 and v0.124.1
fix(api): stop built-in Gemini turns from hanging on stalled Vertex calls, and default to gemini-3.8-flash at low thinking
fix(helm): give api and web-mobile enough time to start on a fresh node
# Conflicts:
#	api/pyproject.toml
#	api/uv.lock
#	clients/python/pyproject.toml
#	clients/python/uv.lock
#	hosting/kubernetes/helm/Chart.yaml
#	sdks/python/pyproject.toml
#	sdks/python/uv.lock
#	services/pyproject.toml
#	services/uv.lock
#	web/ee/package.json
#	web/mobile/package.json
#	web/oss/package.json
#	web/package.json
#	web/packages/agenta-api-client/package.json
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

📘 Docs preview

Status ✅ Ready
Preview https://pr-7804-agenta-docs-preview.mahmoud-637.workers.dev/docs/
Inspect Actions run
Commit f558897dce65c889a823aeeede944719ac3e5aae

Pages changed in this pull request

This comment updates in place on every push.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

📝 Summary

Summary by CodeRabbit

  • New Features

    • Vertex AI requests can optionally use Priority PayGo.
    • Gemini requests now support configurable reasoning and thought display.
    • Release documentation covers Office file previews, location-aware comments, shareable links, a redesigned chat experience, and an SEO Content Agent template.
  • Bug Fixes

    • Streaming requests that stall while waiting for a response can retry within the request’s retry and time limits.
    • Improved handling of timed-out model requests and Gemini response data.

The pull request updates LLM gateway timeout and Gemini Vertex handling, adds release-note entries, adjusts Kubernetes startup probes, and classifies model-request timeout errors in the runner.

Changes: LLM gateway behavior

Layer / File(s) Summary
Gateway settings and endpoint contracts
api/oss/src/core/gateways/llms/catalog.py, api/oss/src/core/gateways/llms/dtos.py, api/oss/src/utils/env.py, hosting/docker-compose/*/env.*.example, api/oss/tests/pytest/unit/gateways/test_gateways_builtin_agenta.py
Adds an optional response-header timeout and stalled-attempt counter. The Agenta route sets a 90-second response-header timeout and conditionally adds Vertex priority headers. The environment setting defaults to false. The model list puts Gemini 3.8 Flash before Gemini 3.7 Flash.
Gemini Vertex thought handling
api/oss/src/core/gateways/llms/providers/passthrough/adapter.py, api/oss/src/core/gateways/llms/providers/passthrough/static_fields.py, api/oss/tests/pytest/unit/gateways/test_gateways_builtin_agenta.py
Signed Agenta Vertex Gemini requests apply streaming or non-streaming thinking defaults. Streaming response frames can move marked thought text to reasoning_content. Stalled attempts can append newlines to a system or developer message.
Streaming stall retry flow
api/oss/src/core/gateways/llms/service.py, api/oss/src/core/gateways/llms/types.py, api/oss/tests/pytest/unit/gateways/test_gateways_llm_retries.py, api/oss/tests/pytest/unit/gateways/test_gateways_builtin_agenta.py
Streaming attempts use the shorter of the response-header timeout and remaining route deadline. A response-header stall can retry within the existing shared retry budget. Route-deadline exhaustion and other timeouts raise LLMUpstreamTimeoutError.

Release note additions

Layer / File(s) Summary
New release entries
docs/blog/entries/chat-redesign-and-office-previews.mdx, docs/blog/entries/project-access-and-permissions.mdx, docs/blog/entries/project-provider-keys-only.mdx
Adds release notes about Office previews and chat changes, project access and permissions, and project provider-key behavior.

Kubernetes startup probes

Layer / File(s) Summary
Startup probe thresholds
hosting/kubernetes/helm/templates/api-deployment.yaml, hosting/kubernetes/helm/templates/web-deployment.yaml, hosting/kubernetes/helm/templates/web-mobile-deployment.yaml
Increases each startup probe timeout from 5 to 10 seconds and its failure threshold from 30 to 90.

Runner model timeout classification

Layer / File(s) Summary
Model timeout error classification
services/runner/src/engines/sandbox_agent/errors.ts, services/runner/tests/unit/model-request-timeout.test.ts
Classifies errors containing the specified “Request timed out.” phrase as upstream_error and returns a retry message. Tests also cover a differently worded timeout.

Priority: Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant LLMService
  participant PassthroughAdapter
  participant Vertex
  LLMService->>PassthroughAdapter: Start streaming attempt with selected timeout
  PassthroughAdapter->>Vertex: Send request
  Vertex-->>PassthroughAdapter: Return response headers or stall
  PassthroughAdapter-->>LLMService: Return stream or timeout
  LLMService->>LLMService: Record stall and retry within budget and deadline
Loading
Merge Risk: Low · up to f5588

These issues do not block the release, but the key guidance should be corrected and the timing-sensitive test made more reliable.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 60.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 54 functions across 11 files. (10 skipped… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title names a merge of main into release/v0.125.0 with the version bump, which matches the stated purpose of the PR. However, the title leaves out the main content the merge brings in, which is th…
Description check Passed The description states that the PR brings main into release/v0.125.0 after the v0.124.2 release. It names the Gemini stall fix, the start-up probe fix, and the changelog entries. It also explains that…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names a merge of main into release/v0.125.0 with the version bump, which matches the stated purpose of the PR. However, the title leaves out the main content the merge brings in, which is the Gemini stall fix and the start-up probe fix. The title is accurate but only partly describes the changeset. The objectives and raw summary both show that the changes are mostly Gemini stall handling, Vertex priority settings, and probe tuning, so the title covers only the merge operation.

Full details: Description check

Explanation

The description states that the PR brings main into release/v0.125.0 after the v0.124.2 release. It names the Gemini stall fix, the start-up probe fix, and the changelog entries. It also explains that version-string conflicts were resolved in favor of 0.125.0. This matches the changeset, which includes the Gemini stall handling, the Helm probe changes, and the docs and changelog entries.

Full details: Docstring Coverage

Explanation

Docstring coverage is 16.67% which is insufficient. The required threshold is 60.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 54 functions across 11 files. (10 skipped: 10 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4cc099f and f558897.

Files selected for processing: 21
  • api/oss/src/core/gateways/llms/catalog.py
  • api/oss/src/core/gateways/llms/dtos.py
  • api/oss/src/core/gateways/llms/providers/passthrough/adapter.py
  • api/oss/src/core/gateways/llms/providers/passthrough/static_fields.py
  • api/oss/src/core/gateways/llms/service.py
  • api/oss/src/core/gateways/llms/types.py
  • api/oss/src/utils/env.py
  • api/oss/tests/pytest/unit/gateways/test_gateways_builtin_agenta.py
  • api/oss/tests/pytest/unit/gateways/test_gateways_llm_retries.py
  • docs/blog/entries/chat-redesign-and-office-previews.mdx
  • docs/blog/entries/project-access-and-permissions.mdx
  • docs/blog/entries/project-provider-keys-only.mdx
  • hosting/docker-compose/ee/env.ee.dev.example
  • hosting/docker-compose/ee/env.ee.gh.example
  • hosting/docker-compose/oss/env.oss.dev.example
  • hosting/docker-compose/oss/env.oss.gh.example
  • hosting/kubernetes/helm/templates/api-deployment.yaml
  • hosting/kubernetes/helm/templates/web-deployment.yaml
  • hosting/kubernetes/helm/templates/web-mobile-deployment.yaml
  • services/runner/src/engines/sandbox_agent/errors.ts
  • services/runner/tests/unit/model-request-timeout.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

with pytest.raises(LLMUpstreamTimeoutError):
await _relay(
_service(
adapter, timeout_seconds=0.15, response_headers_timeout_seconds=0.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Widen the timing margin in test_a_stall_retry_never_runs_past_the_routes_deadline.

The test passes only if the first stall ends before the 0.15 s route deadline. After the 0.1 s cut, _may_retry checks loop.time() < deadline. The margin is 50 ms. A loaded CI runner can delay the event loop by more than that. _may_retry then returns false and the test sees one call instead of two. The test becomes flaky.

Use a larger margin. Keep the ratio so the second attempt still has less time left than response_headers_timeout_seconds.

Proposed fix
--- "a/api/oss/tests/pytest/unit/gateways/test_gateways_llm_retries.py"
+++ "b/api/oss/tests/pytest/unit/gateways/test_gateways_llm_retries.py"
@@ -463,9 +463,9 @@
 
     with pytest.raises(LLMUpstreamTimeoutError):
         await _relay(
-            _service(
-                adapter, timeout_seconds=0.15, response_headers_timeout_seconds=0.1
-            ),
+            _service(
+                adapter, timeout_seconds=0.4, response_headers_timeout_seconds=0.25
+            ),
             stream=True,
         )
 
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
adapter, timeout_seconds=0.15, response_headers_timeout_seconds=0.1
adapter, timeout_seconds=0.4, response_headers_timeout_seconds=0.25


## Removal takes effect at the next request

When you remove a member, change a role or delete a key, the API refuses the next request. A run that started just before the change ends at its first checked call with `403 access_denied`. A removed member who calls an agent gets this error instead of a generic failure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Security & Privacy · Quick win

Qualify the API-key revocation timing.

Line 36 says a deleted key can remain usable for about five seconds. This sentence and the summary instead promise that deletion takes effect at the next request. State the delay in both places so readers do not treat key deletion as immediate revocation.


<Summary>

Prompts and evaluators now run on the provider keys saved in the project. A project without a key for a provider gets the error "No API key found for model". Add the key in **Settings > Providers & Models**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

State when a missing project key causes an error.

In OSS, a project without a saved key can use a matching services-container key by default. Lines 28–35 describe that fallback. Qualify the error claim here and in Line 23: the run fails when neither a project key nor an enabled fallback key is available. (docs.agenta.ai)

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Item Value
Status stopped
Commit f558897dce65c889a823aeeede944719ac3e5aae
Manual expiry (UTC) Not granted
CI deadline (UTC) Not granted
Workflow https://github.com/Agenta-AI/agenta/actions/runs/40224890056

PR closed or converted to draft. Environment absence verified; retained storage requires separate provider accounting.

Post /preview as a new comment to request a one-hour preview. Repeating it while active does not extend the hour.
Preview data is disposable. Expiry is enforced by the next successful cleanup sweep, not an exact timer.
Environment deletion stops its compute. Provider-retained storage and permanent services may still be billed.

@mmabrouk
mmabrouk merged commit 86f406a into release/v0.125.0 Oct 25, 2026
72 of 74 checks passed
@mmabrouk
mmabrouk deleted the sync/main-into-v0.125.0 branch October 25, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant