Skip to content

fix(frontend): Finish classic, evaluations and data screens after a full audit - #8342

Open
ashrafchowdury wants to merge 2 commits into
release/v0.129.0from
fix/mobile-polish-release
Open

ashrafchowdury wants to merge 2 commits into
release/v0.129.0from
fix/mobile-polish-release

Conversation

@ashrafchowdury

@ashrafchowdury ashrafchowdury commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Context

Two audit passes over /m found about 100 problems in the classic screens (prompts, playground, registry), evaluations, test sets, queues, observability and settings. The worst ones:

  • Several pages scrolled the whole window sideways.
  • The test set grid grew taller forever.
  • An evaluator's Evaluations page was empty.
  • A new prompt made inside a folder landed in the root.
  • Registry Compare showed the playground draft as the committed revision.

The rest were unfinished-looking details: Title Case labels, "testset" spelling and toast-only validation.

Changes

Layout

  • ListTable's scroll box is now relative, so its absolutely positioned sr-only header cells stay inside it and no longer widen the window. The chart's sr-only <table> sits in a div.sr-only for the same reason.
  • The test set page gives the grid a definite height (flex-1 min-h-0 down the chain). Before, the grid measured its own content and grew about 1.5px a second.
  • VirtualTable: a column outside every header group spans the header rows, instead of leaving an empty cell above its title.

Data

  • The test sets list keeps the highest version per test set. /testsets/revisions/query ignores the per-ref limit and returns revisions in no order, so the list used to show a stale commit message.
  • On an evaluator's own page (/apps/<evaluatorId>/evaluations) the runs list filters by evaluator, not application.
  • A prompt created in a folder sends the folder at the top level of the create request, which is where ArtifactCreate reads it:
    before: {workflow: {meta: {folder_id: "f1"}}}   ignored by the API
    after:  {workflow: {folder_id: "f1"}}
    
  • Registry Compare diffs serverData, the committed revision, not the merged draft.
  • Trace times show in local time. Root agent spans fall back to the derived output the traces table shows.
  • One rule now humanizes metric labels on every evaluation screen (metricDisplayLabel).

Flows

  • New evaluation sheet: errors show next to the field or step, not in toasts. Batch size must be at least 1. Several revisions get one run name each.
  • Trace delete: one dialog for the whole app, in TraceDrawer. It closes the drawer when the open trace is deleted.
  • Filter dialog: Clear empties only the draft, and Cancel brings back the applied filters.
  • Leave guards push the route without the /m basePath; before, leaving opened /m/m/... and a 404.

Copy

  • Sentence case and the product nouns ("test set", "test case", "prompt") across the touched screens. The text lives in the @agenta/i18n English catalogs, and every new key has translations in all six languages (pnpm i18n:check passes).

Not in this PR:

  • Errored outputs are scored as false. The evaluator backend needs that fix.
  • Human runs do not store revision versions (humanRunConfig.ts). The backend needs to accept a version in the run references first.
  • The dark-mode Running badge contrast. On this branch, palette.ts still lives in web/oss.

Tests

  • Type check is clean for web/mobile and the 12 changed packages. Lint is clean, and pnpm i18n:check passes.
  • Mobile unit tests: 68 changed files, 729 tests pass. testsetsListDeveloperMode passes under TZ=UTC, the CI time zone; it formats a fixed time in local time.
  • Package tests pass in entities, entity-ui, observability(-ui), settings-ui, shared, ui and annotation.
  • These tests fail on the old code and pass now:
    • createPrompt "New prompt inside a folder…"
    • testset-latest-revisions
    • listTableSrOnlyContained
    • evaluationRunsList (the evaluator scope)
    • filterDialog.render
    • unsavedGuard
    • appNavScopeSwitch
    • variantsData (the empty v0 seed)
    • registryCompare.render
  • Built /m in production mode and checked the pages below in Chrome. At 400px wide, the runs list, run overview, observability, settings and app overview show no sideways scroll.

Demo

Before: the app at the start of the audit. After: a production build of /m with these changes on the same local data.

Evaluation runs list on the local EE stack, desktop width.

Before After
before-runs-list after-runs-list
The whole window scrolls sideways (page about 2,100px wide). The page fits; only the table scrolls inside its box.

Test set qa2-upload, left open for a minute.

Before After
before-testset-grid after-testset-grid
The grid keeps growing past the viewport and the page scrolls. The grid keeps one height (609px after 8 seconds and after).

Run overview at 400px wide.

Before After
before-run-overview-narrow after-run-overview-narrow
The page scrolls sideways by about 220px because of the chart's hidden table. No sideways scroll.

Settings, API keys tab.

Before After
before-api-keys after-api-keys
Title Case labels ("API Keys", "Access & Security", "Audit Log"). Sentence case labels; dates in one format.

Observability traces of an agent.

Before After
before-trace-names after-trace-names
Every root trace is named _agent. The trace shows the agent's name.

Observability time range menu.

Before After
before-range-menu after-range-menu
The applied range has no visible selected state. The applied range is highlighted with a check mark; arrow keys move between rows.

Settings, Secrets tab, with the secrets request failing.

Before After
before-secrets after-secrets
The table shows a loading skeleton forever. An error state with a Try again button.

Trace drawer opened from a link to a deleted trace.

Before After
before-trace-notfound after-trace-notfound
Empty Raw Data and skeletons that never finish. "Trace not found" with the likely reason.

Trace drawer of an agent chat span, scrolled down.

Before After
before-trace-tabs after-trace-tabs
The tabs are see-through and overlap the content; the output is a raw JSON array. The tab bar is solid; the output shows as an Assistant message.

Test set, Commit after editing one cell.

Before After
before-commit-preview after-commit-preview
Changes preview is empty although it says 2 changes. The preview shows the diff of the edited row.

Test set grid, hover a long cell.

Before After
before-cell-popover after-cell-popover
The popover opens over the cell and hides the rows above. The popover opens beside the cell.

Playground of a new prompt, Create.

Before After
before-create-dialog after-create-dialog
A brand-new prompt shows "What's changing: 3 changes". Only the name, slug and message fields.

Playground with an edited draft, click Registry, then Confirm in the leave dialog.

Before After
before-leave-confirm after-leave-confirm
Confirm keeps you on the playground. Confirm opens the Registry.

Registry, Deployments tab, after deploying a newer revision to staging.

Before After
before-deploy-card after-deploy-card
Staging "Last modified" shows the variant's commit time (7:02 PM), not the deploy time (7:06 PM). "Last modified" matches the latest deployment.

New evaluation, pick a test set that has no column for a prompt input.

Before After
before-testset-columns after-testset-columns
Nothing warns you; every row fails later. A warning names the missing column before you start.

Evaluation runs, empty project.

Before After
before-evals-empty after-evals-empty
The empty state sits off-center and a scrollbar shows next to the tabs. The empty state is centered and the tabs have no scrollbar.

Run details, Configuration tab.

Before After
before-run-config after-run-config
The prompt shows in tall monospace editors with empty space. The prompt uses the normal text style and fits its content.

Run details, Overview tab of a run with one evaluator.

Before After
before-run-summary after-run-summary
"Evaluator Scores Overview" with an empty radar chart taking half the card. "Run summary" uses the full width; the radar shows only when it has data.

Annotation queues list, desktop width.

Before After
before-queues-table after-queues-table
The row menu is cut off at the right edge. The table fits and the row menu is visible.
The logic fixes (folder on create, evaluator runs scope, latest revision per test set, filter Clear/Cancel, leave guard route) are proven by the failing-then-passing tests listed under Tests.

What to QA

  • Evaluation runs list, desktop and 400px wide: the page does not scroll sideways; only the table does.
  • Open a test set and wait a minute: the grid keeps its height and the page does not scroll.
  • Prompts: open a folder, then New prompt → Create. The prompt shows inside that folder.
  • Evaluators → open an evaluator's Evaluations page: the runs that used it are listed.
  • Observability: open the time range menu. The applied range has a check mark, and the arrow keys move between rows.
  • Delete the trace that is open in the drawer: one dialog, and the drawer closes.
  • Regression: the playground leave prompt still shows for an edited local copy and not for an untouched one.

…ull audit

Two audit passes over /m found layout breaks, wrong data and unfinished copy.
This fixes them on top of the release branch, with the copy in the i18n catalogs.

- Layout: runs list, run overview and narrow pages no longer scroll sideways;
  the test set grid stops growing; trace drawer tabs no longer overlap.
- Data: the test sets list shows the latest revision's message; an evaluator's
  Evaluations page lists its runs; Registry Compare diffs the committed revision;
  a new prompt in a folder is created in that folder; trace times are local.
- Flows: leave guards push the route without the /m basePath; inline validation
  in the new evaluation sheet; one trace delete dialog that closes the drawer.
- Copy: sentence case and product nouns across settings, test sets, queues,
  observability and the playground, with translations for every new key.
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 457 files, which is 157 over the limit of 300.

To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch.

Usage-priced reviews support at most 300 files.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5e5f595 and 3341143.

Files selected for processing: 457

  • web/mobile/src/components/PageNotFound.tsx
  • web/mobile/src/features/annotations/AddToTestsetModal.tsx
  • web/mobile/src/features/annotations/CreateQueueForm.tsx
  • web/mobile/src/features/annotations/CreateQueueSheet.tsx
  • web/mobile/src/features/annotations/FocusFooter.tsx
  • web/mobile/src/features/annotations/FocusScenarioPicker.tsx
  • web/mobile/src/features/annotations/QueueEvaluatorCard.tsx
  • web/mobile/src/features/annotations/QueueListScreen.tsx
  • web/mobile/src/features/annotations/QueueListTable.tsx
  • web/mobile/src/features/annotations/QueueRowCells.tsx
  • web/mobile/src/features/annotations/QueueSessionScreen.tsx
  • web/mobile/src/features/annotations/ScenarioListTab.tsx
  • web/mobile/src/features/annotations/ScenarioTraceIOCell.tsx
  • web/mobile/src/features/annotations/TestcaseScenarioContent.tsx
  • web/mobile/src/features/annotations/addToTestsetTarget.ts
  • web/mobile/src/features/annotations/states/AllCaughtUp.tsx
  • web/mobile/src/features/annotations/states/QueueEmpty.tsx
  • web/mobile/src/features/annotations/states/QueuesFirstRun.tsx
  • web/mobile/src/features/annotations/useAddToTestsetToast.ts
  • web/mobile/src/features/annotations/useSubmitAnnotations.ts
  • web/mobile/src/features/app-overview/AppActionsMenu.tsx
  • web/mobile/src/features/app-overview/AppDeploymentSection.tsx
  • web/mobile/src/features/app-overview/AppOverviewScreen.tsx
  • web/mobile/src/features/app-overview/AppRecentPromptsSection.tsx
  • web/mobile/src/features/app-overview/AppUsageSection.tsx
  • web/mobile/src/features/archived-apps/ArchivedAppsScreen.tsx
  • web/mobile/src/features/archived-apps/ArchivedAppsTable.tsx
  • web/mobile/src/features/archived-apps/states/ArchivedAppsEmpty.tsx
  • web/mobile/src/features/automations/useUnsavedGuard.ts
  • web/mobile/src/features/developer/developerNavItems.ts
  • web/mobile/src/features/evaluation-run/RunDetailsBody.tsx
  • web/mobile/src/features/evaluation-run/RunEvaluatorPicker.tsx
  • web/mobile/src/features/evaluation-run/compare/CompareRunChip.tsx
  • web/mobile/src/features/evaluation-run/compare/CompareRunRow.tsx
  • web/mobile/src/features/evaluation-run/compare/RunCompareBar.tsx
  • web/mobile/src/features/evaluation-run/compare/compareChipStyle.ts
  • web/mobile/src/features/evaluation-run/compare/overview/CompareMetricCard.tsx
  • web/mobile/src/features/evaluation-run/compare/overview/CompareOverviewTab.tsx
  • web/mobile/src/features/evaluation-run/compare/overview/useCompareOverview.ts
  • web/mobile/src/features/evaluation-run/configuration/ApplicationConfigSection.tsx
  • web/mobile/src/features/evaluation-run/configuration/EvaluatorConfigCard.tsx
  • web/mobile/src/features/evaluation-run/focus/RunAnnotateBody.tsx
  • web/mobile/src/features/evaluation-run/focus/RunInvocationPanel.tsx
  • web/mobile/src/features/evaluation-run/focus/ScenarioFocusBody.tsx
  • web/mobile/src/features/evaluation-run/focus/ScenarioFocusHeader.tsx
  • web/mobile/src/features/evaluation-run/focus/ScenarioFocusSheet.tsx
  • web/mobile/src/features/evaluation-run/focus/ScenarioMetricsBlock.tsx
  • web/mobile/src/features/evaluation-run/metricLabel.ts
  • web/mobile/src/features/evaluation-run/overview/MetricCard.tsx
  • web/mobile/src/features/evaluation-run/overview/MetricCardsSection.tsx
  • web/mobile/src/features/evaluation-run/overview/RunOverviewView.tsx
  • web/mobile/src/features/evaluation-run/overview/RunRadarCard.tsx
  • web/mobile/src/features/evaluation-run/overview/RunStatusDot.tsx
  • web/mobile/src/features/evaluation-run/overview/RunSummaryTable.tsx
  • web/mobile/src/features/evaluation-run/overview/runSummaryRows.tsx
  • web/mobile/src/features/evaluation-run/overview/useRunOverview.ts
  • web/mobile/src/features/evaluation-run/scenarios/ScenarioCard.tsx
  • web/mobile/src/features/evaluation-run/scenarios/ScenarioGroupCell.tsx
  • web/mobile/src/features/evaluation-run/scenarios/ScenarioLabeledValue.tsx
  • web/mobile/src/features/evaluation-run/scenarios/ScenariosTab.tsx
  • web/mobile/src/features/evaluation-run/scenarios/scenarioTableColumns.ts
  • web/mobile/src/features/evaluations/list/EvaluationRunsTable.tsx
  • web/mobile/src/features/evaluations/list/EvaluationsScreen.tsx
  • web/mobile/src/features/evaluations/list/RunRowCells.tsx
  • web/mobile/src/features/evaluations/list/runStatusDotColor.ts
  • web/mobile/src/features/evaluations/list/runsScope.ts
  • web/mobile/src/features/evaluations/list/states/EvaluationsEmpty.tsx
  • web/mobile/src/features/evaluations/list/useEvaluationRunsFilters.ts
  • web/mobile/src/features/evaluations/list/useEvaluationRunsList.ts
  • web/mobile/src/features/evaluations/list/useRunsTableLayout.ts
  • web/mobile/src/features/evaluations/live/LiveEvaluationForm.tsx
  • web/mobile/src/features/evaluations/live/LiveEvaluatorSection.tsx
  • web/mobile/src/features/evaluations/live/LiveTraceFilter.tsx
  • web/mobile/src/features/evaluations/new/AdvancedSettingsSection.tsx
  • web/mobile/src/features/evaluations/new/AppSection.tsx
  • web/mobile/src/features/evaluations/new/EvaluatorsSection.tsx
  • web/mobile/src/features/evaluations/new/ExpandToggle.tsx
  • web/mobile/src/features/evaluations/new/ExpectedVariables.tsx
  • web/mobile/src/features/evaluations/new/NewEvaluationForm.tsx
  • web/mobile/src/features/evaluations/new/RevisionSection.tsx
  • web/mobile/src/features/evaluations/new/SdkEvaluationSheet.tsx
  • web/mobile/src/features/evaluations/new/StepItem.tsx
  • web/mobile/src/features/evaluations/new/TestsetColumnsWarning.tsx
  • web/mobile/src/features/evaluations/new/TestsetSection.tsx
  • web/mobile/src/features/evaluations/new/missingInputColumns.ts
  • web/mobile/src/features/evaluations/new/newEvaluationDraft.ts
  • web/mobile/src/features/evaluations/new/testsetColumnKeys.ts
  • web/mobile/src/features/evaluations/new/useExpectedInputVariables.ts
  • web/mobile/src/features/evaluations/new/useMissingInputColumns.ts
  • web/mobile/src/features/evaluations/new/useStartEvaluation.ts
  • web/mobile/src/features/evaluators/ArchivedEvaluatorsTable.tsx
  • web/mobile/src/features/evaluators/EvaluatorRowCells.tsx
  • web/mobile/src/features/evaluators/EvaluatorsTable.tsx
  • web/mobile/src/features/nav/appNavScope.tsx
  • web/mobile/src/features/nav/mobileNavScope.tsx
  • web/mobile/src/features/observability/ObservabilityScreen.tsx
  • web/mobile/src/features/observability/TracesFilters.tsx
  • web/mobile/src/features/observability/annotate/states/TraceAnnotateEmpty.tsx
  • web/mobile/src/features/playground/RevisionMenu.tsx
  • web/mobile/src/features/playground/useEvaluatorPlaygroundSelection.ts
  • web/mobile/src/features/playground/usePlaygroundLeaveGuard.ts
  • web/mobile/src/features/playground/usePlaygroundSelection.ts
  • web/mobile/src/features/prompts/PromptsScreen.tsx
  • web/mobile/src/features/prompts/promptsCopy.ts
  • web/mobile/src/features/prompts/useCreatePrompt.ts
  • web/mobile/src/features/settings/AccessSecurityTab.tsx
  • web/mobile/src/features/settings/AuditLogTab.tsx
  • web/mobile/src/features/settings/BillingTab.tsx
  • web/mobile/src/features/settings/PlanSummaryCard.tsx
  • web/mobile/src/features/settings/SeePlansButton.tsx
  • web/mobile/src/features/settings/SettingsScreen.tsx
  • web/mobile/src/features/settings/settingsNavScope.tsx
  • web/mobile/src/features/testsets/archived/ArchivedTestsetsTable.tsx
  • web/mobile/src/features/testsets/detail/ColumnDialogs.tsx
  • web/mobile/src/features/testsets/detail/CommitTestsetDialog.tsx
  • web/mobile/src/features/testsets/detail/TestcaseEditorDrawer.tsx
  • web/mobile/src/features/testsets/detail/TestcaseEditorDrawerContent.tsx
  • web/mobile/src/features/testsets/detail/TestcaseRowMenu.tsx
  • web/mobile/src/features/testsets/detail/TestsetCopyControl.tsx
  • web/mobile/src/features/testsets/detail/TestsetDetailScreen.tsx
  • web/mobile/src/features/testsets/detail/TestsetGrid.tsx
  • web/mobile/src/features/testsets/detail/TestsetHeader.tsx
  • web/mobile/src/features/testsets/detail/TestsetToolbar.tsx
  • web/mobile/src/features/testsets/detail/useTestsetEditor.ts
  • web/mobile/src/features/testsets/list/TestsetRevisionRows.tsx
  • web/mobile/src/features/testsets/list/TestsetRowMenu.tsx
  • web/mobile/src/features/testsets/list/TestsetsDateFilter.tsx
  • web/mobile/src/features/testsets/list/TestsetsListScreen.tsx
  • web/mobile/src/features/testsets/list/TestsetsTable.tsx
  • web/mobile/src/features/testsets/list/states/TestsetsEmpty.tsx
  • web/mobile/src/features/testsets/list/useTestsetRowActions.ts
  • web/mobile/src/features/variants/CompareRevisionsDialog.tsx
  • web/mobile/src/features/variants/DeployToEnvironmentDialog.tsx
  • web/mobile/src/features/variants/DeploymentRowMenu.tsx
  • web/mobile/src/features/variants/DeploymentsTab.tsx
  • web/mobile/src/features/variants/EnvironmentCards.tsx
  • web/mobile/src/features/variants/RegistryRowCells.tsx
  • web/mobile/src/features/variants/RevertDeploymentDialog.tsx
  • web/mobile/src/features/variants/VariantRowMenu.tsx
  • web/mobile/src/features/variants/VariantsScreen.tsx
  • web/mobile/src/features/variants/VariantsTable.tsx
  • web/mobile/src/features/variants/useAppDeploymentHistory.ts
  • web/mobile/src/features/variants/useAppRevisions.ts
  • web/mobile/src/features/variants/useLastDeployedAt.ts
  • web/mobile/src/features/wallet/CreditsHero.tsx
  • web/mobile/src/features/wallet/CreditsTab.tsx
  • web/mobile/src/styles/globals.css
  • web/mobile/tests/unit/annotatedTracesFilter.render.test.tsx
  • web/mobile/tests/unit/annotationAddToTestset.render.test.tsx
  • web/mobile/tests/unit/annotationConfiguration.render.test.tsx
  • web/mobile/tests/unit/annotationCreateQueue.render.test.tsx
  • web/mobile/tests/unit/annotationFocusView.render.test.tsx
  • web/mobile/tests/unit/annotationFormPanel.render.test.tsx
  • web/mobile/tests/unit/annotationPackageLink.test.ts
  • web/mobile/tests/unit/annotationQueueListScreen.render.test.tsx
  • web/mobile/tests/unit/annotationQueueTable.render.test.tsx
  • web/mobile/tests/unit/annotationScenarioList.render.test.tsx
  • web/mobile/tests/unit/annotationSessionShell.render.test.tsx
  • web/mobile/tests/unit/appActionsMenu.render.test.tsx
  • web/mobile/tests/unit/appEvaluationsSection.render.test.tsx
  • web/mobile/tests/unit/appNavScopeSwitch.test.tsx
  • web/mobile/tests/unit/appOverviewSections.render.test.tsx
  • web/mobile/tests/unit/appUsageSection.render.test.tsx
  • web/mobile/tests/unit/archivedAppsParity.render.test.tsx
  • web/mobile/tests/unit/archivedAppsScreen.render.test.tsx
  • web/mobile/tests/unit/archivedAppsTable.render.test.tsx
  • web/mobile/tests/unit/commandPaletteDeveloper.render.test.tsx
  • web/mobile/tests/unit/createPrompt.render.test.tsx
  • web/mobile/tests/unit/deploymentsTab.render.test.tsx
  • web/mobile/tests/unit/developerRail.test.ts
  • web/mobile/tests/unit/editableRevisionDrawer.render.test.tsx
  • web/mobile/tests/unit/evaluationRunsList.test.tsx
  • web/mobile/tests/unit/evaluationsScreen.render.test.tsx
  • web/mobile/tests/unit/liveEvaluationSheet.render.test.tsx
  • web/mobile/tests/unit/metricDisplayLabel.test.ts
  • web/mobile/tests/unit/missingInputColumns.test.ts
  • web/mobile/tests/unit/mobileNavSelection.test.ts
  • web/mobile/tests/unit/newEvaluationDraft.test.ts
  • web/mobile/tests/unit/newEvaluationEvaluators.render.test.tsx
  • web/mobile/tests/unit/newEvaluationSections.render.test.tsx
  • web/mobile/tests/unit/newEvaluationSheet.render.test.tsx
  • web/mobile/tests/unit/newEvaluationStepItem.render.test.tsx
  • web/mobile/tests/unit/observabilitySelectionActions.render.test.tsx
  • web/mobile/tests/unit/pageNotFoundBack.render.test.tsx
  • web/mobile/tests/unit/planSummaryRenewal.render.test.tsx
  • web/mobile/tests/unit/playgroundAddToTestset.render.test.tsx
  • web/mobile/tests/unit/playgroundCompareRuns.render.test.tsx
  • web/mobile/tests/unit/playgroundCreateTestset.render.test.tsx
  • web/mobile/tests/unit/playgroundFocusDrawer.render.test.tsx
  • web/mobile/tests/unit/playgroundLoadTestsetDialog.render.test.tsx
  • web/mobile/tests/unit/playgroundNewEvaluation.render.test.tsx
  • web/mobile/tests/unit/playgroundRefinePrompt.render.test.tsx
  • web/mobile/tests/unit/playgroundRevisionActions.render.test.tsx
  • web/mobile/tests/unit/playgroundScreen.render.test.tsx
  • web/mobile/tests/unit/playgroundTestsetDialogs.render.test.tsx
  • web/mobile/tests/unit/registryCompare.render.test.tsx
  • web/mobile/tests/unit/runAnnotateTab.render.test.tsx
  • web/mobile/tests/unit/runCompare.render.test.tsx
  • web/mobile/tests/unit/runConfigEvaluators.render.test.tsx
  • web/mobile/tests/unit/runConfigSections.render.test.tsx
  • web/mobile/tests/unit/runDetailsShell.render.test.tsx
  • web/mobile/tests/unit/runOverviewCharts.render.test.tsx
  • web/mobile/tests/unit/runScenarioFocus.render.test.tsx
  • web/mobile/tests/unit/runScenariosTab.render.test.tsx
  • web/mobile/tests/unit/runScenariosTable.render.test.tsx
  • web/mobile/tests/unit/runSummaryTable.render.test.tsx
  • web/mobile/tests/unit/sdkEvaluationSheet.render.test.tsx
  • web/mobile/tests/unit/startEvaluation.test.tsx
  • web/mobile/tests/unit/testsetCommit.render.test.tsx
  • web/mobile/tests/unit/testsetEditorCommit.test.ts
  • web/mobile/tests/unit/testsetGrid.render.test.tsx
  • web/mobile/tests/unit/testsetHeader.render.test.tsx
  • web/mobile/tests/unit/testsetQueue.render.test.tsx
  • web/mobile/tests/unit/testsetRowActions.test.ts
  • web/mobile/tests/unit/testsetsListDeveloperMode.render.test.tsx
  • web/mobile/tests/unit/testsetsListScreen.render.test.tsx
  • web/mobile/tests/unit/testsetsTable.render.test.tsx
  • web/mobile/tests/unit/traceAnnotateSheet.render.test.tsx
  • web/mobile/tests/unit/traceDrawerLazy.render.test.tsx
  • web/mobile/tests/unit/unsavedGuard.test.tsx
  • web/mobile/tests/unit/useOverviewNames.render.test.tsx
  • web/mobile/tests/unit/variantsData.test.tsx
  • web/packages/agenta-annotation/src/state/addToTestset.ts
  • web/packages/agenta-annotation/src/state/controllers/annotationFormController.ts
  • web/packages/agenta-annotation/src/state/controllers/annotationSessionController.ts
  • web/packages/agenta-annotation/src/state/queueLabels.ts
  • web/packages/agenta-annotation/src/state/sessionTabs.ts
  • web/packages/agenta-annotation/src/state/testsetSync.ts
  • web/packages/agenta-annotation/tests/unit/queueStatus.test.ts
  • web/packages/agenta-auth-ui/src/NotFoundScreen.tsx
  • web/packages/agenta-entities/src/secret/state/useVaultSecret.ts
  • web/packages/agenta-entities/src/testset/api/api.ts
  • web/packages/agenta-entities/src/workflow/api/api.ts
  • web/packages/agenta-entities/src/workflow/core/schema.ts
  • web/packages/agenta-entities/src/workflow/state/appUtils.ts
  • web/packages/agenta-entities/src/workflow/state/commit.ts
  • web/packages/agenta-entities/src/workflow/state/store.ts
  • web/packages/agenta-entities/tests/unit/commit-invalidations.test.ts
  • web/packages/agenta-entities/tests/unit/promptWorkflowsRecency.test.ts
  • web/packages/agenta-entities/tests/unit/testset-latest-revisions.test.ts
  • web/packages/agenta-entities/tests/unit/workflowTypeLabelAgent.test.ts
  • web/packages/agenta-entity-ui/src/DrillInView/SchemaControls/NumberSliderControl.tsx
  • web/packages/agenta-entity-ui/src/DrillInView/SchemaControls/agentTemplate/AgentIntegrationDrawer.tsx
  • web/packages/agenta-entity-ui/src/DrillInView/components/PlaygroundConfigSection.tsx
  • web/packages/agenta-entity-ui/src/DrillInView/components/PlaygroundConfigSection/FallbackConfigTab.tsx
  • web/packages/agenta-entity-ui/src/DrillInView/components/PlaygroundConfigSection/configPopoverControls.tsx
  • web/packages/agenta-entity-ui/src/adapters/variantAdapters.ts
  • web/packages/agenta-entity-ui/src/gatewayTool/components/FinishConnectionDialog.tsx
  • web/packages/agenta-entity-ui/src/modals/commit/components/EntityCommitContent.tsx
  • web/packages/agenta-entity-ui/src/selection/adapters/evaluatorLabelUtils.ts
  • web/packages/agenta-entity-ui/src/selection/components/UnifiedEntityPicker/variants/PopoverCascaderVariant.tsx
  • web/packages/agenta-entity-ui/src/selection/components/UnifiedEntityPicker/variants/TreeSelectPopupContent.tsx
  • web/packages/agenta-entity-ui/src/testcase/TestcaseDataEditor.tsx
  • web/packages/agenta-entity-ui/src/testcase/codeFormat.ts
  • web/packages/agenta-entity-ui/src/variant/components/EnvironmentStatus.tsx
  • web/packages/agenta-entity-ui/tests/unit/finishConnectionDialogApiKey.render.test.tsx
  • web/packages/agenta-entity-ui/tests/unit/testcaseCodeParseError.test.ts
  • web/packages/agenta-entity-ui/tests/unit/treeSelectPopupContent.render.test.tsx
  • web/packages/agenta-entity-ui/tests/unit/variantCommitNewPrompt.test.ts
  • web/packages/agenta-i18n/locales/de-DE/auth.notFound.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.commitModal.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.playgroundConfig.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.schemaControls.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.testcase.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.toolConnections.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.variant.json
  • web/packages/agenta-i18n/locales/de-DE/observability.annotate.json
  • web/packages/agenta-i18n/locales/de-DE/observabilityUi.deleteTrace.json
  • web/packages/agenta-i18n/locales/de-DE/observabilityUi.traceDrawer.json
  • web/packages/agenta-i18n/locales/de-DE/playground.commit.json
  • web/packages/agenta-i18n/locales/de-DE/playground.panels.json
  • web/packages/agenta-i18n/locales/de-DE/playground.refine.json
  • web/packages/agenta-i18n/locales/de-DE/settings.providers.json
  • web/packages/agenta-i18n/locales/de-DE/settings.secrets.json
  • web/packages/agenta-i18n/locales/de-DE/settings.shared.json
  • web/packages/agenta-i18n/locales/en/auth.notFound.json
  • web/packages/agenta-i18n/locales/en/entityUi.commitModal.json
  • web/packages/agenta-i18n/locales/en/entityUi.connectForm.json
  • web/packages/agenta-i18n/locales/en/entityUi.playgroundConfig.json
  • web/packages/agenta-i18n/locales/en/entityUi.schemaControls.json
  • web/packages/agenta-i18n/locales/en/entityUi.selection.json
  • web/packages/agenta-i18n/locales/en/entityUi.testcase.json
  • web/packages/agenta-i18n/locales/en/entityUi.toolConnections.json
  • web/packages/agenta-i18n/locales/en/entityUi.triggerConnect.json
  • web/packages/agenta-i18n/locales/en/entityUi.variant.json
  • web/packages/agenta-i18n/locales/en/navigation.json
  • web/packages/agenta-i18n/locales/en/observability.addToTestset.json
  • web/packages/agenta-i18n/locales/en/observability.annotate.json
  • web/packages/agenta-i18n/locales/en/observabilityUi.actions.json
  • web/packages/agenta-i18n/locales/en/observabilityUi.columns.json
  • web/packages/agenta-i18n/locales/en/observabilityUi.deleteTrace.json
  • web/packages/agenta-i18n/locales/en/observabilityUi.filters.json
  • web/packages/agenta-i18n/locales/en/observabilityUi.traceDrawer.json
  • web/packages/agenta-i18n/locales/en/observabilityUi.traceSpan.json
  • web/packages/agenta-i18n/locales/en/playground.commit.json
  • web/packages/agenta-i18n/locales/en/playground.panels.json
  • web/packages/agenta-i18n/locales/en/playground.refine.json
  • web/packages/agenta-i18n/locales/en/playground.runs.json
  • web/packages/agenta-i18n/locales/en/playground.testsets.json
  • web/packages/agenta-i18n/locales/en/settings.access.json
  • web/packages/agenta-i18n/locales/en/settings.apiKeys.json
  • web/packages/agenta-i18n/locales/en/settings.audit.json
  • web/packages/agenta-i18n/locales/en/settings.projects.json
  • web/packages/agenta-i18n/locales/en/settings.providers.json
  • web/packages/agenta-i18n/locales/en/settings.secrets.json
  • web/packages/agenta-i18n/locales/en/settings.shared.json
  • web/packages/agenta-i18n/locales/en/settings.tools.json
  • web/packages/agenta-i18n/locales/en/ui.loadError.json
  • web/packages/agenta-i18n/locales/es-ES/auth.notFound.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.commitModal.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.playgroundConfig.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.schemaControls.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.testcase.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.toolConnections.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.variant.json
  • web/packages/agenta-i18n/locales/es-ES/observability.annotate.json
  • web/packages/agenta-i18n/locales/es-ES/observabilityUi.deleteTrace.json
  • web/packages/agenta-i18n/locales/es-ES/observabilityUi.traceDrawer.json
  • web/packages/agenta-i18n/locales/es-ES/playground.commit.json
  • web/packages/agenta-i18n/locales/es-ES/playground.panels.json
  • web/packages/agenta-i18n/locales/es-ES/playground.refine.json
  • web/packages/agenta-i18n/locales/es-ES/settings.providers.json
  • web/packages/agenta-i18n/locales/es-ES/settings.secrets.json
  • web/packages/agenta-i18n/locales/es-ES/settings.shared.json
  • web/packages/agenta-i18n/locales/fr-FR/auth.notFound.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.commitModal.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.playgroundConfig.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.schemaControls.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.testcase.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.toolConnections.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.variant.json
  • web/packages/agenta-i18n/locales/fr-FR/observability.annotate.json
  • web/packages/agenta-i18n/locales/fr-FR/observabilityUi.deleteTrace.json
  • web/packages/agenta-i18n/locales/fr-FR/observabilityUi.traceDrawer.json
  • web/packages/agenta-i18n/locales/fr-FR/playground.commit.json
  • web/packages/agenta-i18n/locales/fr-FR/playground.panels.json
  • web/packages/agenta-i18n/locales/fr-FR/playground.refine.json
  • web/packages/agenta-i18n/locales/fr-FR/settings.providers.json
  • web/packages/agenta-i18n/locales/fr-FR/settings.secrets.json
  • web/packages/agenta-i18n/locales/fr-FR/settings.shared.json
  • web/packages/agenta-i18n/locales/ja-JP/auth.notFound.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.commitModal.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.playgroundConfig.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.schemaControls.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.testcase.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.toolConnections.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.variant.json
  • web/packages/agenta-i18n/locales/ja-JP/observability.annotate.json
  • web/packages/agenta-i18n/locales/ja-JP/observabilityUi.deleteTrace.json
  • web/packages/agenta-i18n/locales/ja-JP/observabilityUi.traceDrawer.json
  • web/packages/agenta-i18n/locales/ja-JP/playground.commit.json
  • web/packages/agenta-i18n/locales/ja-JP/playground.panels.json
  • web/packages/agenta-i18n/locales/ja-JP/playground.refine.json
  • web/packages/agenta-i18n/locales/ja-JP/settings.providers.json
  • web/packages/agenta-i18n/locales/ja-JP/settings.secrets.json
  • web/packages/agenta-i18n/locales/ja-JP/settings.shared.json
  • web/packages/agenta-i18n/locales/pt-BR/auth.notFound.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.commitModal.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.playgroundConfig.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.schemaControls.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.testcase.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.toolConnections.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.variant.json
  • web/packages/agenta-i18n/locales/pt-BR/observability.annotate.json
  • web/packages/agenta-i18n/locales/pt-BR/observabilityUi.deleteTrace.json
  • web/packages/agenta-i18n/locales/pt-BR/observabilityUi.traceDrawer.json
  • web/packages/agenta-i18n/locales/pt-BR/playground.commit.json
  • web/packages/agenta-i18n/locales/pt-BR/playground.panels.json
  • web/packages/agenta-i18n/locales/pt-BR/playground.refine.json
  • web/packages/agenta-i18n/locales/pt-BR/settings.providers.json
  • web/packages/agenta-i18n/locales/pt-BR/settings.secrets.json
  • web/packages/agenta-i18n/locales/pt-BR/settings.shared.json
  • web/packages/agenta-i18n/locales/zh-CN/auth.notFound.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.commitModal.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.playgroundConfig.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.schemaControls.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.testcase.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.toolConnections.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.variant.json
  • web/packages/agenta-i18n/locales/zh-CN/observability.annotate.json
  • web/packages/agenta-i18n/locales/zh-CN/observabilityUi.deleteTrace.json
  • web/packages/agenta-i18n/locales/zh-CN/observabilityUi.traceDrawer.json
  • web/packages/agenta-i18n/locales/zh-CN/playground.commit.json
  • web/packages/agenta-i18n/locales/zh-CN/playground.panels.json
  • web/packages/agenta-i18n/locales/zh-CN/playground.refine.json
  • web/packages/agenta-i18n/locales/zh-CN/settings.providers.json
  • web/packages/agenta-i18n/locales/zh-CN/settings.secrets.json
  • web/packages/agenta-i18n/locales/zh-CN/settings.shared.json
  • web/packages/agenta-navigation-ui/src/NavMenu.tsx
  • web/packages/agenta-navigation-ui/src/ProjectOrgSwitcher.tsx
  • web/packages/agenta-navigation-ui/src/SidebarShell.tsx
  • web/packages/agenta-navigation/src/supportLinks.ts
  • web/packages/agenta-observability-ui/src/actions/types.ts
  • web/packages/agenta-observability-ui/src/cells/SpanNameCell.tsx
  • web/packages/agenta-observability-ui/src/columns/getObservabilityColumns.tsx
  • web/packages/agenta-observability-ui/src/delete/index.tsx
  • web/packages/agenta-observability-ui/src/filters/FilterDialog.tsx
  • web/packages/agenta-observability-ui/src/range/RangePicker.tsx
  • web/packages/agenta-observability-ui/src/session/EndTimeCell.tsx
  • web/packages/agenta-observability-ui/src/session/StartTimeCell.tsx
  • web/packages/agenta-observability-ui/src/toolbar/ToolbarSearch.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/AccordionTreePanel.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/EvaluatorDetailsPopover.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/LinkedSpansTabItem.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/OverviewTabItem.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/TraceContent.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/TraceDrawer.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/TraceHeader.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/TraceReferences.tsx
  • web/packages/agenta-observability-ui/src/traceDrawer/TraceTypeHeader.tsx
  • web/packages/agenta-observability-ui/tests/unit/addToQueueSlot.render.test.tsx
  • web/packages/agenta-observability-ui/tests/unit/filterDialog.render.test.tsx
  • web/packages/agenta-observability/src/analytics/format.ts
  • web/packages/agenta-observability/src/state/queries.ts
  • web/packages/agenta-observability/src/state/selectors.ts
  • web/packages/agenta-observability/src/traceDrawer/messagePanels.ts
  • web/packages/agenta-observability/tests/unit/analytics.test.ts
  • web/packages/agenta-observability/tests/unit/messagesToText.test.ts
  • web/packages/agenta-observability/tests/unit/spanDisplayOutputs.test.ts
  • web/packages/agenta-playground-ui/src/components/CommitVariantChanges/CommitVariantChangesModal.tsx
  • web/packages/agenta-playground-ui/src/hooks/useLocalDraftWarning.ts
  • web/packages/agenta-playground-ui/src/panels/chat/ChatMessage.tsx
  • web/packages/agenta-playground-ui/src/panels/compare/VariantCard.tsx
  • web/packages/agenta-playground-ui/src/panels/compare/useRevisionRunAverages.ts
  • web/packages/agenta-playground-ui/src/panels/config/ConfigPanelHeader.tsx
  • web/packages/agenta-playground-ui/src/panels/config/RevisionTree.tsx
  • web/packages/agenta-playground-ui/src/panels/drawer/DrawerTitle.tsx
  • web/packages/agenta-playground-ui/src/panels/drawer/EditableRevisionDrawer.tsx
  • web/packages/agenta-playground-ui/src/panels/refine/useRefinePrompt.ts
  • web/packages/agenta-playground-ui/src/panels/runs/RevisionResultCard.tsx
  • web/packages/agenta-settings-ui/src/ApiKeysPage.tsx
  • web/packages/agenta-settings-ui/src/SettingsPageShell.tsx
  • web/packages/agenta-settings-ui/src/members/MembersPage.tsx
  • web/packages/agenta-settings-ui/src/projects/ProjectsPage.tsx
  • web/packages/agenta-settings-ui/src/providers/AIProvidersPage.tsx
  • web/packages/agenta-settings-ui/src/secrets/NamedSecretTable.tsx
  • web/packages/agenta-settings-ui/src/tools/GatewayToolsSection.tsx
  • web/packages/agenta-settings-ui/tests/unit/aiProvidersLoadFailed.test.tsx
  • web/packages/agenta-settings-ui/tests/unit/projectsPage.test.tsx
  • web/packages/agenta-settings/src/navigation.ts
  • web/packages/agenta-shared/src/utils/dateTime/index.ts
  • web/packages/agenta-shared/src/utils/formatters/formatters.ts
  • web/packages/agenta-shared/src/utils/shortcuts.ts
  • web/packages/agenta-shared/tests/unit/dateTime.test.ts
  • web/packages/agenta-shared/tests/unit/formatters.test.ts
  • web/packages/agenta-ui/src/CellRenderers/CellContentPopover.tsx
  • web/packages/agenta-ui/src/InfiniteVirtualTable/components/VirtualTable.tsx
  • web/packages/agenta-ui/src/components/presentational/charts/ChartParts.tsx
  • web/packages/agenta-ui/src/components/ui/tabs.tsx
  • web/packages/agenta-ui/src/list-table/ListTable.tsx
  • web/packages/agenta-ui/src/list-table/ListTableToolbar.tsx
  • web/packages/agenta-ui/src/styles/editor-theme.css
  • web/packages/agenta-ui/src/theme/useThemeMode.ts
  • web/packages/agenta-ui/tests/unit/VirtualTable.render.test.tsx
  • web/packages/agenta-ui/tests/unit/chartsBar.render.test.tsx
  • web/packages/agenta-ui/tests/unit/listTableSrOnlyContained.render.test.tsx
  • web/packages/agenta-ui/tests/unit/useThemeModeBootClass.render.test.tsx

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Website preview

Preview URL: https://pr-8342-agenta-website-preview.mahmoud-637.workers.dev

Built from 3341143a1aa00cc63d16f2293401f10d5e46bd41. This comment updates in place on every push.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Devin Review

Comment on lines +20 to +21
message={`${testset.name} has no ${missing.length === 1 ? "column" : "columns"} for ${list}`}
description="Every row will fail with missing inputs. Pick another test set, or add the column to this one."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 New evaluation warning remains English

With a non-English locale, TestsetColumnsWarning still displays English text. Its warning bypasses @agenta/i18n and assembles a sentence from fragments, contrary to the mobile translation rules.

Learn more

The mobile translation rules require user-visible text to come from @agenta/i18n. They also require complete sentences with placeholders instead of sentences assembled from fragments. Neither warning string uses a catalog.

Example: A user selects a non-English language and picks a test set without a required question column. The new warning heading and explanation remain English.

Recommended fix: Add full-sentence catalog entries for the singular warning, plural warning, and explanation. Render them with useT, using placeholders for the test set name and missing-column list. Add translations for the supported languages.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changing this here. The whole new evaluation sheet (web/mobile/src/features/evaluations/new/) has not been moved to @agenta/i18n yet on this release branch; none of its files use useT. Translating one warning would leave it the only translated string on an English-only screen. It belongs with the migration of that screen.

- The evaluation revision picker offers a configured v0; useAppRevisions already drops empty seeds.
- Filter Clear leaves an empty draft, so Apply can remove every filter.
- Keep FilterDialog's onClearFilter as an optional unused prop; web/oss still passes it.
- Update tests for the new copy, the SharedEditor-based JSON view and the ResizeObserver in the trace drawer.
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Item Value
Status stopped
Commit 3341143a1aa00cc63d16f2293401f10d5e46bd41
Manual expiry (UTC) Not granted
CI deadline (UTC) Not granted
Workflow https://github.com/Agenta-AI/agenta/actions/runs/44143506916

Dependent tests finished. Post /preview for manual review. Environment absence verified; retained storage requires separate provider accounting.

Post /preview as a new comment to request a one-hour preview. Repeating it while active does not extend the hour.
Preview data is disposable. Expiry is enforced by the next successful cleanup sweep, not an exact timer.
Environment deletion stops its compute. Provider-retained storage and permanent services may still be billed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant