Skip to content

[fix] Translate the remaining /m English in providers, lists and tool rows - #8363

Open
mmabrouk wants to merge 1 commit into
mainfrom
fix/i18n-leftovers-0129
Open

mmabrouk wants to merge 1 commit into
mainfrom
fix/i18n-leftovers-0129

Conversation

@mmabrouk

@mmabrouk mmabrouk commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Context

After v0.129.0, a French, German or Japanese user still saw English in a few places:

  • Settings > AI providers. The Test button tooltip ("Test checks the key with OpenAI..."), the "Add a model ID the API doesn't list" field, "41 models fetched", "3 of 41", "Fetched 2 min ago", "Key configured", "Defaults" and "3 of 38 active" in the rows, "This provider offers no free credential check...", and the subscription status lines ("Not signed in", "Sign in needed. The ChatGPT sign-in is no longer valid.").
  • Provider errors. "This connection no longer exists. Reload and try again.", "Agenta could not reach OpenAI to test this credential.", the sign-in attempt errors, and "The sign-in started without a code. Try again."
  • Lists in Japanese and Chinese. Harness names, project names and schedule days were joined with ", " instead of "、" ("Pi, Claude Code と Codex で有効").
  • Chat tool rows. Our own nouns stayed English in every language ("Sucht nach triggers", "schedule erstellt", "channel messages gelesen"). German query rows read "nach X gefunden" ("found after X"), which is wrong for every verb except "search".
  • Custom skins. A skin that overrides only the row text lost its text: the built-in frame filled in the file name instead. A skin verb in Japanese was moved after the object, so the row did not match the skin's English sentence.
  • French provider dialog. The help text under "Modèles actifs" read "les modèles Point de terminaison compatible OpenAI proposés par cette connexion".
  • Schedule builder. The "3h" chips and the cron placeholder "minute hour day month weekday (UTC)".

The cause is the same in most places: @agenta/entities built these sentences in English, and the UI showed them as they were.

Changes

The pattern from #8354 is kept: @agenta/entities keeps the rules and returns data or a code, and @agenta/entity-ui gives the words from the catalog.

  • New providerCardText.ts and subscriptionText.ts in @agenta/entity-ui/secretProvider hold the card text. The English copy helpers in entities/secret/core/cardCopy.ts and connectedRowSubtitle are removed. Their English tests moved to entity-ui/tests/unit/providerCardText.test.ts, byte for byte.
  • Signatures in @agenta/entities/secret that changed:
    • credentialSummary(connection, keyConfigured)
    • activeModelsSummary(connection, capabilities, {defaults, active})
    • probeFailureMessage(error, {gone, unreachable}). A 4xx still shows the server's own message, as before.
    • doneState(...).note is now "savedUntested" | "testFirst" | null instead of an English sentence.
    • subscriptionStatusLine, subscriptionAttemptErrorSentence and SUBSCRIPTION_SIGN_IN_HINT are replaced by subscriptionStatus() and subscriptionAttemptFailure(), which return a code.
  • Relative fetch time uses Intl.RelativeTimeFormat in the active language ("il y a 2 min", "2 分前"). English keeps "2 min ago".
  • New formatList() in @agenta/i18n (Intl.ListFormat, no new dependency). English output does not change ("a, b, c"; long form "a, b and c"). ScheduleText gets enumerate() for the capped day lists and cron day sets.
  • Chat rows: 11 platform nouns join the glossary (trace, schedule(s), tool(s), triggers, connections, deliveries, channel destinations/messages). A search verb uses the new forSearchQuery key. German now reads "nach X gesucht" and "für X gefunden".
  • Skin overrides: a registered sentence without a verb drops the built-in verb and frame. A registered verb gets a verb-first frame in every language.
  • Catalogs: 37 new keys (plural families count once), each in all 7 languages, written by hand (Chinese terms follow the glossary). enabledInHarnesses is removed; the harness list is now one formatList value. Changed values: de forQuery ("für {{query}}"), fr enterCredential, zh fetched ("{{time}}获取"). .meta hashes are recorded for every new key.
  • Display only: the saved default names ("OpenAI-compatible endpoint", "OpenAI (Organization)") stay English, because they are written to the API.

Tests

  • pnpm lint-fix in web: pass, with no new warnings. prettier --check on the changed files: pass.
  • tsc --noEmit: pass for @agenta/i18n, entities, entity-ui, settings-ui, chat, automation-ui and web/mobile.
  • node scripts/check.ts (i18n): pass.
  • Unit tests (vitest run): @agenta/i18n 66/66, entities 3034/3034, entity-ui 1771/1771, settings-ui 330/330, chat 1481/1481. automation-ui has no unit tests.
  • New tests pin the English text byte for byte. They also check Japanese and French text, plural forms, Intl relative time, and the "、" separator (providerCardText.test.ts, scheduleText.test.ts, translate.test.ts). German nouns and query rows and the skin override frames are checked in toolActivityLanguage.test.ts.
  • Demo is outstanding. I did not run the app for this PR, so there are no screenshots yet.

What to QA

  • Set the language to Français. Open Settings > AI providers > OpenAI, type a key and hover Test. The tooltip is French. Click Test. The line ends with "N modèles récupérés", the header shows "3 sur 41", and the footer shows "Récupéré il y a ... ·".
  • In French, open the OpenAI-compatible endpoint card with no credential. The help text ends with "...proposés par cette connexion (Point de terminaison compatible OpenAI)."
  • In 日本語, enable two harnesses on a connection. The summary reads "Pi、Claude Code で有効". A weekly schedule with five days shows "月、火、水 +2".
  • In Deutsch, run an agent that calls discover_triggers and list_schedules. The rows read "Sucht nach Auslösern" and "Zeitpläne geprüft".
  • Regression: in English, every text above reads exactly as before.

Follow-ups (not in this PR)

  • The API returns the probe verdicts in English ("OpenAI accepted this key.", "... rejected this key (401)."). It should return a code that the UI can translate.
  • Cron validation errors in entities/gatewayTrigger/core/cron.ts ("Invalid minute: bad range ...") are English.
  • Other ", " joins outside these screens: settings-ui/shared/accountOwners.ts ("Used by"), the observability analytics filter chips, QueueEvaluatorField, AgentConfigCard skill names, and commitDiff/summaryMessage.ts.
  • The approval card sentences in agenta-chat/src/model/approvalDescribers are still English.
  • Three existing providerConnection keys (anyHarness, noHarnessSelected, enabledInHarness) have no .meta hash in the six languages. translate.ts will adopt them on its next run.

Devin Review

… leftovers

Provider card text, subscription status lines, probe errors, list separators,
German tool rows and skin override frames now follow the active language.
@agenta/entities returns codes or takes the words; @agenta/entity-ui gives them
from the catalog. English text is unchanged.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Summary

Summary by CodeRabbit

  • New Features

    • Provider settings now show localized credential guidance, connection status, model counts, and subscription sign-in outcomes.
    • Schedule controls include localized interval and cron-field guidance, with list formatting adapted to each language.
    • Chat activity labels now cover tools, traces, schedules, triggers, connections, deliveries, and channel messages.
  • Improvements

    • Search activity wording and registered tool displays now use more context-appropriate phrasing.
    • Provider and schedule lists display with locale-appropriate separators across supported languages.

The PR updates chat activity wording, schedule formatting, provider connection text, and subscription sign-in text. It adds locale-aware list formatting and translations across English, German, Spanish, French, Japanese, Brazilian Portuguese, and Chinese.

Changes: Chat activity wording

Layer / File(s) Summary
Registered tool wording and localized terms
web/packages/agenta-chat/src/skin/registry.ts, web/packages/agenta-chat/tests/unit/skin/*, web/packages/agenta-i18n/locales/*/chat.toolActivity.json, web/packages/agenta-i18n/locales/.meta/*
Registered tool frames and query wording now use updated localized terms. The platform glossary and chat activity tests include terms and phrasing for tools, triggers, traces, connections, schedules, deliveries, and channel content.

Schedule descriptions

Layer / File(s) Summary
Locale-aware schedule formatting
web/packages/agenta-entities/src/gatewayTrigger/core/*, web/packages/agenta-entity-ui/src/gatewayTrigger/*, web/packages/agenta-entity-ui/tests/unit/scheduleText.test.ts, web/packages/agenta-i18n/locales/*/entityUi.scheduleBuilder.json, web/packages/agenta-i18n/locales/.meta/*
Schedule weekday and capped-item lists use locale-aware enumeration. Schedule controls use translated hour-chip and cron-placeholder text. Japanese tests cover localized separators.

Provider and subscription text

Layer / File(s) Summary
Provider connection display contracts
web/packages/agenta-entities/src/secret/core/*, web/packages/agenta-entities/src/secret/index.ts, web/packages/agenta-entities/tests/unit/*
Provider connection helpers now accept localized text or return status tokens instead of embedding display sentences. Removed card-copy and subtitle helpers are replaced by UI-localized helpers. Tests now pass display text and assert status tokens.
Localized provider text and UI wiring
web/packages/agenta-entity-ui/src/secretProvider/*, web/packages/agenta-settings-ui/src/providers/*, web/packages/agenta-i18n/src/index.ts, web/packages/agenta-i18n/tests/unit/translate.test.ts, web/packages/agenta-entity-ui/tests/unit/providerCardText.test.ts, web/packages/agenta-i18n/locales/*/entityUi.providerConnection.json, web/packages/agenta-i18n/locales/*/settings.providers.json, web/packages/agenta-i18n/locales/.meta/*
Provider card text is localized in entity UI. Provider summaries and settings rows use localized copy, and formatList formats harness and project names. Tests cover provider text in English, Japanese, and French.
Subscription status classification
web/packages/agenta-entities/src/secret/core/subscriptionConnections.ts, web/packages/agenta-entities/tests/unit/subscription-connections.test.ts
Subscription status and attempt outcomes are represented by semantic values. Tests cover mapped and fallback classifications.
Localized subscription sign-in text
web/packages/agenta-entity-ui/src/secretProvider/subscriptionText.ts, web/packages/agenta-entity-ui/src/secretProvider/useSubscriptionSignIn.ts, web/packages/agenta-entity-ui/src/DrillInView/SchemaControls/connectionPicker.ts, web/packages/agenta-settings-ui/src/providers/*, web/packages/agenta-entity-ui/tests/unit/providerCardText.test.ts, web/packages/agenta-i18n/locales/*/entityUi.subscriptionSignIn.json, web/packages/agenta-i18n/locales/.meta/*
Entity UI maps subscription classifications to translated messages. The sign-in flow uses a translated missing-code error and refreshes status text when the text version changes.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • Agenta-AI/agenta#8347: It updates the same chat activity catalogs, tool-row wording, registry, and related tests.
Merge Risk: Low · up to 44f32

This PR mostly localizes provider, schedule and tool text. A few minor display issues remain: some German wording is wrong, narrow screens can clip hour chips, and some text keeps the previous language after a switch. None of these should block merge, but fix them soon.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: translating the remaining English text in provider settings, lists, and chat tool rows. The changeset covers each of these areas: provider-card and subscription copy m…
Description check Passed The description explains the problem, the changes by file area, the tests run, QA steps, and follow-ups. It matches the changeset, including provider text, subscription helpers, formatList, schedule t…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: translating the remaining English text in provider settings, lists, and chat tool rows. The changeset covers each of these areas: provider-card and subscription copy moved to entity-ui with localized text, formatList and Intl-based list joins, and chat tool-row glossary and verb frames. The title is specific and concise, and it fits the PR objectives.

Full details: Description check

Explanation

The description explains the problem, the changes by file area, the tests run, QA steps, and follow-ups. It matches the changeset, including provider text, subscription helpers, formatList, schedule text, chat tool rows, skin overrides, and the locale catalogs.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

Website preview

Preview URL: https://pr-8363-agenta-website-preview.mahmoud-637.workers.dev

Built from 44f327dfdefbfd5f0523304f1048f67324c578a3. This comment updates in place on every push.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 3 flags

Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

Devin Review

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5d783fe and 44f327d.

Files selected for processing: 74

  • web/packages/agenta-chat/src/skin/registry.ts
  • web/packages/agenta-chat/tests/unit/skin/toolActivityLanguage.test.ts
  • web/packages/agenta-entities/src/gatewayTrigger/core/cron.ts
  • web/packages/agenta-entities/src/gatewayTrigger/core/scheduleBuilder.ts
  • web/packages/agenta-entities/src/gatewayTrigger/core/scheduleText.ts
  • web/packages/agenta-entities/src/secret/core/cardCopy.ts
  • web/packages/agenta-entities/src/secret/core/connectionSummary.ts
  • web/packages/agenta-entities/src/secret/core/connections.ts
  • web/packages/agenta-entities/src/secret/core/index.ts
  • web/packages/agenta-entities/src/secret/core/subscriptionConnections.ts
  • web/packages/agenta-entities/src/secret/index.ts
  • web/packages/agenta-entities/tests/unit/connection-model-count.test.ts
  • web/packages/agenta-entities/tests/unit/provider-card-copy.test.ts
  • web/packages/agenta-entities/tests/unit/provider-connections.test.ts
  • web/packages/agenta-entities/tests/unit/subscription-connections.test.ts
  • web/packages/agenta-entity-ui/src/DrillInView/SchemaControls/connectionPicker.ts
  • web/packages/agenta-entity-ui/src/gatewayTrigger/drawers/ScheduleBuilderField.tsx
  • web/packages/agenta-entity-ui/src/gatewayTrigger/scheduleText.ts
  • web/packages/agenta-entity-ui/src/secretProvider/ActiveModelsSection.tsx
  • web/packages/agenta-entity-ui/src/secretProvider/HarnessesSection.tsx
  • web/packages/agenta-entity-ui/src/secretProvider/PlaygroundProviderSections.tsx
  • web/packages/agenta-entity-ui/src/secretProvider/ProviderConnectionCard.tsx
  • web/packages/agenta-entity-ui/src/secretProvider/index.ts
  • web/packages/agenta-entity-ui/src/secretProvider/providerCardText.ts
  • web/packages/agenta-entity-ui/src/secretProvider/subscriptionText.ts
  • web/packages/agenta-entity-ui/src/secretProvider/useSubscriptionSignIn.ts
  • web/packages/agenta-entity-ui/tests/unit/providerCardText.test.ts
  • web/packages/agenta-entity-ui/tests/unit/scheduleText.test.ts
  • web/packages/agenta-i18n/locales/.meta/de-DE.json
  • web/packages/agenta-i18n/locales/.meta/es-ES.json
  • web/packages/agenta-i18n/locales/.meta/fr-FR.json
  • web/packages/agenta-i18n/locales/.meta/ja-JP.json
  • web/packages/agenta-i18n/locales/.meta/pt-BR.json
  • web/packages/agenta-i18n/locales/.meta/zh-CN.json
  • web/packages/agenta-i18n/locales/de-DE/chat.toolActivity.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.providerConnection.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.scheduleBuilder.json
  • web/packages/agenta-i18n/locales/de-DE/entityUi.subscriptionSignIn.json
  • web/packages/agenta-i18n/locales/de-DE/settings.providers.json
  • web/packages/agenta-i18n/locales/en/chat.toolActivity.json
  • web/packages/agenta-i18n/locales/en/entityUi.providerConnection.json
  • web/packages/agenta-i18n/locales/en/entityUi.scheduleBuilder.json
  • web/packages/agenta-i18n/locales/en/entityUi.subscriptionSignIn.json
  • web/packages/agenta-i18n/locales/en/settings.providers.json
  • web/packages/agenta-i18n/locales/es-ES/chat.toolActivity.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.providerConnection.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.scheduleBuilder.json
  • web/packages/agenta-i18n/locales/es-ES/entityUi.subscriptionSignIn.json
  • web/packages/agenta-i18n/locales/es-ES/settings.providers.json
  • web/packages/agenta-i18n/locales/fr-FR/chat.toolActivity.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.providerConnection.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.scheduleBuilder.json
  • web/packages/agenta-i18n/locales/fr-FR/entityUi.subscriptionSignIn.json
  • web/packages/agenta-i18n/locales/fr-FR/settings.providers.json
  • web/packages/agenta-i18n/locales/ja-JP/chat.toolActivity.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.providerConnection.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.scheduleBuilder.json
  • web/packages/agenta-i18n/locales/ja-JP/entityUi.subscriptionSignIn.json
  • web/packages/agenta-i18n/locales/ja-JP/settings.providers.json
  • web/packages/agenta-i18n/locales/pt-BR/chat.toolActivity.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.providerConnection.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.scheduleBuilder.json
  • web/packages/agenta-i18n/locales/pt-BR/entityUi.subscriptionSignIn.json
  • web/packages/agenta-i18n/locales/pt-BR/settings.providers.json
  • web/packages/agenta-i18n/locales/zh-CN/chat.toolActivity.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.providerConnection.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.scheduleBuilder.json
  • web/packages/agenta-i18n/locales/zh-CN/entityUi.subscriptionSignIn.json
  • web/packages/agenta-i18n/locales/zh-CN/settings.providers.json
  • web/packages/agenta-i18n/src/index.ts
  • web/packages/agenta-i18n/tests/unit/translate.test.ts
  • web/packages/agenta-settings-ui/src/providers/AIProvidersPage.tsx
  • web/packages/agenta-settings-ui/src/providers/ProvidersPanel.tsx
  • web/packages/agenta-settings-ui/src/providers/useOrganizationProvidersGroup.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

kind: "subscription",
disabled: true,
hint: SUBSCRIPTION_SIGN_IN_HINT,
hint: subscriptionSignInHint(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Rebuild the picker rows when the display language changes.

The rows memo in ModelPickerControl.tsx does not depend on the active language. The disabled subscription row stores its hint as a translated string at build time. After a language change, the row can keep the previous-language hint until one of the memo inputs changes. The same memo also produces other translated row text, so the fix should cover the row build as a whole, not only this hint.

Add the active locale, or a text-version value derived from it, to the rows dependency list. Alternatively, resolve the hint at render time instead of storing it in the row.

onClick={() => emit({...builder, everyNHours: n})}
>
{n}h
{t("entityUi.scheduleBuilder.hoursChip", {hours: n})}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Let the hourly interval chips wrap when the popover is narrow.

The hourly "every" row sets its chips to shrink-0 and whitespace-nowrap, and its container does not wrap. At narrow widths, the seven chips can need more width than the popover provides. The German {{hours}} Std. labels make this more likely. Chips past the popover edge can be unreachable. Allowing the row to wrap keeps every interval reachable.

Suggested fix

 function ChipRow({label, children}: {label: string; children: ReactNode}) {
     return (
         <div className="flex flex-col gap-1.5">
             <FieldLabel>{label}</FieldLabel>
-            <div className="flex gap-1">{children}</div>
+            <div className="flex flex-wrap gap-1">{children}</div>
         </div>
     )
 }

} catch (error) {
setProbe(null)
setProbeFailure(probeFailureMessage(error, title))
setProbeFailure(probeFailureText(error, displayTitle))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Translate retained probe failures during render.

If a network probe fails in Japanese, this stores the Japanese fallback in probeFailure. Switching to French leaves that sentence unchanged because the language update does not reset this state. statusLine continues to use the stored sentence.

Retain a failure descriptor and translate it during render. Preserve provider-supplied messages and the existing retry/reset behavior.

"findDone": "gefunden",
"findRunning": "Sucht",
"forQuery": "nach {{query}}",
"forQuery": "für {{query}}",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Use the "nach" search frame for query-led German find rows.

When find_traces has a query and no app name, the row uses forQuery. The German value is now "für {{query}}", so the running label reads "Sucht für timeout". German search text uses "nach" before the searched object, and the previous value gave "Sucht nach timeout". Route query-led find rows through the German search frame, or otherwise keep "nach" before the query, so the label reads "Sucht nach timeout".

"termSchedule": "Zeitplan",
"termSchedules": "Zeitpläne",
"termTool": "Werkzeug",
"termTools": "Werkzeugen",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Use a case-correct object for search tools.

The glossary key termTools is fixed as “Werkzeugen”, the dative plural. search_tools with no query reaches the direct-object frame {{verb}} {{object}}. It renders “Sucht Werkzeugen” and “Werkzeugen gesucht”, but the direct-object form is “Werkzeuge”.

The same key also feeds the discover frame, which needs the dative after “nach”. Changing termTools to “Werkzeuge” alone would fix search tools and break discover tools (“Sucht nach Werkzeuge”). Provide an accusative form for the direct-object frames, and keep the dative form for the “nach” frames.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Item Value
Status stopped
Commit 44f327dfdefbfd5f0523304f1048f67324c578a3
Manual expiry (UTC) Not granted
CI deadline (UTC) Not granted
Workflow https://github.com/Agenta-AI/agenta/actions/runs/44376179294

Dependent tests finished. Post /preview for manual review. Environment absence verified; retained storage requires separate provider accounting.

Post /preview as a new comment to request a one-hour preview. Repeating it while active does not extend the hour.
Preview data is disposable. Expiry is enforced by the next successful cleanup sweep, not an exact timer.
Environment deletion stops its compute. Provider-retained storage and permanent services may still be billed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant