Skip to content

Incorrect example for onStubActivation on Usage Examples page #333

Open

Description

@kirilstrax

New Issue Checklist

Environment

  • version of OHHTTPStubs: 8.0.0
  • integration method you are using:
    • Cocoapods
    • Carthage
    • submodule
    • other
  • version of the tool you use: not applicable

Issue Description

The example on Usage Examples page is shown as follows:

// Swift
OHHTTPStubs.onStubActivation() { request, stub in
  println("\(request.URL!) stubbed by \(stub.name).")
}

Problem 1: Signature of onStubActivation was changed a few versions ago. So it should be:

OHHTTPStubs.onStubActivation() { request, stub, response in

This problem applies to both, Swift and Objective C examples

Problem 2: replace println with print in Swift, as there's no println function in swift.

Problem 3: in Swift, NSURLRequest is bridged as URLRequest, and instead of request.URL!, it uses lower-cased request.url!

Bottom line: example in Swift should look something like this:

// Swift
OHHTTPStubs.onStubActivation() { request, stub, response in
  print("\(request.url!) stubbed by \(stub.name) of size \(response.dataSize).")
}
Complete output when you encounter the issue (if any)

This is documentation update issue, so not applicable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions