Skip to content

Export the selected release toolchain as environment - #539

Merged
Eli Pinkerton (wallstop) merged 1 commit into
mainfrom
fix/release-toolchain-env
Nov 4, 2026
Merged

Eli Pinkerton (wallstop) merged 1 commit into
mainfrom
fix/release-toolchain-env

Conversation

@wallstop

Copy link
Copy Markdown
Collaborator

DISCLOSURE: LLM-GENERATED TEXT

Why: Run 41896328507 selected /opt/hostedtoolcache/node/24.22.2/x64/bin and wrote it to GITHUB_PATH, yet the next step still resolved /usr/local/bin/npm (npm 10.9.9) and stopped publication. PATH order is not a contract on this runner.

What:

  • Export the selected pair as RELEASE_NODE/RELEASE_NPM and use those executables for verification, packing, and publication
  • Keep GITHUB_PATH as a secondary hint only
  • Create the release tag before the toolchain work so a later failure resumes from an existing tag

Refs #536

Selecting the tool-cache directory and writing it to GITHUB_PATH still left
the next step resolving /usr/local/bin/npm, so publication kept reading the
image's npm 10.9.9. Export RELEASE_NODE/RELEASE_NPM instead and use those
executables for packing and publishing, and tag before the toolchain work so
a later failure resumes from an existing tag.

Refs #536.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@wallstop
Eli Pinkerton (wallstop) merged commit 518149d into main Nov 4, 2026
2 of 3 checks passed
@wallstop
Eli Pinkerton (wallstop) deleted the fix/release-toolchain-env branch November 4, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant