Skip to content

Modis 6 - #53

Closed
bhbraswell wants to merge 6 commits into
masterfrom
modis-6
Closed

bhbraswell wants to merge 6 commits into
masterfrom
modis-6

Conversation

@bhbraswell

Copy link
Copy Markdown

The default base for PR is gipit:gips. But I selected AppliedGeosolutions:gips.

Comment thread gips/data/core.py
# if we don't have it already
if not cls.Asset.discover(t, d, a):
# if we don't have it already, or if update (force) flag
if not cls.Asset.discover(t, d, a) or update == True:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The or checks for truth so you don't need to do it explicitly:

if not cls.Asset.discover(t, d, a) or update:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that makes sense.

On Jul 5, 2016, at 9:29 AM, ags-tolson notifications@github.com wrote:

In gips/data/core.py #53 (comment):

     assets = cls.products2assets(products)
     fetched = []
     for a in assets:
         for t in tiles:
             asset_dates = cls.Asset.dates(a, t, textent.datebounds, textent.daybounds)
             for d in asset_dates:
  •                # if we don't have it already
    
  •                if not cls.Asset.discover(t, d, a):
    
  •                # if we don't have it already, or if update (force) flag
    
  •                if not cls.Asset.discover(t, d, a) or update == True:
    
    The or checks for truth so you don't need to do it explicitly:

if not cls.Asset.discover(t, d, a) or update:
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Applied-GeoSolutions/gips/pull/53/files/3a9deaff37b928cc1fba52d1cdb2083f4a8127db#r69562343, or mute the thread https://github.com/notifications/unsubscribe/ADD4XNAayR-HTPltae9mEnFn9KB1XeX8ks5qSlw3gaJpZM4JDj03.

@ra-tolson

Copy link
Copy Markdown
Collaborator

So I gave this a once-over; I couldn't find any serious problems but then again I don't know the codebase that well, and likewise please take all my suggestions as mere suggestions. If someone more knowledgeable can approves this PR, I'll merge.

@ra-tolson

Copy link
Copy Markdown
Collaborator

So this branch is getting pretty stale:

  • merge conflicts
  • a month behind
  • merge target is wrong (we aim PRs at 'dev' now).

I'm going to make a new branch off 'dev', copy these commits onto it, then push it and issue a new PR pointed at 'dev'. This is technically altering or rebasing pushed commits, but this is one of the safe use cases. Closing this PR for now since merging this and a new branch would be a mess. : ] If you guys don't like this idea please reopen the PR and tell me to stop; nothing I'm doing is destructive so it'll be fine either way.

@ra-tolson ra-tolson closed this Aug 1, 2016
@bhbraswell

Copy link
Copy Markdown
Author

Your plan sounds good to me. If you want to look at any of the changes together I can come over to the mill. If there are cookies left I will definitely do it.

On Aug 1, 2016, at 4:56 PM, ags-tolson notifications@github.com wrote:

So this branch is getting pretty stale:

merge conflicts
a month behind
merge target is wrong (we aim PRs at 'dev' now).
I'm going to make a new branch off 'dev', copy these commits onto it, then push it and issue a new PR pointed at 'dev'. This is technically altering or rebasing pushed commits, but this is one of the safe use cases. Closing this PR for now since merging this and a new branch would be a mess. : ] If you guys don't like this idea please reopen the PR and tell me to stop; nothing I'm doing is destructive so it'll be fine either way.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants