Skip to content

scripts: run_parsers: include stream groups from 4.7 onwards - #22

Draft
zaccesss wants to merge 1 commit into
ArduPilot:mainfrom
zaccesss:mavlink-stream-groups-all-versions
Draft

zaccesss wants to merge 1 commit into
ArduPilot:mainfrom
zaccesss:mavlink-stream-groups-all-versions

Conversation

@zaccesss

Copy link
Copy Markdown

Draft, for discussion. @ES-Alexander, this is the matching change for ArduPilot/ardupilot#35149 and only makes sense together with it.

run_parsers.py passes -g to mavlink_parse.py only for 4.1 to 4.6, because stream groups were thought to be removed in 4.7. They were not removed. They moved to one shared file in ArduPilot/ardupilot#29617. With ArduPilot/ardupilot#35149 the parser reads that file, so this removes the upper limit and the Stream Groups section is generated for 4.7 and later too.

The lower limit stays, because 4.0 has no stream group arrays.

If this is merged before the parser change, nothing breaks. The parser on master finishes cleanly with -g and writes the intro sentence with no section. The parser change should still land first.

If you would prefer to leave Stream Groups out, please close this one together with ArduPilot/ardupilot#35149.

Details: testing

Testing

  • run_parsers.py was run end to end twice on a case-sensitive disk, once unchanged and once with this change and the parser from Tools: scripts: mavlink_parse: find stream groups in every version ardupilot#35149.
  • 36 of the 37 stored MAVLinkMessages.rst files were rewritten by both runs. Blimp-4.7 has no tag, so neither run touches it.
  • 4.0 (Copter, Plane, Rover, Sub) gains no Stream Groups section, as intended.
  • 4.1 to 4.6 (21 files) gain the section. The unchanged run does not produce it on a case-sensitive disk.
  • 4.7 and 4.8 (11 files) gain the section and its intro sentence.
  • There are no other differences between the two runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant