Repository navigation
Conversation
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, for discussion. @ES-Alexander, this is the matching change for ArduPilot/ardupilot#35149 and only makes sense together with it.
run_parsers.pypasses-gtomavlink_parse.pyonly for 4.1 to 4.6, because stream groups were thought to be removed in 4.7. They were not removed. They moved to one shared file in ArduPilot/ardupilot#29617. With ArduPilot/ardupilot#35149 the parser reads that file, so this removes the upper limit and the Stream Groups section is generated for 4.7 and later too.The lower limit stays, because 4.0 has no stream group arrays.
If this is merged before the parser change, nothing breaks. The parser on master finishes cleanly with
-gand writes the intro sentence with no section. The parser change should still land first.If you would prefer to leave Stream Groups out, please close this one together with ArduPilot/ardupilot#35149.
Details: testing
Testing
run_parsers.pywas run end to end twice on a case-sensitive disk, once unchanged and once with this change and the parser from Tools: scripts: mavlink_parse: find stream groups in every version ardupilot#35149.MAVLinkMessages.rstfiles were rewritten by both runs. Blimp-4.7 has no tag, so neither run touches it.