Skip to content

Fix vault health, auction data, and development reloads - #1156

Open
KillariDev wants to merge 2 commits into
mainfrom
t3code/project-issue-review
Open

KillariDev wants to merge 2 commits into
mainfrom
t3code/project-issue-review

Conversation

@KillariDev

Copy link
Copy Markdown
Collaborator

Fix four audit findings that overstated vault health, left auction data stale, made auction totals depend on pagination, and broke live reload on custom ports.

  • Calculate scanner vault health against the full underwriting commitment, including when current open interest is low or zero.
  • Refresh auction books, bidder claims, and selected-child metrics automatically on new blocks and explicit refreshes, preserving recovery after delayed or failed reads.
  • Read auction finalization totals from the contract preview so loading more than 25 price levels cannot change the summary.
  • Send watcher reloads to the server's actual bound port, including custom ports, ephemeral ports, and restarted servers.

Validation

  • Passed bun run tsc, bun run format:check, bun run check, bun run knip, and git diff --check after merging current origin/main.
  • Passed 239 scoped tests: 191 auction protocol, hook, section, settlement, and directly affected workflow tests; 22 scanner operations, snapshots, and PostgreSQL operations tests; 24 dev-server, reload, watcher, build-DAG, and source-size tests; and two existing watcher/import-map consumer tests.
  • Browser QA in Chromium 154 at 1440×900 and 390×844: scanner production API backed by PostgreSQL 17.11 fixtures; simulated auction bids/refunds, delayed reads, and failure recovery.

Skipped the full suite because impact is bounded to these consumers. Contract, fuzz, live-network, and full transaction workflow tests were skipped because contracts and transaction writes are unchanged. Generated freshness and documentation-specific review were skipped because generation inputs/artifacts and published documentation are unchanged.

Resulting UI

Scanner vault health based on underwriting commitment

Truth auction desktop

Truth auction mobile

@KillariDev
KillariDev added this pull request to the merge queue Oct 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant