Repository navigation
fix(client): display platform-appropriate search hotkey label - #687
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
agammann
reviewed
Nov 11, 2026
agammann
left a comment
agammann
left a comment
There was a problem hiding this comment.
The non-Mac branch displays Ctrl K, while the shortcut and the PR description use Ctrl+K. Could the hint include the + so it reads as one key combination? This is the only new text in the change, and the current label could be read as two separate keys.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664
Summary
The search bar previously hardcoded \⌘K\ as the keyboard shortcut hint. While \⌘K\ is standard on macOS, non-Mac platforms (Windows, Linux) use \Ctrl+K\ (which is already supported by the keydown listener in \�pp.js).
Changes