Skip to content

Added usd display for bitcoin amounts. - #698

Open
Randy808 wants to merge 1 commit into
Blockstream:masterfrom
Randy808:btc-usd-values
Open

Randy808 wants to merge 1 commit into
Blockstream:masterfrom
Randy808:btc-usd-values

Conversation

@Randy808

Copy link
Copy Markdown
Collaborator

To run locally, npm install and use the following snippets:

# Bitcoin
export API_URL=https://blockstream.info/api
export PORT=4999
source flavors/blockstream/config.env
source flavors/bitcoin-mainnet/config.env
npm run dev-server
# Liquid
export API_URL=https://blockstream.info/liquid/api
export PORT=5000
source flavors/blockstream/config.env
source flavors/liquid-mainnet/config.env
npm run dev-server

Screenshots of added usd values

Screenshot 2026-11-12 at 2 57 46 PM Screenshot 2026-11-12 at 2 57 29 PM Screenshot 2026-11-12 at 2 57 20 PM

@jtrivinop

Copy link
Copy Markdown

Opus 5.5 review:

Request changes. Fix the repeated price fetching.

USD values are correct on Bitcoin and Liquid mainnet; testnets are unaffected.
Tested: tests pass (126/126), both builds succeed, and every page shows USD on desktop and phone with no console errors.

Should fix
The price API is called on every page change (5 calls for 5 pages), though the data is hourly and the API rate-limits per IP. Reuse the cached price.

@Randy808

Copy link
Copy Markdown
Collaborator Author

Opus 5.5 review:

Request changes. Fix the repeated price fetching.

USD values are correct on Bitcoin and Liquid mainnet; testnets are unaffected. Tested: tests pass (126/126), both builds succeed, and every page shows USD on desktop and phone with no console errors.

Should fix The price API is called on every page change (5 calls for 5 pages), though the data is hourly and the API rate-limits per IP. Reuse the cached price.

Fixed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants