Skip to content

Target for generating PDF - #145

Merged
roconnor-blockstream merged 1 commit into
masterfrom
mk-pdf
May 18, 2023
Merged

roconnor-blockstream merged 1 commit into
masterfrom
mk-pdf

Conversation

@roconnor-blockstream

Copy link
Copy Markdown
Collaborator

Texmacs does not make this easy.

Related to #141.

@apoelstra

apoelstra commented May 18, 2023 •

Copy link
Copy Markdown
Collaborator

I have a mild preference for using mxDerivation so that I have the overrideDerivation attribute, which I use to add extra metadata to my derivations. But this is fine. overrideAttrs works.

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a365c82

@roconnor-blockstream

Copy link
Copy Markdown
Collaborator Author

P.S. It isn't mkDerivation that adds overrideDerivation, it is callPackage that does. runCommand actually uses mkDerivation. mkDerivation does add overrideAttrs which is the new-and-improved version of overrideDerivation.

@roconnor-blockstream
roconnor-blockstream merged commit a365c82 into master May 18, 2023
@roconnor-blockstream
roconnor-blockstream deleted the mk-pdf branch May 18, 2023 14:52
apoelstra added a commit to apoelstra/local-nix-ci that referenced this pull request Jul 14, 2023
Switched from overrideDerivation to overrideAttrs because
overrideDerivation was not working on Russell's new PDF derivation --
see BlockstreamResearch/simplicity#145

Russell explained on Rocket that overrideDerivation is "old school"
and soft-deprecated and that overrideAttrs is to be prefered. See
https://nixos.org/manual/nixpkgs/stable/#sec-pkg-overrideDerivation
(It references "the overrideAttrs documentation". To find this, scroll
up.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants