Repository navigation
Replace CC_RAD_TO_DEG/CC_DEG_TO_RAD with inline methods #20
Description
Describe the feature you would like
Replacing these constants with inlines would make code more readable and help eliminate casting and compiler warnings.
CCLib::CC_RAD_TO_DEG*phibecomes
CCLib::radiansToDegrees( phi )(Move strategy here from comment below.)
Because this touches a lot of math, I'm going to do this in multiple steps so it can be reviewed more easily.
- Add CCMath.h, mark
RAD_TO_DEGas deprecated, and commit CCCoreLib - Change all occurrences in CloudCompare and wait for code review
- Mark
DEG_TO_RADas deprecated and commit CCCoreLib - Change all occurrences in CloudCompare and wait for code review
- Mark
ZERO_TOLERANCEas deprecated and commit CCCoreLib - Change all occurrences in CloudCompare and wait for code review
- Once everything is converted, remove
RAD_TO_DEG,DEG_TO_RAD, andZERO_TOLERANCE
Activity
dgirardeau commentedon Apr 24, 2020
Why not
asmaloney commentedon Apr 25, 2020
So the next question is where do these new methods (and the ZERO_TOLERANCE ones) live? They are no longer constants.
Maybe a new
CCMath.h?dgirardeau commentedon Apr 25, 2020
Yes why not!
Add CCMath.h and mark RAD_TO_DEG as deprecated
Add CCMath.h and mark RAD_TO_DEG as deprecated
Add CCMath.h and mark RAD_TO_DEG as deprecated (#35)
Use new CCCoreLib::radiansToDegrees()
Use new CCCoreLib::RadiansToDegrees() (#1184)
Mark DEG_TO_RAD as deprecated
Mark DEG_TO_RAD as deprecated (#39)
Use new CCCoreLib::DegreesToRadians()
Use new CCCoreLib::DegreesToRadians() (#1186)
Mark ZERO_TOLERANCE as deprecated
Mark ZERO_TOLERANCE as deprecated (#40)
Use new CCCoreLib::LessThanEpsilon()/CCCoreLib::GreaterThanEpsilon()
Use new CCCoreLib::LessThanEpsilon()/CCCoreLib::GreaterThanEpsilon()
Use new CCCoreLib::LessThanEpsilon()/CCCoreLib::GreaterThanEpsilon() (#…
Use new CCCoreLib::RadiansToDegrees() (CloudCompare#1184)
Use new CCCoreLib::DegreesToRadians() (CloudCompare#1186)
Use new CCCoreLib::LessThanEpsilon()/CCCoreLib::GreaterThanEpsilon() (C…