Skip to content

Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 2 | Complete Sprint 2 exercises - #1502

Open
salahalsabhi wants to merge 2 commits into
CodeYourFuture:mainfrom
salahalsabhi:sprint-2-clean
Open

salahalsabhi wants to merge 2 commits into
CodeYourFuture:mainfrom
salahalsabhi:sprint-2-clean

Conversation

@salahalsabhi

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1083

Changelist

Completes Sprint 2 exercises across implement, debug, interpret, and stretch.

Questions

no questions.

@salahalsabhi salahalsabhi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 6, 2026
Comment thread Sprint-2/debug/address.js Outdated
console.log(`My house number is ${address.houseNumber}`);


/* BUG: address[0] is undefined because objects aren't indexed by number.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const obj = {  0: 42,  '1': 43 };

console.log(obj[0], obj[1]); 

Could you check if the output matches your expectation?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed — switched to address.houseNumber and corrected the console.log call. Added a short comment explaining why numeric indexing doesn’t work on plain objects.

@cjyuan cjyuan Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was only trying to indirectly point out that the description in the comment is not quite correct. Perhaps too indirect. 😄

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thank you anyway 😄

Comment thread Sprint-2/implement/contains.test.js Resolved
Comment thread Sprint-2/implement/tally.js Resolved
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 10, 2026
@salahalsabhi salahalsabhi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2026
@cjyuan

cjyuan commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants