Repository navigation
Conversation
The published check compared a bare tag with currentHashtag, which is stored with a leading hash, so the condition never became false. Co-authored-by: Cursor <cursoragent@cursor.com>
👷 Deploy request for cyf-curriculum pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The legacy-code prep solution for the hashtag loop compared
hashtagwithstate.currentHashtag. In Module-Legacy-Code, the router passes the tag without a#, andgetBloomsByHashtagstorescurrentHashtagas#plus the tag. Those two strings never match, so the published check stays true and the requests never stop.This uses the correction described by @RaihanSharif in #2032, and adds one sentence so a trainee can see why the
#has to be on both sides.Common Content?
module/legacy/fixingChecklist
Module-Legacy-Coderouter.mjsandapi.mjsWho needs to know about this?
@RaihanSharif reported this and described the fix. @illicitonion