Repository navigation
fix missing symbol - #1094
Open
purplegrape wants to merge 1 commit into
Open
fix missing symbol#1094purplegrape wants to merge 1 commit into
purplegrape wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All ten changes correctly restore the numbered placeholder, with no unrelated changes or unresolved issues.
No open issues 🎉
What changed in this PR
Fixes date/time range labels in iTop’s localized search interface by restoring a missing % in the first argument placeholder.
Changes:
- Replaces literal
1$swith%1$sin ten language dictionaries so the field name is displayed correctly.
| File | Description |
|---|---|
| dictionaries/zh_cn.dictionary.itop.ui.php | Fixes the Simplified Chinese range placeholder. |
| dictionaries/ru.dictionary.itop.ui.php | Fixes the Russian range placeholder. |
| dictionaries/pt_br.dictionary.itop.ui.php | Fixes the Brazilian Portuguese range placeholder. |
| dictionaries/pl.dictionary.itop.ui.php | Fixes the Polish range placeholder. |
| dictionaries/nl.dictionary.itop.ui.php | Fixes the Dutch range placeholder. |
| dictionaries/hu.dictionary.itop.ui.php | Fixes the Hungarian range placeholder. |
| dictionaries/fr.dictionary.itop.ui.php | Fixes the French range placeholder. |
| dictionaries/es_cr.dictionary.itop.ui.php | Fixes the Costa Rican Spanish range placeholder. |
| dictionaries/de.dictionary.itop.ui.php | Fixes the German range placeholder. |
| dictionaries/cs.dictionary.itop.ui.php | Fixes the Czech range placeholder. |
Review effort: Balanced
Contributor
Author
Hipska
approved these changes
Oct 27, 2026
Molkobain
approved these changes
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix missing symbol.
other branches also has the same issue.