Repository navigation
[ObservableProperty] generates partial OnPropertyChanging/Changed methods - #119
Merged
Merged
Conversation
Member
|
@Sergio0694 in your comment above on the PR: /// <summary>Executes the logic for when <see cref="Name"/> is changing.</summary>
[global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.Mvvm.SourceGenerators.ICommandGenerator", "8.0.0.0")]
Should it be IPropertyChangeGenerator vs. |
Member
Author
|
@michael-hawker Whoops, good catch! 😄 |
Sergio0694
force-pushed
the
dev/partial-observable-property-methods
branch
from
February 22, 2022 18:59
93330b0 to
7b08d58
Compare
michael-hawker
approved these changes
Feb 22, 2022
michael-hawker
left a comment
Member
There was a problem hiding this comment.
Looks good, just a suggestion for another test if you think it'd be good.
Sergio0694
force-pushed
the
dev/partial-observable-property-methods
branch
from
February 28, 2022 23:17
17c2cf4 to
f40eb62
Compare
Arlodotexe
approved these changes
Mar 1, 2022
delete-merged-branch
Bot
deleted the
dev/partial-observable-property-methods
branch
March 1, 2022 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
This PR generates
OnPropertyChangingandOnPropertyChangedpartial methods for[ObservableProperty].FYI @sonnemaf
Example code
Generated code