Repository navigation
SYS_UID_MIN/SYS_UID_MAX are inclusive use greater only(no equal) - #15277
Open
teacup-on-rockingchair wants to merge 2 commits into
Open
teacup-on-rockingchair wants to merge 2 commits into
teacup-on-rockingchair wants to merge 2 commits into
Conversation
teacup-on-rockingchair
added
Test Suite
teacup-on-rockingchair
requested review from
Mab879,
jan-cerny,
matusmarhefka and
vojtapolasek
as code owners
November 1, 2026 14:20
vojtapolasek
requested changes
Nov 10, 2026
vojtapolasek
left a comment
vojtapolasek
left a comment
Collaborator
There was a problem hiding this comment.
Please add a test for all platforms which checks exactly the off by one error you address. You check it only for Suse platform. Thank you.
| @@ -0,0 +1,9 @@ | |||
| #!/bin/bash | |||
|
|
|||
| {{% if product in ['opensuse16', 'sle16', 'slmicro6'] %}} | |||
Collaborator
There was a problem hiding this comment.
Is this actually needed? There is similar if conditional within the macro it self.
Contributor
Author
There was a problem hiding this comment.
Definitely overdoing it here :) thanks for bringing it up 🙇 Should be ok in 252a3ea
…self Thanks to @vojtapolasek for noting 🙇
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints: