Repository navigation
fix(telemetry): keep mysql's -P port and redact the real -p password (fixes #815) - #819
Open
charan-rathore wants to merge 2 commits into
Open
charan-rathore wants to merge 2 commits into
charan-rathore wants to merge 2 commits into
Conversation
The mysql credential rule's i flag let the attached port form -P3306 match as if it were -p, so the port was redacted as a secret and a real password later in the same command survived into OTLP export. Make the rule case-sensitive like the sshpass rule (mysql is the same shape: -p is the password, -P is the port). Fixes CopilotKit#815 Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>
Mixed -P3306/-phunter2 command keeps the port and redacts the password; lowercase attached form and mysqldump pinned alongside. Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>
charan-rathore
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 21, 2026 16:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mysql credential rule in server/src/telemetry/scrub.ts kept the
iflag, so the attached port form-P3306matched as if it were-p: the port got redacted as a secret and a real password later in the same command survived into OTLP export (gh-815).Make the rule case-sensitive like the sibling sshpass rule:
-pis mysql's password,-Pis its port. Pinned in server/tests/enterprise-controls.test.ts:mysql -h db -P3306 -phunter2 app->mysql -h db -P3306 -p[REDACTED] app-p3306still redacts,mysqldump -phunter2 dbunchanged, bare/space forms untouched.RED before (port redacted,
-phunter2survived), GREEN after; both scrub suites 52/52.