Skip to content

Feature request: Set branch to compare against #19

Open
Open
Feature request: Set branch to compare against#19

Description

@jasonbarry
jasonbarry
opened on Oct 16, 2017

Right now, it appears that the comparison is always with the master branch. It would be nice if you could compare with a given branch.

For example, in my repo I've changed my default/base branch to be dev. I would like the artifact measurement to compare against the dev branch instead of master.

Thanks for your awesome work!

Activity

  1. Daniel15 commented on Oct 16, 2017

    @Daniel15
    Daniel15
    on Oct 16, 2017
    Owner

    Yeah there's a todo for that in the code:

    BuildSize/app/Services/Build/AbstractBuildService.php

    Line 73 in 0e39cd8

    // TODO: This should handle default_branch too
    . I haven't seen many projects that change the default branch, but I agree that it would be good to have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions