Repository navigation
Conversation
Extend the IBM MQ-only DSM gate in the JMS instrumentation to also cover TIBCO EMS, detected via the com.tibco.tibjms message class prefix. Behavior matches IBM MQ: produce/consume checkpoints only, no DSM context propagation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
❌ New Groovy Files Detected Please avoid introducing new
Instead, rewrite the new file(s) in Java / JUnit. See the How to Test With JUnit Guide for more details. If this PR needs an exception, add the |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
TIBCO EMS uses the existing IBM MQ producer and consumer DSM checkpoint paths while preserving the enablement gate. The completed static review found no actionable defects; live EMS behavior remains unverified.
🤖 Bits Code Review · Commit 1b6044f
What Does This Do
Adds Data Streams Monitoring (DSM) checkpoints for TIBCO EMS in the JMS instrumentation, at the same level of support IBM MQ has today.
JMSDecorator.messageTechnology()now returnstibcoemsfor messages whose class starts withcom.tibco.tibjms.JMSDecorator.isDataStreamsSupported(tech), which allowsibmmqandtibcoems.Applies to both
javax.jmsandjakarta.jms. Only takes effect whenDD_DATA_STREAMS_ENABLED=true. No change for other brokers.Motivation
The JMS instrumentation hooks the
javax.jmsinterfaces generically, so every JMS broker already gets APM spans. DSM checkpoints, however, are gated to IBM MQ by the message class name, so TIBCO EMS clients never appear in DSM. TIBCO EMS is a pure JMS broker with no dedicated Datadog instrumentation, so the double-reporting concern that kept #9768 IBM MQ-only doesn't apply.Support for TIBCO EMS in the Java tracer
Additional Notes
JMSDecoratorTestcovers vendor detection for TIBCO, IBM, generic, and null messages. As with IBM MQ, there's no broker integration test, because TIBCO EMS has no redistributable image or public client artifact. End-to-end validation against a local EMS Community Edition broker is pending.tibcoemslabel in the DSM UI. It currently renders there as an unrecognized queue type.Jira ticket: [PROJ-IDENT]
🤖 Generated with Claude Code