Skip to content

Add Data Streams Monitoring support for TIBCO EMS in JMS - #12961

Open
rkaneriya wants to merge 1 commit into
masterfrom
rishi.kaneriya/jms-dsm-tibco-ems
Open

rkaneriya wants to merge 1 commit into
masterfrom
rishi.kaneriya/jms-dsm-tibco-ems

Conversation

@rkaneriya

Copy link
Copy Markdown

What Does This Do

Adds Data Streams Monitoring (DSM) checkpoints for TIBCO EMS in the JMS instrumentation, at the same level of support IBM MQ has today.

  • JMSDecorator.messageTechnology() now returns tibcoems for messages whose class starts with com.tibco.tibjms.
  • The three IBM MQ-only gates (two produce paths, one consume path) now use JMSDecorator.isDataStreamsSupported(tech), which allows ibmmq and tibcoems.

Applies to both javax.jms and jakarta.jms. Only takes effect when DD_DATA_STREAMS_ENABLED=true. No change for other brokers.

Motivation

The JMS instrumentation hooks the javax.jms interfaces generically, so every JMS broker already gets APM spans. DSM checkpoints, however, are gated to IBM MQ by the message class name, so TIBCO EMS clients never appear in DSM. TIBCO EMS is a pure JMS broker with no dedicated Datadog instrumentation, so the double-reporting concern that kept #9768 IBM MQ-only doesn't apply.

Support for TIBCO EMS in the Java tracer

Before After this PR
APM spans for produce/consume, plus trace context in JMS properties ✅ ✅
DSM produce/consume checkpoints (services and queues on the DSM map, throughput) ❌ ✅
DSM pathway context propagation (multi-hop pathway stitching, end-to-end latency) ❌ ❌ (same as IBM MQ)

Additional Notes

  • Tests: JMSDecoratorTest covers vendor detection for TIBCO, IBM, generic, and null messages. As with IBM MQ, there's no broker integration test, because TIBCO EMS has no redistributable image or public client artifact. End-to-end validation against a local EMS Community Edition broker is pending.
  • Follow-ups, not in this PR: opt-in DSM context propagation for EMS, and a tibcoems label in the DSM UI. It currently renders there as an unrecognized queue type.

Jira ticket: [PROJ-IDENT]

🤖 Generated with Claude Code

Extend the IBM MQ-only DSM gate in the JMS instrumentation to also cover
TIBCO EMS, detected via the com.tibco.tibjms message class prefix. Behavior
matches IBM MQ: produce/consume checkpoints only, no DSM context propagation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rkaneriya rkaneriya added type: feature Enhancements and improvements inst: jms JMS instrumentation comp: data streams Data Streams Monitoring labels Oct 20, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

❌ New Groovy Files Detected

Please avoid introducing new .groovy files to this repository.

  • dd-java-agent/instrumentation/jms/javax-jms-1.1/src/test/groovy/com/ibm/jms/JMSTextMessage.groovy
  • dd-java-agent/instrumentation/jms/javax-jms-1.1/src/test/groovy/com/tibco/tibjms/TibjmsTextMessage.groovy

Instead, rewrite the new file(s) in Java / JUnit. See the How to Test With JUnit Guide for more details.

If this PR needs an exception, add the tag: override groovy enforcement label to bypass this workflow.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.85% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1b6044f | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.69 s 14.74 s [-1.0%; +0.3%] (no difference)
startup:insecure-bank:tracing:Agent 13.65 s 13.61 s [-0.4%; +1.0%] (no difference)
startup:petclinic:appsec:Agent 17.12 s 16.99 s [-0.3%; +1.7%] (no difference)
startup:petclinic:iast:Agent 16.82 s 16.94 s [-1.6%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.56 s 16.22 s [-2.4%; +6.6%] (no difference)
startup:petclinic:sca:Agent 17.04 s 16.93 s [-0.3%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.07 s 16.04 s [-0.6%; +1.1%] (no difference)

Commit: 1b6044f7 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@rkaneriya
rkaneriya marked this pull request as ready for review October 20, 2026 14:45
@rkaneriya
rkaneriya requested a review from a team as a code owner October 20, 2026 14:45
@rkaneriya
rkaneriya requested review from ValentinZakharov and removed request for a team October 20, 2026 14:45
@dd-octo-sts dd-octo-sts Bot added the tag: ai generated Largely based on code generated by an AI or LLM label Oct 20, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T14:48:03.705493Z 1b6044f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

TIBCO EMS uses the existing IBM MQ producer and consumer DSM checkpoint paths while preserving the enablement gate. The completed static review found no actionable defects; live EMS behavior remains unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 1b6044f

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: data streams Data Streams Monitoring inst: jms JMS instrumentation tag: ai generated Largely based on code generated by an AI or LLM type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant