Skip to content

gpu: add metadata for sharing fraction and fraction memory limit metrics - #25732

Open
martavicentenavarro wants to merge 1 commit into
masterfrom
martavicentenavarro/gpu-sharing-fraction-metadata
Open

martavicentenavarro wants to merge 1 commit into
masterfrom
martavicentenavarro/gpu-sharing-fraction-metadata

Conversation

@martavicentenavarro

@martavicentenavarro martavicentenavarro commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds metadata for the new gpu.device.sharing_fraction and gpu.fraction.memory.limit metrics, generated from the GPU spec with dda inv gpu.update-metadata (only the new rows kept).

Motivation

Checklist before requesting review

  • I self-reviewed the full diff, and this description matches the final change
  • Tests cover the change, or this description explains why none are needed (metadata-only change, validated with ddev validate metadata gpu)
  • Automated review comments, including Codex review, were addressed or answered
  • I, the human author, understand this change, can explain it to reviewers, and believe it meets the repository standards

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

Validate repository | Run Validations / Validate

View more details · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1b65880 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   4 (always emitted)
Diff (1 file):
  gpu/metadata.csv

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@martavicentenavarro
martavicentenavarro marked this pull request as ready for review October 22, 2026 09:43
@martavicentenavarro
martavicentenavarro requested a review from a team as a code owner October 22, 2026 09:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T09:45:38.938444Z ff14e8b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The sharing-fraction metadata row uses a valid gauge type and fraction unit and satisfies required-field, description, uniqueness, and ordering constraints. The completed static review found no actionable issues.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit ff14e8b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@martavicentenavarro
martavicentenavarro force-pushed the martavicentenavarro/gpu-sharing-fraction-metadata branch from ff14e8b to 1b65880 Compare October 22, 2026 11:19
@martavicentenavarro martavicentenavarro changed the title gpu: add metadata for sharing fraction metric gpu: add metadata for sharing fraction and fraction memory limit metrics Oct 22, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
pr-description Validate the pull request checklist and visible description length

To fix: Tick every item in .github/PULL_REQUEST_TEMPLATE.md and keep the description under 3,000 visible characters.
❌

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (21)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant