Skip to content

Address documentation review of vLLM NIXL metrics - #25752

Draft
aboitreaud wants to merge 1 commit into
masterfrom
adrien.boitreaud/vllm-nixl-docs-review
Draft

aboitreaud wants to merge 1 commit into
masterfrom
adrien.boitreaud/vllm-nixl-docs-review

Conversation

@aboitreaud

Copy link
Copy Markdown
Contributor

What does this PR do?

Applies the documentation review of #25742 to the vLLM integration:

  • README: clarifies how to set openmetrics_endpoint when vLLM runs as an NVIDIA Dynamo backend worker, with an example URL (http://<HOST>:<DYN_SYSTEM_PORT>/metrics), and spells out NIXL (NVIDIA Inference Xfer Library).
  • metadata.csv: rewords the descriptions of the vllm.nixl.* histogram .count metrics, spells out RDMA, and clarifies num_notifications_after_expiry.

Motivation

#25742 was merged before the @DataDog/documentation review was addressed (comment). This follow-up applies every inline suggestion. NIXL expansion per ai-dynamo/nixl.

Checklist before requesting review

  • I self-reviewed the full diff, and this description matches the final change
  • Tests cover the change, or this description explains why none are needed
  • Automated review comments, including Codex review, were addressed or answered
  • I, the human author, understand this change, can explain it to reviewers, and believe it meets the repository standards

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dd-octo-sts

dd-octo-sts Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests: passed

Dispatcher beta: informational only
Existing CI remains the merge signal.

  2/2 jobs

✅ 2 passed · nothing failed

Batches · ✅ batch-01 2/2

Dispatcher finished on 6e21b61 — GitHub Run · Dispatcher Logs.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   4 (always emitted)
Diff (2 files):
  vllm/README.md
  vllm/metadata.csv

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Pipelines  Tests  Code Coverage

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

Validate repository | Run Validations / Validate

View more details · View in GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 95.89%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 932639a | Docs | View more details | Give us feedback!

@aboitreaud aboitreaud added the qa/skip-qa Automatically skip this PR for the next QA label Oct 22, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
pr-description Validate the pull request checklist and visible description length

To fix: Tick every item in .github/PULL_REQUEST_TEMPLATE.md and keep the description under 3,000 visible characters.
❌

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (21)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant