Repository navigation
Address documentation review of vLLM NIXL metrics - #25752
Draft
aboitreaud wants to merge 1 commit into
Draft
aboitreaud wants to merge 1 commit into
aboitreaud wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
✅ Dispatcher tests: passed
✅ 2 passed · nothing failed Batches · ✅ batch-01 2/2 Dispatcher finished on |
evalya-impact-summaryevalya impact analysis |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed 🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 932639a | Docs | View more details | Give us feedback! |
Contributor
Validation Report
Run Passed validations (21)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Applies the documentation review of #25742 to the vLLM integration:
openmetrics_endpointwhen vLLM runs as an NVIDIA Dynamo backend worker, with an example URL (http://<HOST>:<DYN_SYSTEM_PORT>/metrics), and spells out NIXL (NVIDIA Inference Xfer Library).metadata.csv: rewords the descriptions of thevllm.nixl.*histogram.countmetrics, spells out RDMA, and clarifiesnum_notifications_after_expiry.Motivation
#25742 was merged before the @DataDog/documentation review was addressed (comment). This follow-up applies every inline suggestion. NIXL expansion per ai-dynamo/nixl.
Checklist before requesting review
🤖 Generated with Claude Code