Repository navigation
Conversation
Loaded implicit modules put spack libraries (e.g. ncurses) on LD_LIBRARY_PATH ahead of the system ones, which crashes system tools such as watch. Spack binaries find their dependencies through RPATH, so they are not needed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019UTqLbGRYU1XZe4KojRT8p
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The module configuration removes the zlib provider’s LIBRARY_PATH, which MOAB’s explicit -lz flag needs at link time, potentially breaking the smoke-test link unless zlib and zlib-ng are preserved as include exceptions.
1 open issue
What changed in this PR
Stops generating Lmod modules for implicit Spack dependencies in GHCI
images to prevent their libraries from shadowing system libraries.
Changes:
- Replaces
hide_implicitswithexclude_implicitsin Spack configuration. - Updates comments to explain the exclusion and its purpose.
| File | Description |
|---|---|
ghci/env/spack-configuration/modules.yaml |
Excludes implicit dependency modules. |
ghci/env/Dockerfile |
Updates a comment; no functional change. |
Review effort: Balanced
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019UTqLbGRYU1XZe4KojRT8p
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019UTqLbGRYU1XZe4KojRT8p
The apptainer .deb depends on libfuse3-3, which is not installable on the runner image ubuntu-latest now points to. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019UTqLbGRYU1XZe4KojRT8p
bartgol
enabled auto-merge
November 18, 2026 23:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replace
hide_implicits: truewithexclude_implicits: truein the spackmodules.yaml, so only the packages we explicitly install get an lmod module.With
hide_implicits, implicit dependencies (ncurses, readline, libedit, ...) still had modules, which were autoloaded and put spack's libraries onLD_LIBRARY_PATH, just hidden fromml. Spack's ncurses 6.6 then shadowed the system one, and system tools linked against the system ncurses crash, e.g.watch lssegfaults in the intel image. Spack binaries find their dependencies through RPATH, so those modules are not needed at runtime.Also updates a Dockerfile comment that said implicit modules are hidden.
Things to check in CI, since this is untested:
mllists only explicit packages (no(H)entries) andwatch lsno longer crashes.LIBRARY_PATHat link time (e.g. the bare-lzin MOAB'sMOAB_PACKAGE_LIBS, see the comment inmodules.yaml) or on Eigen being findable. The fix would be aninclude:entry inmodules.yamlfor the package that fails.Generated by Claude Code