This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Fix nested container tests - #11006
Merged
Merged
Conversation
plroblox
approved these changes
Jan 5, 2022
plroblox
left a comment
There was a problem hiding this comment.
Excellent ! map should go with key-value whereas pair should go-with firt-second regarding the JSON input formats of typess involving map/pair
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This PR fixes nested container tests for pair and map containers.
Map can be defined through
keyandvaluelike this:[{"key":10, "value":100],{"key":10, "value":100}]Pair can be defined through
firstandsecondlike this:["first":30, "second":{"first":301, "second":302}]Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions