Repository navigation
Update CISM-wrapper for the Glide/Glissade separation, part 1 - #160
Open
whlipscomb wants to merge 2 commits into
Open
whlipscomb wants to merge 2 commits into
whlipscomb wants to merge 2 commits into
Conversation
In CISM, the netCDF I/O routines in libglimmer no longer take the full model instance (glide_global_type). They take the model's file lists (model%funits) and other values as needed. Update the calls in glc_io.F90: - glimmer_nc_createfile: pass model%funits and model%projection - glimmer_nc_write_timeslice: pass model%funits and the timestep count - glimmer_nc_checkwrite: pass model%funits, the timestep and the timestep count This requires the CISM commit "Remove glide_global_type from glimmer_ncio and glimmer_ncparams"; it does not build with older CISM versions. Does not change answers. Tested with 4 aux_glc tests (intel and gnu) compared against baselines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CISM now generates a separate I/O module for the Glissade dycore, glissade_io, which GLAD uses. In glc_io.F90, call glissade_io_create, glissade_io_write and glissade_avg_reset instead of the glide_io versions. (glide_nc_filldvars is unchanged.) This requires the CISM commit "Add glissade_io, generated from glissade_vars.def"; it does not build with older CISM versions. Does not change answers. Tested with 4 aux_glc tests (intel and gnu) compared against baselines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch:
lipscomb/split_glide_glissade_1Base:
lipscomb/remove_deprecated(#159). Stacked; the base will be changed tomasterafter the previous PRs are merged.Goes with ESCOMP/CISM#102 (
lipscomb/split_glide_glissade_1).2 commits, cherry-picked unchanged from #155.
Changes
glc_io.F90, which no longer take the full model instance (needs CISM bd6c4ea6).glissade_ioinstead ofglide_ioinglc_io.F90(needs CISM eef48b0d).Answer changes
None.
Testing
aux_glc subset (6 tests, as in #159) with ESCOMP/CISM#102: bit-for-bit with the aux_glc baseline for
cismwrap_3_00_003(#158; CISMcism_main_3.00.003, alpha11e externals). Also bit-for-bit with the #158 code using the earlier (alpha11d) externals.🤖 Generated with Claude Code