Skip to content

Update CISM-wrapper for the Glide/Glissade separation, part 1 - #160

Open
whlipscomb wants to merge 2 commits into
lipscomb/remove_deprecatedfrom
lipscomb/split_glide_glissade_1
Open

whlipscomb wants to merge 2 commits into
lipscomb/remove_deprecatedfrom
lipscomb/split_glide_glissade_1

Conversation

@whlipscomb

@whlipscomb whlipscomb commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Branch: lipscomb/split_glide_glissade_1
Base: lipscomb/remove_deprecated (#159). Stacked; the base will be changed to master after the previous PRs are merged.
Goes with ESCOMP/CISM#102 (lipscomb/split_glide_glissade_1).
2 commits, cherry-picked unchanged from #155.

Changes

  • 16b6b3c (from de869a7): update the calls to CISM's netCDF I/O routines in glc_io.F90, which no longer take the full model instance (needs CISM bd6c4ea6).
  • c559437 (from 5bcd21d): use glissade_io instead of glide_io in glc_io.F90 (needs CISM eef48b0d).

Answer changes

None.

Testing

aux_glc subset (6 tests, as in #159) with ESCOMP/CISM#102: bit-for-bit with the aux_glc baseline for cismwrap_3_00_003 (#158; CISM cism_main_3.00.003, alpha11e externals). Also bit-for-bit with the #158 code using the earlier (alpha11d) externals.

🤖 Generated with Claude Code

whlipscomb and others added 2 commits November 12, 2026 13:28
In CISM, the netCDF I/O routines in libglimmer no longer take the full model
instance (glide_global_type). They take the model's file lists
(model%funits) and other values as needed. Update the calls in glc_io.F90:

- glimmer_nc_createfile: pass model%funits and model%projection
- glimmer_nc_write_timeslice: pass model%funits and the timestep count
- glimmer_nc_checkwrite: pass model%funits, the timestep and the timestep
  count

This requires the CISM commit "Remove glide_global_type from glimmer_ncio and
glimmer_ncparams"; it does not build with older CISM versions.

Does not change answers. Tested with 4 aux_glc tests (intel and gnu)
compared against baselines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CISM now generates a separate I/O module for the Glissade dycore,
glissade_io, which GLAD uses. In glc_io.F90, call glissade_io_create,
glissade_io_write and glissade_avg_reset instead of the glide_io versions.
(glide_nc_filldvars is unchanged.)

This requires the CISM commit "Add glissade_io, generated from
glissade_vars.def"; it does not build with older CISM versions.

Does not change answers. Tested with 4 aux_glc tests (intel and gnu)
compared against baselines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants