Skip to content

Move share code out of CMEPS - #721

Merged
billsacks merged 3 commits into
ESCOMP:mainfrom
billsacks:reorganize_share_code
Nov 10, 2026
Merged

billsacks merged 3 commits into
ESCOMP:mainfrom
billsacks:reorganize_share_code

Conversation

@billsacks

Copy link
Copy Markdown
Member

Description of changes

This PR reorganizes the code that was in nuopc_cap_share. Previously this code was built as part of the share library - not CMEPS. This is now moved into the CESM_share repository in ESCOMP/EPS_Share#88, so that library boundaries reflect the repository boundaries.

Specifically:

(1) driver_pio_mod and esm_utils_mod are now in the cesm driver directory, since they are only used from there

(2) all other files from nuopc_cap_share have been moved into CESM_share

(3) shr_flux_mod has also been moved into CESM_share (this module was also built as part of the share library)

For CESM and NorESM, this PR depends on ESCOMP/EPS_Share#88; this CMEPS PR must be brought in at the same time or after that CESM_share PR.

Specific notes

Contributors other than yourself, if any: @mvertens helped figure out the organization we want

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) - bfb

Any User Interface Changes (namelist or namelist defaults changes)? no

Testing performed

aux_cime_baselines in the context of cesm3_0_alpha11d, with this branch along with the accompanying CESM_share branch. Tests pass and are bit-for-bit except expected failures.

driver_pio_mod and esm_utils_mod are only used from code in the cesm
driver directory.

@mvertens mvertens left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for your work on this.

@megandevlan megandevlan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for the heads up on where shr_flux_mod has moved, should be totally workable :)

whlipscomb added a commit to whlipscomb/CMEPS that referenced this pull request Nov 9, 2026
Restore cesm/nuopc_cap_share/glc_elevclass_mod.F90 to its version on
main, to avoid a conflict with CMEPS PR ESCOMP#721. The previous commit only
updated a comment in this file. The code changes in
med_phases_prep_glc_mod.F90 are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@billsacks
billsacks merged commit 8035cb1 into ESCOMP:main Nov 10, 2026
1 check passed
@billsacks
billsacks deleted the reorganize_share_code branch November 10, 2026 19:53
mvertens pushed a commit to NorESMhub/CMEPS that referenced this pull request Nov 17, 2026
Restore cesm/nuopc_cap_share/glc_elevclass_mod.F90 to its version on
main, to avoid a conflict with CMEPS PR ESCOMP#721. The previous commit only
updated a comment in this file. The code changes in
med_phases_prep_glc_mod.F90 are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants