Repository navigation
Open
Labels
FATESA change needed for FATES that doesn't require a FATES API update.A change needed for FATES that doesn't require a FATES API update.bugsomething is working incorrectlysomething is working incorrectlynon-b4bChanges answers (incl. adding tests)Changes answers (incl. adding tests)priority: lowBackground task that doesn't need to be done right away.Background task that doesn't need to be done right away.test: fatesPass fates test suite before mergingPass fates test suite before mergingtestingadditions or changes to testsadditions or changes to tests
Milestone
Description
Brief summary of bug
The FatesColdAllVars testmod is supposed to save every single FATES variable. However, there are 285 missing as of ctsm5.3.009.
General bug information
CTSM version you are using: ctsm5.3.009
Does this bug cause significantly incorrect results in the model's science? No
Configurations affected: Any test with the FatesColdAllVars testmod.
Details of bug
Might be resolved by #2061.
Important output or errors that show the problem
Can be tested from the top of a CTSM checkout like so (bash):
fates_hist_int_mod=src/fates/main/FatesHistoryInterfaceMod.F90
fatescoldallvars_nl=cime_config/testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm
for v in $(grep -oE "vname\s*=\s*[\"']\w+[\"']" $fates_hist_int_mod | sed -E "s/vname\s*=\s*//g" | sed "s/'//g"); do
nfound=$(grep "'$v'" $fatescoldallvars_nl | wc -l)
if [[ $nfound -gt 1 ]]; then
echo "$v: multiple matches"
elif [[ $nfound -eq 0 ]]; then
echo $v
fi
done | sortMetadata
Metadata
Assignees
Labels
FATESA change needed for FATES that doesn't require a FATES API update.A change needed for FATES that doesn't require a FATES API update.bugsomething is working incorrectlysomething is working incorrectlynon-b4bChanges answers (incl. adding tests)Changes answers (incl. adding tests)priority: lowBackground task that doesn't need to be done right away.Background task that doesn't need to be done right away.test: fatesPass fates test suite before mergingPass fates test suite before mergingtestingadditions or changes to testsadditions or changes to tests
Activity
wwieder commentedon Oct 17, 2024
One more reason for getting #2061 in. Maybe we can get that onto main sooner
samsrabin commentedon Oct 18, 2024
#2061 would resolve the need to keep the history variable list in
FatesColdAllVarsup-to-date. However, we'd probably want to add additional tests to theaux_clmsuite (or maybe just thefatessuite) that exercise additional FATES modes in order to output all the possible variables.ekluzek commentedon Jan 7, 2026
#2061 is in with ctsm5.4.006 so it has that part. But, @samrabin is right it should be exercised in more FATES modes to make sure we have more coverage of variables. So I'm turning that into a checklist