Skip to content

Variables missing from FatesColdAllVars testmod #2833

Description

@samsrabin

Brief summary of bug

The FatesColdAllVars testmod is supposed to save every single FATES variable. However, there are 285 missing as of ctsm5.3.009.

General bug information

CTSM version you are using: ctsm5.3.009

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: Any test with the FatesColdAllVars testmod.

Details of bug

Might be resolved by #2061.

Important output or errors that show the problem

Can be tested from the top of a CTSM checkout like so (bash):

fates_hist_int_mod=src/fates/main/FatesHistoryInterfaceMod.F90
fatescoldallvars_nl=cime_config/testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm
for v in $(grep -oE "vname\s*=\s*[\"']\w+[\"']" $fates_hist_int_mod | sed -E "s/vname\s*=\s*//g" | sed "s/'//g"); do
    nfound=$(grep "'$v'" $fatescoldallvars_nl | wc -l)
    if [[ $nfound -gt 1 ]]; then
        echo "$v: multiple matches"
    elif [[ $nfound -eq 0 ]]; then
        echo $v
    fi
done | sort

Activity

  1. added
    bugsomething is working incorrectly
    FATESA change needed for FATES that doesn't require a FATES API update.
    testingadditions or changes to tests
    non-b4bChanges answers (incl. adding tests)
    test: fatesPass fates test suite before merging
    nextthis should get some attention in the next week or two. Normally each Thursday SE meeting.
    on Oct 16, 2024
  2. removed
    nextthis should get some attention in the next week or two. Normally each Thursday SE meeting.
    on Oct 17, 2024
  3. wwieder commented on Oct 17, 2024

    @wwieder
    Contributor

    One more reason for getting #2061 in. Maybe we can get that onto main sooner

  4. samsrabin commented on Oct 18, 2024

    @samsrabin
    MemberAuthor

    #2061 would resolve the need to keep the history variable list in FatesColdAllVars up-to-date. However, we'd probably want to add additional tests to the aux_clm suite (or maybe just the fates suite) that exercise additional FATES modes in order to output all the possible variables.

  5. ekluzek commented on Jan 7, 2026

    @ekluzek
    Contributor

    #2061 is in with ctsm5.4.006 so it has that part. But, @samrabin is right it should be exercised in more FATES modes to make sure we have more coverage of variables. So I'm turning that into a checklist

    • Figure out new Fates tests to add with AllVars
    • Decide which should be fates and which aux_clm tests
    • Add the needed testmods for that
    • Add them to the testlist
  6. added
    priority: lowBackground task that doesn't need to be done right away.
    on Jan 7, 2026
  7. modified the milestones: ctsm6.1.0, ctsm7.0.0 on Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FATESA change needed for FATES that doesn't require a FATES API update.bugsomething is working incorrectlynon-b4bChanges answers (incl. adding tests)priority: lowBackground task that doesn't need to be done right away.test: fatesPass fates test suite before mergingtestingadditions or changes to tests

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions