Skip to content

Only run test_derecho_mpirun Python test on Derecho #2987

Description

@samsrabin

However, it should throw a warning on non-Derecho systems telling the user to make sure and test on Derecho too.

Activity

  1. added
    b4bbit-for-bit
    test: pythonPass clm_pymods test suite plus Python sys/unit tests before merging
    testingadditions or changes to tests
    on Mar 5, 2025
  2. changed the title [-]Only run test_derecho_mpirun unit test on Derecho[/-] [+]Only run test_derecho_mpirun Python unit test on Derecho[/+] on Mar 6, 2025
  3. samsrabin commented on Jun 6, 2025

    @samsrabin
    MemberAuthor

    Or maybe this should be moved out of our Python testing entirely—maybe even out of our repo? @ekluzek would it make sense for this to be a CIME test instead?

  4. changed the title [-]Only run test_derecho_mpirun Python unit test on Derecho[/-] [+]Only run test_derecho_mpirun Python test on Derecho[/+] on Jun 6, 2025
  5. samsrabin commented on Feb 11, 2026

    @samsrabin
    MemberAuthor

    @ekluzek This came across my radar again. Why does this need to be one of our Python system tests? Could it be a SystemTest that's part of aux_clm (or its own special suite) instead?

  6. 1 remaining item

  7. ekluzek commented on Feb 12, 2026

    @ekluzek
    Contributor

    Actually this test doesn't actually require running on Derecho. It doesn't actually run mpi, it just makes sure that the mpirun command is as expected. So it can be run anywhere.

    It would be good to run all the python tests in a github runner. But, this one isn't any different than the rest.

    So I'm closing, but feel free to reopen if you think it shouldn't be.

  8. ekluzek commented on Feb 12, 2026

    @ekluzek
    Contributor

    Or maybe this should be moved out of our Python testing entirely—maybe even out of our repo? @ekluzek would it make sense for this to be a CIME test instead?

    This is a good point. That might make sense. The reason I have it here is to make sure that mpi is going to work correctly for mksurfdata_esmf. So in a way it's particular to a CTSM tool.

  9. samsrabin commented on Feb 12, 2026

    @samsrabin
    MemberAuthor

    @ekluzek I'm reopening because this is still an issue, but it's a different issue. Will work on it eventually.

  10. removed
    closed: wontfixWe won't fix this issue, because it would be too difficult and/or isn't important enough to fix
    on Feb 12, 2026
  11. samsrabin commented on Feb 12, 2026

    @samsrabin
    MemberAuthor

    Or maybe this should be moved out of our Python testing entirely—maybe even out of our repo? @ekluzek would it make sense for this to be a CIME test instead?

    This is a good point. That might make sense. The reason I have it here is to make sure that mpi is going to work correctly for mksurfdata_esmf. So in a way it's particular to a CTSM tool.

    Why have this separate test in our Python suite—does the mksurfdata_esmf testing not effectively check this?

  12. ekluzek commented on Feb 12, 2026

    @ekluzek
    Contributor

    The mksurfdata test is more complicated. And when it was failing due to a change in cime/ccs_config, it wasn't clear what the problem was. This test was able to clearly show the problem in that case.

    So this is here in case changes in cime or ccs_config break mksurfdata again. It should help us to figure it out quickly.

  13. samsrabin commented on Feb 12, 2026

    @samsrabin
    MemberAuthor

    So would it be okay to move this test out of our Python testing dir and into tools/mksurfdata_esmf/?

  14. slevis-lmwg commented on Feb 14, 2026

    @slevis-lmwg
    Contributor

    So would it be okay to move this test out of our Python testing dir and into tools/mksurfdata_esmf/?

    By that do you mean "out of python testing and into clm_pymods" or something along those lines? I would consider that.

  15. samsrabin commented on Feb 17, 2026

    @samsrabin
    MemberAuthor

    That's not what I meant, but I don't like what I meant anymore anyway! Given Erik's use case, where this is only really useful during mksurfdata_esmf debugging, I think it's fine to skip during e.g. GitHub Workflow runs. With #3761 it will be easy to make that happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    b4bbit-for-bittest: pythonPass clm_pymods test suite plus Python sys/unit tests before mergingtestingadditions or changes to tests

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions