Skip to content

Review 2.12. Lake Model #3858

Closed

Description

@slevis-lmwg

What sort(s) of documentation issue is this?

  • Something is missing.
  • Something is (or might be) incorrect or outdated.
  • Something is confusing.
  • Something is broken.

What part(s) of the documentation does this concern?

  • Technical Note (science and design of the model)
  • User's Guide (using the model and related tools)
  • Somewhere else (e.g., README file, tool help text, or code comment): Please specify
  • I don't know

Describe the issue

See instructions in the parent issue.

Additional context (optional)

Tasks we found to do:

  • Look at the differences in the code between clm5.0 and now
  • Go through the tech note make sure it seems to match the code
  • Add a table for the lake parameters that are in the parameter file (or namelist)
  • Remove or update the section on changes since CLM4
  • Make sure snow changes are synchronized with the snow chapter
  • Make sure Meier roughness changes are synchronized with the surface flux chapter
  • Editorial change (2.12. Lake Model)- "atmosphere model of Hostetler et al. (1993), Hostetler et al. (1993)." Remove second "Hostetler et al. (1993)."
  • Editorial change (2.12. Lake Model)- "spatially variable depth" to "spatially varying depth"
  • Clarification (2.12. Lake Model) - "using the ground heat flux G as a top boundary condition". so Ground mean "surface"? I was thinking of lake bed but "top boundary" makes me realize the opposite.
  • Editorial change (2.12.1 vertical discretization) - "assumed depth" to "default depth"? Later the text says “default (50 m lake)”
  • (2.12.5.3 Boundary condition) - friction velocity calculated in section 2.12.5.3 -> section number seems to be wrong.
  • Editorial change( 2.12.2 External Data) - "based on interpolated compilations of geographic information" to just “interpolation"? And mention what kind of interpolation? Nearest neighbor, bilinear etc. ?
  • Clarification (2.12.3 Surface Albedo) - "where a is restricted to be no less than that given in (2.12.1)". but I don’t see anything about a mentioned in 2.12.1.
  • Clarification (2.12.4.1 Surface properties) - Tech-note said "For frozen lakes without resolved snow layers (snl=0), z0m=z0m_ice = 2.3 x10-3 m (Meier et al. (2022)), but, in the code, looks like it is from surface data.
  • Clarification (2.12.4.2 Surface Flux Solution). If I really go through the equations, it not very clear how the zonal and meridional momentum fluxes are used?
  • Editorial change (2.12.4.2 Surface Flux Solution). Eq. 2.12.21 L↑ should be L_g↑
  • Editorial change (2.12.4.2 Surface Flux Solution). After eq 2.12.27 and 2.12.28, there are lots of double parentheses i.e., (( xxxxx))

Activity

  1. added
    documentationadditions or edits to user-facing documentation or its infrastructure
    on Mar 25, 2026
  2. ekluzek commented on Apr 10, 2026

    @ekluzek
    Contributor

    I looked for differences in the code from the previous release. There are three types of changes that I see from looking for differences:

    git diff -w -b --stat release-clm5.0.37 Lake* 
     src/biogeophys/LakeCon.F90            |  31 +--
     src/biogeophys/LakeFluxesMod.F90      | 243 +++++++++++++----
     src/biogeophys/LakeHydrologyMod.F90   | 488 ++++++++++++++++++++--------------
     src/biogeophys/LakeStateType.F90      |   1 +
     src/biogeophys/LakeTemperatureMod.F90 | 137 ++++++----
     5 files changed, 570 insertions(+), 330 deletions(-)

    The three types are:

    • Code differences from small b4b-dev type changes (move parameters to the namelist file for example
    • Changes for Snow (the Sturm / Jordan type changes)
    • Changes for roughness (the Meir roughness scheme)
  3. ekluzek commented on Apr 10, 2026

    @ekluzek
    Contributor

    It looks like the changes for roughness came in by Meir, so this part maybe done.

    The snow changes may need additions. Although a lot of that is given in a different section, so it's just what's different there that needs to be talked about.

  4. slevis-lmwg commented on Apr 10, 2026

    @slevis-lmwg
    ContributorAuthor

    Regarding the snow thermal conductivity changes, I'm making updates as per this comment:
    #3068 (comment)
    For now I will assume that's sufficient.

  5. ekluzek commented on Apr 10, 2026

    @ekluzek
    Contributor

    There's a section on changes since CLM4 that should just be removed.

  6. olyson commented on Apr 10, 2026

    @olyson
    Contributor

    It looks like the changes for roughness came in by Meir, so this part maybe done.

    I put in the lake roughness changes per this PR: #2134

  7. added a commit that references this issue on May 5, 2026
  8. moved this from Todo to In Progress in CLM documentationon May 6, 2026
  9. slevis-lmwg commented on May 21, 2026

    @slevis-lmwg
    ContributorAuthor

    @nmizukami
    I just wanted to bring to your attention a comment by @huiqi-wang that there are missing equation references in the "lake" section of the Technote, since you're making revisions:
    #3818 (comment)

  10. nmizukami commented on May 28, 2026

    @nmizukami
    Contributor

    @nmizukami I just wanted to bring to your attention a comment by @huiqi-wang that there are missing equation references in the "lake" section of the Technote, since you're making revisions: #3818 (comment)

    thank you @slevis-lmwg, I went through the lake tech note and I believe I have filled all the missing equation references as I went through Keith comments.

  11. moved this from In Progress to Done pending master merge in CLM documentationon Jun 3, 2026
  12. moved this from Done pending master merge to Done in CLM documentationon Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

docs-loc:tech-noteRelates to Technical Note (science)documentationadditions or edits to user-facing documentation or its infrastructure

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions