Repository navigation
Regional CTSM Simulations and Capability of Creating Mesh Files #1892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
216 commits
Select commit
Hold shift + click to select a range
0ccf855
a first draft of implementing xarray mesh
negin513 c3d981d
subset_mesh capabilities
negin513 66f46c3
a few changes
negin513 29ed6fa
clean ups
negin513 9155ec8
adding write shell commands
negin513 18c9ca7
clean ups
negin513 b8c9115
adding bound checks
negin513 7682185
adding w/e s/n instead of start/end to help
negin513 60b232f
lnd for land_domain_mesh
negin513 6aef680
saving progress for old debugging
negin513 88ed680
working mesh type class
negin513 8e88f66
mesh_maker
negin513 dd7f5b8
mesh_maker
negin513 1a31153
update subset_data to use the new mesh type
negin513 d315d2b
clean ups...
negin513 527cdc0
update namelist
negin513 947b768
fixing a few issues
negin513 c0c6aa9
updates
negin513 3f47819
black-ify the code
negin513 ca2d2da
final edits
negin513 9ec631b
updates
negin513 d9acef0
updates
negin513 07270a9
updates to subset_data
negin513 734854a
updating readme.
negin513 b35d76b
update README
negin513 56cdbae
updates to mesh file type to plot
negin513 075e6c0
updating mesh_type -- working...
negin513 a3199f1
plotting capabilities
negin513 8ef1a08
adding high res as default
negin513 e7826c2
high res as default
negin513 129492f
blackify
negin513 8c8279b
extra comments
negin513 2816f95
quick updates
negin513 f614b60
efficient plotting for regions
negin513 796bdea
quick clean ups
negin513 fcb3405
pylint
negin513 0b6dc1d
pylint issues
negin513 ae82c84
pylint complaints
negin513 05e8fac
pylint valid names such as ax
negin513 3588342
pylint complaints
negin513 24d3446
Merge branch 'master' into subset_mesh_dask
negin513 38352a8
formatting
negin513 543e424
fix bug with CLM_USRDAT_DIR
negin513 ded39a6
Merge tag 'ctsm5.1.dev115' into subset_mesh_dask
ekluzek 260ecb6
Add dask, cartopy, and matplotlib to the list of packages for conda, …
ekluzek 2d41803
Merge tag 'ctsm5.1.dev116' into subset_mesh_dask
ekluzek 304c83e
Update needed to get unit tests to work due to update
ekluzek 8a510c2
Change needed for update
ekluzek 13d1c99
Add a test that create-user-mods requires create_mesh for regional cases
ekluzek fc262d4
Get test for create_user_mods without create_mesh working correctly, …
ekluzek 8918db2
for region test turn mesh on and user-mods
ekluzek 3ee9f05
Add a single point test that is working for mesh_maker.py
ekluzek 3a31fd2
Correct area
ekluzek 2608097
Move the guts of mesh_maker to the python directory
ekluzek c10a689
Run through black
ekluzek 7f69e00
Add a basic unit test for mesh_maker
ekluzek 050a87b
Add a failing test for outdir and outfile at the same time
ekluzek e5e7c66
Get test to work, but moving it up earlier
ekluzek 3b41bdb
Add test for overwrite that fails
ekluzek 82df585
Fix the overwrite test
ekluzek 2023c14
Run through black and get unit tests working again
ekluzek 0647e76
Some important changes moved over from subset_data that allow mesh_ma…
ekluzek ad8ce53
Update subset_data regions and tests
ekluzek 6592810
Change name of one of the regional tests
ekluzek 4ff8e7d
Fix some mesh_maker pylint issues
ekluzek 98a6994
Use ctsm_logging and add a non working option to turn off plots
ekluzek 96ef2fd
Add check_args for mesh_maker to shorten length of main and fix more …
ekluzek 7fbdb0c
Add a check that arguments get changed as expected
ekluzek 013954b
Change name of subroutine
ekluzek 1baf7c5
Start adding a system test for mesh_maker to check file data
ekluzek 991082e
Merge tag 'ctsm5.1.dev117' into subset_mesh_dask
ekluzek d4f9f4c
Merge tag 'ctsm5.1.dev118' into subset_mesh_dask
ekluzek 9426cab
Merge remote-tracking branch 'escomp/master' into subset_mesh_dask
ekluzek 9dc6759
Bunch of work at starting to use conda-lock to save actual running en…
ekluzek ddfd18d
If condalock doesn't exist and you are reading the lock file, install…
ekluzek 79d587e
Add a bit about installing the conda environment for condalock for cg…
ekluzek a6c1c63
Correct a bit about the condalock environment
ekluzek 661ce46
Specifying each version seems to give a stable conda environment that…
ekluzek f119fee
Split into conda environment into multiple files to accomidate CGD vs…
ekluzek a3d8d09
Update the note about the time it takes to run and the read-spec option
ekluzek ede71a9
Add some comments about running without adding dask
ekluzek dbfed73
Remove all the conda-lock handling stuff for the py_env_create
ekluzek 9b7c468
bring in comment about dask
ekluzek 60080a3
Add a read-latest option so that the experiemental latest environment…
ekluzek cde8ea9
Add a message that if the --read-spec option fails to try it without it
ekluzek 874c846
Change so the dask option is NOT on by default and comes with warning…
ekluzek a77df59
Remove the possibility of turning the dask option with the latest opt…
ekluzek 3e283a0
Remove dask and plotting from the latest requirements file, and updat…
ekluzek 8a2bf5c
Change the name of the conda environment if you are going to build wi…
ekluzek ac7f231
dask ProgressBar was not being used
ekluzek ac70d06
Make the language stronger about dask being experimental
ekluzek a559d94
Add some black only reformatter commits
ekluzek f46bfcd
Add more black commits to the git-blame-ignore-revs file
ekluzek 8879806
Add workflow to run conda environments
ekluzek c2fc9d1
Add documentation about requirements for python packaages
ekluzek ca4bca8
Add python testing action
ekluzek 676207e
Add load of conda environments before each make step
ekluzek 00804ca
Update python testing workflow
ekluzek 9dc7818
More on activating the conda environment in the github action
ekluzek 6b579d6
Change trigger to close of a PR for conda environments, because these…
ekluzek cf1a789
Fix conda environment file to use for python testing
ekluzek 726709c
Use the conda base environment for the action
ekluzek 42bc386
Correct event type
ekluzek 6ec7609
Add -l option to shell for action
ekluzek b85f3be
Add stuff for git lfs
ekluzek 11e35c0
More messing with github actions
ekluzek cddd07a
Fix yaml syntax
ekluzek 03624da
Change workflow to use dask conda environment so that test will work …
ekluzek d89eeaf
Correct env name
ekluzek c4cb1fb
Set some needed cime variables for python testing, and attempt to cre…
ekluzek d0d6385
Remove the attempt at creating inputdata directory
ekluzek f8de262
Add a github action to run python testing on the latest package pytho…
ekluzek 83443db
Add a test for trying out the mask and area option -- currently fails
ekluzek 4e30039
Add a mkdir with sudo on the runner
ekluzek 47b3224
Fix the area and mask options, needed a dask conversion and save only…
ekluzek e59cb89
Run in black and add test for non existant file
ekluzek 08df74b
Add a test for bad names for latitude and longitude and get them working
ekluzek ba49e3e
Add a failing test for bad names for area and mask
ekluzek 44d356d
Check if area and mask variable name exists so now sys tests pass
ekluzek 822eec4
Add a failing tests for bad units of the area variable the user gives…
ekluzek 015aa7d
Get area units fail test working with new error, now the area test fa…
ekluzek 8cc3ac0
Add a regional test that fails because of the use of the 2D LATIXY, L…
ekluzek 60a0079
Get the region test working, so now LATIXY and LONGXY can be used for…
ekluzek 23f8823
Add a test for area with domain 5x5 file, and add a change to get are…
ekluzek 76a43a6
Add a test for a domain regional file and compare it to the baseline …
ekluzek 8dcd6ca
After working with @adrifoster I was able to an initial removal of da…
ekluzek 6d96575
Add some more checks so can tell what is different in the mesh file
ekluzek 72c16af
Make the file comparison it's own subroutine so could be called more …
ekluzek 84b1537
Add back the drop_duplicates and setting of both clon, clats as in th…
ekluzek 584fe5c
Run through black
ekluzek 36f7287
Add black commit to git-blame list
ekluzek 26654e2
Merge tag 'ctsm5.1.dev120' into subset_mesh_dask
ekluzek accd4d7
Add advanced tests for the advanced conda environment ctsm_pylib_wdask
ekluzek 3c348b2
Add advanced tests for the advanced conda environment ctsm_pylib_wdask
ekluzek 4dec1ba
Seperate mesh plotting capability into a type that extends the base m…
ekluzek 3b92cd1
Fix some pylint issues
ekluzek cc0b6b3
Disable a pylint warning since it's really in the base cartopy code a…
ekluzek c898b3b
Clear up a bunch of pylint issues
ekluzek 4992ab2
Check for plot files in the test
ekluzek c1c4e74
Check that plot files were created
ekluzek 10e07cd
Get the no-plot option working by moving the plot creation to the end…
ekluzek 1e8f485
Move some of the checking into it's own subroutine, allow more init s…
ekluzek 87291aa
Set input file to real file so it doesn't die early in test
ekluzek 44de6e5
Move plot into a subroutine that can be used for both the regional an…
ekluzek 3ca9293
Add tools/site_and_regional/subset_data_single_point directory to the…
ekluzek 7eadb64
Add mesh plot files to list of git ignore
ekluzek f7ea704
Make line size and marker size smaller for meshes with lots of points
ekluzek 53b886a
Update tests to use regional file, and add a test that expects single…
ekluzek d04d7fc
Add a test for missing units for area
ekluzek 0c36a80
Get tests working
ekluzek 974e7a5
Add mesh test for f09 resolution
ekluzek 6278717
Remove the single point mesh test
ekluzek 172a149
Start adding a test that reads in a mesh and then outputs it to make …
ekluzek 349e779
Add a method to check if data is set and die when it's not
ekluzek 6d5026f
Start adding checking to the read_file to ensure can properly read th…
ekluzek 8d7d69c
Add a unit test for mesh_type
ekluzek e079deb
More work on new mesh_type unit test
ekluzek 37ca37a
Add check for bad list of variables
ekluzek c0281e6
Start getting data, when writing, check if optional data should be ou…
ekluzek 787c1ab
Get the read_file method working, test still fails because origGridRa…
ekluzek d7b146f
All tests working remove some unneeded prints
ekluzek b8ae289
Move area to earlier so can be gotten from read_file as well as from …
ekluzek 98e5bcc
Spin off plotting into it's own script, start moving things around fo…
ekluzek 143766f
Get all python tests working including adv_test
ekluzek 683df02
Get make all working with the ctsm_pylib environment, don't require c…
ekluzek 01d7ac5
Remove plotting
ekluzek 56662fa
Remove test with dask, and add some to make sure it exits with an error
ekluzek c2c1af4
Adjust testing so on a schedule that will be weekly for advanced test…
ekluzek b61dea2
Add a test that fails for converting the f10 domain file to a mesh
ekluzek f551027
Abort if you try to run for a global grid, change the test for this
ekluzek 7ed54ef
remove global mesh since can't work for this case
ekluzek 75d687c
Make sure subset_data regional tests have both create-domain and crea…
ekluzek eadde43
Merge tag 'ctsm5.1.dev125' into subset_mesh_dask
ekluzek d63c4b7
Add a test for South America region which has ocean and land in it
ekluzek 6f2b9f0
Compare the S America region mesh file and make sure it agrees with t…
ekluzek 3ef7c55
Get the South America region working for the mesh file using the surf…
ekluzek c8b8114
Verbose is required for the testing to recognize that the test was su…
ekluzek 3d47d65
Add user mod directory for the PanBoreal case that Jackie used to run…
ekluzek 19d835d
Add test for regional grid created with subset_data
ekluzek 3ecddf3
Run through black
ekluzek 5b10fe1
Add unit test that fails that makes sure create-mesh is used with cre…
ekluzek 01cb5cd
Get test to work by making sure create_mesh also has create_domain on
ekluzek 812b308
Have PanBoreal not go all the way up to the North pole, but just a gr…
ekluzek f23df5f
Make sure corners for a mesh don't go beyond the bounds of the globe …
ekluzek 716f1dd
Remove logic about global grid, it's now handled by limiting the grid…
ekluzek 711e76f
Move create_mesh to inside the create_domain, and make sure mask is set
ekluzek 7840517
Update domain file position variable names
ekluzek 39c75c2
Change mesh filename to be based on domain filename
ekluzek e284f34
Have longitudes for corners stay within 0 to 360
ekluzek 9d8f42f
Correct name of grid size for regional test grid
ekluzek a399cf1
Fix size for PanBoreal
ekluzek ec92580
Abort if corners have longitudes greater than 360, and give warning f…
ekluzek 1d002f0
Start adding for a new argument for subset_data to give the year of t…
ekluzek 5c70da4
Add a test to confirm you can't create a domain file for a single poi…
ekluzek 3f685e2
Remove create_domain as an option for single point, remove test for i…
ekluzek ebb180e
Get all tests working
ekluzek c5b1de0
Add failing tests that --create-landuse option requires --create-surf…
ekluzek 0be506d
Get tests to work
ekluzek 88bcc05
Instead of using conda activate use conda run as discovered by @samrabin
ekluzek 5136c31
Merge tag 'ctsm5.1.dev129' into subset_mesh_dask
ekluzek b7d3780
remove some git workflow things; also dask
adrifoster ccaec33
add plotting; remove other conda env files
adrifoster 95a35d6
Merge branch 'master' into subset_mesh
adrifoster 6c138bd
fix comment typos
e36dc8b
add ny/nx
adrifoster a1f77a5
Merge branch 'master' into subset_mesh
adrifoster 3cdcf8f
move create-domain back into single point for now
adrifoster 4b32a31
black updates
adrifoster f582829
more black updates
adrifoster 2091051
update tests
adrifoster 7711245
merge in master
adrifoster 0ab92ee
Merge branch 'b4b-dev' into subset_mesh_dask
adrifoster 5f19b53
building md too
negin513 8c8d02c
adding instructions
negin513 43fb1d5
remove extra argument
adrifoster 3638bbd
remove argument definitions
adrifoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
cime_config/usermods_dirs/f09_37x288pt_PanBoreal/shell_commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
|
|
||
| # Change below line if you move the subset data directory | ||
|
|
||
| ./xmlchange CLM_USRDAT_DIR='$DIN_LOC_ROOT/lnd/clm2/regional_datasets/f09_38x288pt_PanBoreal' | ||
|
|
||
| ./xmlchange ATM_DOMAIN_MESH='$CLM_USRDAT_DIR/domain.lnd.fv0.9x1.25_gx1v7_f09_38x288pt_PanBoreal_c230524_ESMF_UNSTRUCTURED_MESH.nc' | ||
| ./xmlchange LND_DOMAIN_MESH='$CLM_USRDAT_DIR/domain.lnd.fv0.9x1.25_gx1v7_f09_38x288pt_PanBoreal_c230524_ESMF_UNSTRUCTURED_MESH.nc' | ||
| ./xmlchange MASK_MESH='$CLM_USRDAT_DIR/domain.lnd.fv0.9x1.25_gx1v7_f09_38x288pt_PanBoreal_c230524_ESMF_UNSTRUCTURED_MESH.nc' |
22 changes: 22 additions & 0 deletions
22
cime_config/usermods_dirs/f09_37x288pt_PanBoreal/user_nl_clm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| !---------------------------------------------------------------------------------- | ||
| ! Users should add all user specific namelist changes below in the form of | ||
| ! namelist_var = new_namelist_value | ||
| ! | ||
| ! EXCEPTIONS: | ||
| ! Set use_cndv by the compset you use and the CLM_BLDNML_OPTS -dynamic_vegetation setting | ||
| ! Set use_vichydro by the compset you use and the CLM_BLDNML_OPTS -vichydro setting | ||
| ! Set use_cn by the compset you use and CLM_BLDNML_OPTS -bgc setting | ||
| ! Set use_crop by the compset you use and CLM_BLDNML_OPTS -crop setting | ||
| ! Set spinup_state by the CLM_BLDNML_OPTS -bgc_spinup setting | ||
| ! Set co2_ppmv with CCSM_CO2_PPMV option | ||
| ! Set fatmlndfrc with LND_DOMAIN_PATH/LND_DOMAIN_FILE options | ||
| ! Set finidat with RUN_REFCASE/RUN_REFDATE/RUN_REFTOD options for hybrid or branch cases | ||
| ! (includes $inst_string for multi-ensemble cases) | ||
| ! or with CLM_FORCE_COLDSTART to do a cold start | ||
| ! or set it with an explicit filename here. | ||
| ! Set maxpatch_glc with GLC_NEC option | ||
| ! Set glc_do_dynglacier with GLC_TWO_WAY_COUPLING env variable | ||
| !---------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| fsurdat = '$CLM_USRDAT_DIR/surfdata_f09_38x288pt_PanBoreal_hist_16pfts_Irrig_CMIP6_simyr2000_c230523.nc' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # Creating an ESMF mesh file from a netCDF file | ||
|
|
||
| This gist includes instructions for creating and visualizing a mesh file from a netcdf file with valid 1D or 2D lats and lons coordinates. | ||
|
|
||
| * **ESMF Mesh file** aka **Unstructured Grid File Format** is a netcdf file (format) that includes the information about the grids coordinates and their connectivity to each other. | ||
|
|
||
| Additional information about ESMF mesh files are available [here](https://earthsystemmodeling.org/docs/release/ESMF_8_0_1/ESMF_refdoc/node3.html#SECTION03028200000000000000). | ||
|
|
||
| ------ | ||
|
|
||
| In this example, we will use `./mesh_maker.py` which uses `mesh_type.py` to create a mesh file and visualize it. | ||
|
|
||
| 1- First clone my fork and branch that includes these capabilities: | ||
| ``` Shell | ||
| git clone https://github.com/negin513/ctsm.git ctsm_mesh | ||
| cd ctsm_mesh | ||
|
|
||
| git checkout subset_mesh_dask | ||
| ``` | ||
|
|
||
| 2- Next run mesh_maker.py for a netcdf file: | ||
|
|
||
| ``` | ||
| cd tools/site_and_regional | ||
| ``` | ||
| Check all the avaialble options: | ||
|
|
||
| ``` | ||
| ./mesh_maker.py --help | ||
| ``` | ||
|
|
||
| The output shows all available options for this script: | ||
| ``` | ||
| |------------------------------------------------------------------| | ||
| |--------------------- Instructions -----------------------------| | ||
| |------------------------------------------------------------------| | ||
| This script creates ESMF unstructured GRID (mesh file) from a netcdf | ||
| file with valid lats and lons. Provided lats and lons can be 1D or 2D. | ||
|
|
||
| For example for running WRF-CTSM cases, the user can create a mesh | ||
| file for their domain : | ||
| ./mesh_maker.py --input wrfinput_d01 --output my_region | ||
| --lat XLAT --lon XLONG --verbose | ||
|
|
||
| optional arguments: | ||
| -h, --help show this help message and exit | ||
| --input INPUT Netcdf input file for creating ESMF mesh. | ||
| --output OUTPUT Name of the ESMF mesh created. | ||
| --outdir OUT_DIR Output directory (only if name of output mesh is not | ||
| defined) | ||
| --lat LAT_NAME Name of latitude varibale on netcdf input file. If none | ||
| given, looks to find variables that include 'lat'. | ||
| --lon LON_NAME Name of latitude varibale on netcdf input file. If none | ||
| given, looks to find variables that include 'lon'. | ||
| --mask MASK_NAME Name of mask varibale on netcdf input file. If none given, | ||
| create a fake mask with values of 1. | ||
| --area AREA_NAME Name of area variable on netcdf input file. If none given, | ||
| ESMF calculates element areas automatically. | ||
| --overwrite If meshfile exists, overwrite the meshfile. | ||
| -v, --verbose Increase output verbosity | ||
|
|
||
| ``` | ||
|
|
||
| Let's create a mesh file from a netcdf file with 1D lats and lons. On the sample files provided 1D lat and long coordinates are saved on `lsmlat` and `lsmlon` variables. | ||
|
|
||
| ``` | ||
| ./mesh_maker.py --input /glade/scratch/negins/example_files/surfdata_4x5_hist_78pfts_CMIP6_simyr1850_275.0-330.0_-40-15_c220705.nc --output test_mesh_1d.nc --lat lsmlat --lon lsmlon --overwrite | ||
| ``` | ||
| `--verbose` option also provide additional information for debugging. | ||
|
|
||
| This script will create regional and global mesh plots. For example for the above files, the plos are: | ||
| test_mesh_1d_regional.png | ||
|  | ||
|
|
||
|
|
||
| test_mesh_1d_global.png | ||
|
|
||
|  | ||
|
|
||
|
|
||
|
|
||
| ------ | ||
| ## Creating Mesh files for a WRF domain: | ||
| For running WRF-CTSM cases, we need to create ESMF mesh files for the WRF domain. We can create mesh file from wrfinput (wrf initial condition files). wrfinput has 2D coordinate information on `XLAT` and `XLONG` variable. | ||
|
|
||
| For example, let's create a mesh file from a WRF input file for WRF-CTSM run. | ||
| ``` | ||
| ./mesh_maker.py --input /glade/scratch/negins/example_files/wrfinput_d01 --output test_mesh_wrf.nc --lat XLAT --lon XLONG --overwrite | ||
| ``` | ||
|
|
||
| This produce mesh files for running for our WRF domain. | ||
|
|
||
| Here is how the regional plot looks like for this mesh file: | ||
|
|
||
|  | ||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| .. sectnum:: | ||
|
|
||
| .. contents:: | ||
|
|
||
| ===================================================================================== | ||
| Requirements to consider for python packages to be included for CTSM python tools | ||
| ===================================================================================== | ||
|
|
||
| Requirements for CTSM python tools: | ||
|
|
||
| Any added dependencies should be discussed and approved by the CTSM-software team. Criteria for evaluation of third-party packages | ||
| include: | ||
| - How much value does this package provide to us beyond what we could get without it? | ||
| - How difficult it is to install this package (including: how much does this complicate / slow down the creation of the conda | ||
| environment)? | ||
| - How stable is this package? | ||
| - How well maintained is this package? | ||
| - Are there other packages that are more stable or better maintained that would provide nearly the same level of value? | ||
| - Tools that require extra packages should be done in a "contrib" type area out of the main part of tools (this would apply for | ||
| advanced plotting capability for example) | ||
| - We need to be able to reproduce working conda environments minimally on our test machines (currently cheyenne and izumi), but also | ||
| on any machine that we run CTSM on. If there is a machine that we can run CTSM on that we can't build the conda environments or run | ||
| the tools on -- that needs to be fixed. | ||
| - We need to tell the user how long to expect the conda environment to load, and give them options if the conda load is taking too | ||
| long | ||
| - Conda environments need to build robustly even for users who don't have ctsm_pylib loaded in their conda environment | ||
| - Currently dask will NOT be something we require for any of the main CTSM tools | ||
| - Currently we won't use conda-lock | ||
| - We specify the black version exactly so that black will function identically for all users | ||
| - We specify the pylint version exactly because pylint is finicky with version and we need it to work identically for all developers | ||
| - We might remove the need for python packages that aren't providing enough utility | ||
| Packages where specific versions seem to be required will have the version requirements in a least the >= form if not an exact | ||
| version |
|
adrifoster marked this conversation as resolved.
Resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.