Skip to content

Preparing alpha-ctsm5.2.mksrf.16_ctsm5.1.dev123 tag - #2016

Merged
slevis-lmwg merged 6 commits into
ESCOMP:ctsm5.2.mksurfdatafrom
slevis-lmwg:alpha-ctsm5.2.mksrf.16
Jun 22, 2023
Merged

slevis-lmwg merged 6 commits into
ESCOMP:ctsm5.2.mksurfdatafrom
slevis-lmwg:alpha-ctsm5.2.mksrf.16

Conversation

@slevis-lmwg

@slevis-lmwg slevis-lmwg commented Jun 5, 2023 •

Copy link
Copy Markdown
Contributor

Description of changes

Large changes to namelist_defaults_ctsm.xml.
Changes to various other files, mainly for consistency.

Attribution of work:
The original modifications to namelist_defaults_ctsm.xml related to the development of the new mksurfdata_esmf tool were done by @mvertens, as was the original development of the new mksurfdata_esmf tool itself.

Specific notes

Contributors other than yourself, if any:
@ekluzek @mvertens

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?
Yes, because we are generating new fsurdat and landuse files.

Any User Interface Changes (namelist or namelist defaults changes)?
Large changes to namelist_defaults_ctsm.xml.

Testing performed, if any:

  • mksurfdata_esmf has been working to generate new fsurdat and landuse files.
  • My branch's cheyenne test-suite mostly worked, and I documented most of the failures in this corresponding issue's post.

- mapping files removed
- T31 (48x96) removed
- new files found in lnd/clm2/surfdata_esmf/ctsm5.2.0
Also update for consistency:
- modify_fsurdat.py to not look for PFTDATA_MASK in new fsurdat
- /python/ctsm/test/testinputs fsurdat files
- /python/ctsm/test/testinputs .cfg files
- tools/mksurfdata_esmf/gen_mksurfdata_jobscript_multi.py
@slevis-lmwg
slevis-lmwg requested a review from ekluzek June 5, 2023 21:03
@slevis-lmwg slevis-lmwg self-assigned this Jun 5, 2023
@slevis-lmwg slevis-lmwg linked an issue Jun 5, 2023 that may be closed by this pull request
8 tasks done
@@ -1,2 +1,2 @@
flanduse_timeseries = '$DIN_LOC_ROOT/lnd/clm2/surfdata_map/landuse.timeseries_4x5_hist_simyr1850-2015_200311.nc'
flanduse_timeseries = '$DIN_LOC_ROOTlnd/clm2/surfdata_esmf/ctsm5.2.0/landuse.timeseries_10x15_hist_78_CMIP6_1850-2000_c230517.nc'

@slevis-lmwg slevis-lmwg Jun 5, 2023 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes to self:

  • Typo: Need /lnd instead of lnd

@slevis-lmwg

Copy link
Copy Markdown
Contributor Author

@ekluzek in this morning's Stand-up, you requested info on the new (i.e. ctsm5.2) 1-degree fsurdat and landuse files. I have opened this PR to share all the new fsurdat and landuse files. As we discussed, the list will continue to be updated over the next few weeks as needed.

@slevis-lmwg

Copy link
Copy Markdown
Contributor Author

@ekluzek in this morning's Stand-up, you requested info on the new (i.e. ctsm5.2) 1-degree fsurdat and landuse files. I have opened this PR to share all the new fsurdat and landuse files. As we discussed, the list will continue to be updated over the next few weeks as needed.

In a meeting today with @ekluzek and @wwieder we decided that I should merge this PR as is (after wrapping up with the test-suite), so that @ekluzek may proceed with the makefile.data work.

@slevis-lmwg

slevis-lmwg commented Jun 22, 2023 •

Copy link
Copy Markdown
Contributor Author

Two tests still FAIL on cheyenne:

LWISO_Ld10.f10_f10_mg37.I2000Clm50BgcCrop.cheyenne_gnu.clm-coldStart
ERP_P36x2_D_Ld5.f10_f10_mg37.I2000Ctsm50NwpBgcCropGswp.cheyenne_intel.clm-default

The error messages seem to me harder to resolve, though I wonder if they arise from inconsistencies between the surface (new) and initial (old) data.

@ekluzek before I spend too much time on these, it would be helpful to discuss, in case you have insights and/or we decide that I should merge the PR without resolving these two. Also, I just submitted the izumi test-suite, so I will look at results tomorrow.

The test now passes:
ERP_P36x2_D_Ld5.f10_f10_mg37.I2000Ctsm50NwpBgcCropGswp.cheyenne_intel.clm-default
@slevis-lmwg

slevis-lmwg commented Jun 22, 2023 •

Copy link
Copy Markdown
Contributor Author

@ekluzek and I met about the test-suite results and agreed the following:
LWISO_Ld10.f10_f10_mg37.I2000Clm50BgcCrop.cheyenne_gnu.clm-coldStart: ok to let fail for now; TODO open issue, ask @billsacks for insights

ERP_P72x2_Ld30.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-mimicsFatesCold SHAREDLIB_BUILD failed to initialize (UNEXPECTED: expected PEND): Error message is

DON'T use the '-fire_emis' option when '-bgc fates' is activated
Add -ignore_warnings option to CLM_BLDNML_OPTS to ignore this warning

I see it as least disruptive to add -ignore_warnings to the testmod directory; the test now works. I included a corresponding note in the testmod's README.

LII2FINIDATAREAS_D_P72x2_Ld1.f09_g17.I1850Clm50BgcCrop.cheyenne_intel.clm-default: init_interp_method requires identical grid; ok to let fail for now; TODO create new finidat file
LII_D_Ld3_PS.f19_g17.I2000Clm50BgcCrop.cheyenne_intel.clm-default: case1 completes but case2 needs use_init_interp=.true.
PFS_Ld10_PS.f19_g17.I2000Clm50BgcCrop.cheyenne_intel: completes with use_init_interp=.true.
SMS_Lm13_PS.f19_g17.I2000Clm51BgcCrop.cheyenne_intel.clm-cropMonthOutput: completes with use_init_interp=.true.

To run the izumi test-suite, I rimported necessary datasets, because I do not have appropriate permissions to copy the files to izumi. I added a README in the directory containing the files on cheyenne
/glade/p/cesmdata/cseg/inputdata/lnd/clm2/surfdata_esmf/ctsm5.2.0
so as to keep track of which files have already been rimported.

Izumi test-suite OK

to get past this error
DON'T use the '-fire_emis' option when '-bgc fates' is activated
in the test
ERP_P72x2_Ld30.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-mimicsFatesCold
@slevis-lmwg
slevis-lmwg marked this pull request as ready for review June 22, 2023 21:46
@slevis-lmwg
slevis-lmwg merged commit e8dd1eb into ESCOMP:ctsm5.2.mksurfdata Jun 22, 2023
@slevis-lmwg
slevis-lmwg deleted the alpha-ctsm5.2.mksrf.16 branch June 22, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

1 participant