Skip to content

[WIP] Refactoring Run_neon for PLUMBER2 - #2259

Closed
TeaganKing wants to merge 4 commits into
ESCOMP:masterfrom
TeaganKing:refactoring
Closed

TeaganKing wants to merge 4 commits into
ESCOMP:masterfrom
TeaganKing:refactoring

Conversation

@TeaganKing

Copy link
Copy Markdown
Contributor

Description of changes

  • 1. Remove unused functions and arguments
  • 2. Move arg_parse to its own file and NeonSite to own file
  • 3. Unit tests for arg_parse and NeonSite

Additional (not-yet-ordered) expected changes:

  • Build abstract TowerSite class
  • Generic class
  • Add NEON class with NEON-specific behavior
  • Create new methods and unit tests
  • Add PLUMBER class and behaviors
  • Integration testing
  • Create a script that programmatically builds shell_commands and user_nl files

Contributors other than yourself, if any:
@ekluzek @adrifoster

Some additional resources

https://docs.google.com/document/d/19QAvUSJY0QJdFF5LrOFhU0JVhfT3QwvFQaf8IiPtXxU/edit#heading=h.cyie9ucyj2pr
https://docs.google.com/document/d/1i57JZgu6vWtdvr8rNMEnrtNIMIl8hB4jUeE4UvxNh38/edit

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No. This will work towards supporting additional tower sites.

Note, this is currently a very preliminary WIP PR-- I'm just getting thoughts together at the moment for ease of discussion.

@TeaganKing TeaganKing self-assigned this Nov 16, 2023
@wwieder

wwieder commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Great to see this @TeaganKing . Just one note that this script builds usermod_dirs for PLUMBER (your last bullet point). It's part of #2155

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability PR status: work in progress labels Nov 16, 2023
@TeaganKing TeaganKing mentioned this pull request Jan 11, 2024
3 tasks done
@TeaganKing

Copy link
Copy Markdown
Contributor Author

Closing this PR because I opened #2315 instead...

@TeaganKing TeaganKing closed this Jan 11, 2024
@TeaganKing
TeaganKing deleted the refactoring branch February 1, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants