Skip to content

NEONv3 updates - #2314

Closed
wwieder wants to merge 1 commit into
ESCOMP:masterfrom
wwieder:NEON_v3_Derecho
Closed

wwieder wants to merge 1 commit into
ESCOMP:masterfrom
wwieder:NEON_v3_Derecho

Conversation

@wwieder

@wwieder wwieder commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

Description of changes

Updates so that run_neon works with the latest tag on derecho. Additional modifications to use NEON_v3 data, but these may not be critical right now.

Specific notes

Out of the box run_neon is broken.

import time
import pandas as pd

from standard_script_setup import *

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is really the only line that has to change for the script to work, but it also likely needs to be fixed in black, to prevent it from being moved again. Not sure if there's another tag in the queue where this fix could come in...?

@wwieder

wwieder commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

@slevis-lmwg and @ekluzek, we decided not to include this PR right now. Can we convert to draft for now (or should we close the PR with a won't fix?)

@slevis-lmwg
slevis-lmwg marked this pull request as draft January 23, 2024 17:03
@wwieder

wwieder commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

PS #2315 should fix the issue with run_neon so that it runs out of the box.

@wwieder

wwieder commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

As such, I'm going to close this with a won't fix, as more robust modifications are needed to support NEON v3 data for the CLM6 release.

@wwieder wwieder added the closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix label Jan 23, 2024
@wwieder wwieder closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant