Repository navigation
NEONv3 updates - #2314
Closed
wwieder wants to merge 1 commit into
Closed
NEONv3 updates#2314wwieder wants to merge 1 commit into
wwieder wants to merge 1 commit into
Conversation
wwieder
commented
Jan 11, 2024
| import time | ||
| import pandas as pd | ||
|
|
||
| from standard_script_setup import * |
Contributor
Author
There was a problem hiding this comment.
I think this is really the only line that has to change for the script to work, but it also likely needs to be fixed in black, to prevent it from being moved again. Not sure if there's another tag in the queue where this fix could come in...?
Contributor
Author
|
@slevis-lmwg and @ekluzek, we decided not to include this PR right now. Can we convert to draft for now (or should we close the PR with a won't fix?) |
slevis-lmwg
marked this pull request as draft
January 23, 2024 17:03
Contributor
Author
|
PS #2315 should fix the issue with run_neon so that it runs out of the box. |
Contributor
Author
|
As such, I'm going to close this with a won't fix, as more robust modifications are needed to support NEON v3 data for the CLM6 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates so that run_neon works with the latest tag on derecho. Additional modifications to use NEON_v3 data, but these may not be critical right now.
Specific notes
Out of the box run_neon is broken.