Repository navigation
Merge tag: Turn on meier2022 and bring in #2212 - #2323
Conversation
|
The first test-suite listed above fails in clm45/clm50 tests because the corresponding params files do not include the Meier2022 parameters. I'm pretty sure that we never intended to add the Meier2022 parameters to the clm45/clm50 params files because Meier2022 was intended for ctsm5.1. Since there are no issues of backwards compatibility, I think we have nothing to prove even if we could show that Meier2022 works with clm45/clm50 tests. I propose not making temporary clm45/clm50 params files to test whether Meier2022 works with these models. I can bring this up for discussion at tomorrow's software meeting. |
|
Group decisions (2024/1/18 software meeting)
|
|
@rgknox I'm preparing the next tag (dev165) and wanted to ask you about this test: |
|
@samsrabin this should be a 10-minute review to confirm that I haven't missed anything in this PR. Let me know if you prefer to meet and go over stuff together. |
|
Test-suites |
|
The tillage and residue removal stuff look good to me! |
Description of changes
Answer-changing merge-tag:
Specific notes
Contributors other than yourself, if any:
@olyson @samsrabin
CTSM Issues Fixed (include github issue #):
Fixes #2212
Are answers expected to change (and if so in what way)?
Yes, for ctsm5.1 cases by making Meier2022 on, tillage low, and residue removal 0.5 by default.
Yes, for clm45/clm50 by including the #2212 fix.
Any User Interface Changes (namelist or namelist defaults changes)?
Making Meier2022 the default for ctsm5.1 again.
Making tillage low by default for ctsm5.1.
Making residue removal 0.5 by default for ctsm5.1.
Testing performed, if any: