Repository navigation
run_sys_tests: Check Python environment for FatesColdTwoStream tests - #2326
Merged
slevis-lmwg merged 11 commits intoJan 25, 2024
Merged
Conversation
samsrabin
marked this pull request as ready for review
January 19, 2024 18:00
samsrabin
commented
Jan 22, 2024
Member
Author
|
@ekluzek Done! |
Merged
samsrabin
added a commit
to samsrabin/CTSM
that referenced
this pull request
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
FatesColdTwoStreamandFatesColdTwoStreamNoCompFixedBioGeotests use the$FATESDIR/tools/modify_fates_paramfile.pyscript, which requires certain non-standard Python packages. Now,run_sys_testswill check for the availability of those packages.Specific notes
Uses existing
_try_systemtests()function (now generalized and renamed_check_py_env()).Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): n/a
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Testing performed, if any:
Unloaded all modules on Izumi and tried to submit
run_sys_testsusing-s,-f, and-targuments that requested those tests. It successfully errors, saying:It also works on Derecho.
blackandpylintpass.