Skip to content

Remove include_user_mods from matrixcnOn testmod - #2815

Merged
samsrabin merged 6 commits into
ESCOMP:masterfrom
samsrabin:matrixcnon-no-include
Oct 15, 2024
Merged

samsrabin merged 6 commits into
ESCOMP:masterfrom
samsrabin:matrixcnon-no-include

Conversation

@samsrabin

Copy link
Copy Markdown
Member

Should avoid unnecessary levels of history writing.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? Only for our tests.

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: None yet.

Should avoid unnecessary levels of history writing.
Resolves ESCOMP#2814.
@samsrabin samsrabin added bug something is working incorrectly testing additions or changes to tests PR status: awaiting review Work on this PR is paused while waiting for review. PR status: needs testing test: aux_clm Pass aux_clm suite before merging labels Oct 7, 2024
@samsrabin samsrabin self-assigned this Oct 7, 2024
Comment thread cime_config/testdefs/testlist_clm.xml Resolved
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 8, 2024
Comment thread cime_config/testdefs/testlist_clm.xml Resolved
@samsrabin
samsrabin requested a review from ekluzek October 10, 2024 16:16
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 10, 2024
@samsrabin
samsrabin requested review from slevis-lmwg and removed request for ekluzek October 14, 2024 16:37

@slevis-lmwg slevis-lmwg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin thank you for this work. I included one or two separate questions to my review, and here is another:
Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

Comment thread cime_config/testdefs/testlist_clm.xml Resolved
Comment thread cime_config/testdefs/testlist_clm.xml Resolved
Comment thread cime_config/testdefs/testlist_clm.xml Resolved
@samsrabin

Copy link
Copy Markdown
Member Author

@samsrabin Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

Removing the include_user_mods file from the test means that the default outputs no longer overwrite outputs specified by earlier test mods. For example, in LCISO_Lm13.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_monthly--clm-matrixcnOn_ignore_warnings, it should have been saving monthly (the ciso_monthly test mod) but was actually being saved at much higher frequency (because matrixcnOn_ignore_warnings was after ciso_monthly in the test name). That test goes from 30 to 3 GB after this change.

@slevis-lmwg

Copy link
Copy Markdown
Contributor

@samsrabin Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

Removing the include_user_mods file from the test means that the default outputs no longer overwrite outputs specified by earlier test mods. For example, in LCISO_Lm13.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_monthly--clm-matrixcnOn_ignore_warnings, it should have been saving monthly (the ciso_monthly test mod) but was actually being saved at much higher frequency (because matrixcnOn_ignore_warnings was after ciso_monthly in the test name). That test goes from 30 to 3 GB after this change.

Thank you, I had not realized this difference in behavior from moving "default" to the test name.

@slevis-lmwg slevis-lmwg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@samsrabin samsrabin removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Oct 14, 2024
@samsrabin

samsrabin commented Oct 14, 2024 •

Copy link
Copy Markdown
Member Author

@samsrabin Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

Removing the include_user_mods file from the test means that the default outputs no longer overwrite outputs specified by earlier test mods. For example, in LCISO_Lm13.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_monthly--clm-matrixcnOn_ignore_warnings, it should have been saving monthly (the ciso_monthly test mod) but was actually being saved at much higher frequency (because matrixcnOn_ignore_warnings was after ciso_monthly in the test name). That test goes from 30 to 3 GB after this change.

Thank you, I had not realized this difference in behavior from moving "default" to the test name.

Well technically it's not moving default to the test name that does it; it's removing the include_user_mods file. Every test mod in a test name gets its user_nl_clm appended, in order, to create the one used by the test. So if default's user_nl_clm (via matrixcnOn) comes after ciso_monthly's, then if both test mods set something, default's will be the one used.

samsrabin and others added 3 commits October 15, 2024 09:34
@samsrabin
samsrabin merged commit 26b9aa7 into ESCOMP:master Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something is working incorrectly PR status: needs testing test: aux_clm Pass aux_clm suite before merging testing additions or changes to tests

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

matrixcnOn testmod shouldn't include default testmod

3 participants