Repository navigation
Conversation
glc_get_elevation_classes_with_bareland will no longer work following the changes in ESCOMP/CMEPS#720 and the associated CISM changes. glc_get_elevation_classes_without_bareland should still work but wasn't used anywhere, so I'm deleting it to clean up the code.
In this commit, I am simply copying these old unit tests verbatim from https://github.com/ESCOMP/CESM_CPL7andDataComps
Changes were made by Claude (Opus 5.5), reviewed by myself
Tests were written by Claude (Opus 5.5), reviewed by myself
Member
Author
|
@Katetc I'm assigning you as reviewer because I think you'd be the best one to review this, but if you don't have time, let me know and I can assign someone else. To facilitate review, here is information on each of the commits here:
I have reviewed the production code changes carefully and the unit test changes quickly. I feel like this could safely come in with only a cursory review if time is limited, but I'm also open to a more thorough review if you want. @whlipscomb - FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up glc_elevclass_mod by:
(1) Removing glc_get_elevation_classes subroutines. glc_get_elevation_classes_with_bareland will no longer work following the changes in ESCOMP/CMEPS#720 and the associated CISM changes. glc_get_elevation_classes_without_bareland should still work but wasn't used anywhere, so I'm deleting it to clean up the code.
(2) Improving some comments.
(3) Adding unit tests. This includes (a) bringing over the old unit tests of this module from https://github.com/ESCOMP/CESM_CPL7andDataComps (cleaned up to match the new style of unit tests in this repository), and (b) adding unit tests of glc_get_fractional_icecov.
The unit test changes in 43ac1d9 and 8f91b85 were made by Claude (Opus 5.5), reviewed by myself.
Testing: