Skip to content

CCPPize ion_drag_ghg - #477

Open
peverwhee wants to merge 6 commits into
ESCOMP:mainfrom
peverwhee:waccm-physics
Open

peverwhee wants to merge 6 commits into
ESCOMP:mainfrom
peverwhee:waccm-physics

Conversation

@peverwhee

@peverwhee peverwhee commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Tag name (The PR title should also include the tag name): tbd
Originator(s): peverwhee, claude opus 5.5

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
Move ion_drag_ghg to atmospheric_physics and CCPPize.

NOTE: Code is mostly identical to CAM with the exception of:

  1. bugfix: doiodrg = (nbot_lev > ntop_lev) instead of if (nbot_lev > ntop_lev) then doiodrg = .true. in init. fixes issue where doiodrg couldn't be set to .false.. b4b for all aux_cam WACCM tests.
  2. stylistic things identified by Fortitude

ANOTHER NOTE: scheme is not portable due to depedency on lininterp

addresses #459
addresses #455

List all namelist files that were added or changed: n/a

List all files eliminated and why: n/a

List all files added and what they do:

A    schemes/high_altitude/ion_drag_ghg.F90
A    schemes/high_altitude/ion_drag_ghg.meta
- add ion_drag_ghg ccppized scheme

A    test/test_suites/suite_ion_drag_ghg.xml
- add test suite

A    schemes/sima_diagnostics/ion_drag_ghg_diagnostics.F90
A    schemes/sima_diagnostics/ion_drag_ghg_diagnostics.meta
- add ion_drag_ghg diagnostics

List all existing files that have been modified, and describe the changes: n/a
(Helpful git command: git diff --name-status main...<your_branch_name>)

List all automated tests that failed, as well as an explanation for why they weren't fixed: n/a

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
New physics package.

If yes to the above question, describe how this code was validated with the new/modified features: Code validated via regression tests in CAM and new snapshot test in CAM-SIMA

@peverwhee
peverwhee requested a review from nusbaume November 6, 2026 23:59
@peverwhee peverwhee self-assigned this Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

This PR: 1 new standard name and 0 removed

Updated every push. Comparing head 03b06c1 with main at merge-base 176292e.

New standard name Units Introduced in Also seen in Notes
do_ion_drag_from_globally_uniform_tensor flag schemes/high_altitude/ion_drag_ghg.meta:33 schemes/sima_diagnostics/ion_drag_ghg_diagnostics.meta:9
schemes/sima_diagnostics/ion_drag_ghg_diagnostics.meta:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant