Repository navigation
Siri shortcut translation files are not handled #151
Description
I have an app which supports Siri Shortcuts, therefore I have a .intentdefinition file. This file is also translated, but it looks like, BartyCrouch ignores this file.
Reacted by Tomislav Filipcic, Patrick Ferreira, Nikita Somenkov and Romain Sickenberg
Activity
Jeehut commentedon Oct 16, 2019
I haven't used Siri Shortcuts yet, so I'm not aware of this file. Can you please further explain how this is localized? Are there any Strings files? Can you list the different file paths? Are they below something like
en.lproj?It is totally possible that we didn't cover those files yet. While I'm not sure how BartyCrouch could improve translation there, I'm definitely open for a PR that adds support for Siri Shortcuts.
patricks commentedon Oct 18, 2019
The files are located in the Base.lproj, en.proj locations. The .intent file is a xml file.
patrickferreira commentedon Dec 30, 2019
+1
It would be amazing if bartycrouch could handle the translations of custom intents.
Let me know if you need any further info.
Jeehut commentedon Dec 31, 2019
@patrickferreira I understand that. But my question, how BartyCrouch could help here is still not answered. I'm assuming you expect something similar to what BartyCrouch does with Interface Builder files, right? (Automatically updating the
.stringsfiles with new translatable texts in the IB files.) That's only supported by BartyCrouch because Apple has a tool (namelyextractLocStrings) which does that for us. If there's a similar tool for the.intentfiles, it might be easy to add support for intents as well. If not, things get a little more complicated.letatas commentedon Jan 7, 2020
For your information
.intentdefinitionfiles are xml property lists, so may be the same workflow that is used for classic.plistfiles can be applied with them?NMAC427 commentedon Oct 19, 2020
I'm experiencing the same issue. And it still hasn't been fixed in version 4.x. Would be great if someone could take a look at this.
Jeehut commentedon Oct 19, 2020
@NMAC427 Thank you for bringing this up again. As I have noted above, BartyCrouch is currently based on tools from Apple (namely
extractLocStrings) which don't support XML/PLIST files (AFAIK), so it's not trivial to add support for Siri shortcut translation files. But I'm actually thinking about switching to a completely custom implementation for the next major version of BartyCrouch where I could also take other file types like the.intentdefinitionfile into consideration. I can't promise any time when I will be working on it though as I'm developing BartyCrouch in my free time. If someone was to add support for these files, I'd love to review & merge a PR for it though.NMAC427 commentedon Oct 19, 2020
A few years ago I developed such a system myself for my own projects. It definitely is possible but the main problem with it is that Apple constantly creates breaking changes (i.e. new platform or new ui element). As long as Apple provides tools to generate .string files from storyboards, I would use their tools. That way you automatically get support for new ui elements and platforms. (This is also akin to the Unix philosophy where you build programs on top of other programs instead of reimplementing everything yourself.)
Instead I would only create a custom implementation for handling files (like
.intentdefinition) where Apple doesn't provide any tools for creating the derived.stringfiles.Jeehut commentedon Oct 19, 2020
@NMAC427 Good points and don't worry, I won't be reimplementing anything that changes often and Apple (or the community) already provides an updated tool for. But
extractLocStringfor example handlesNSLocalizedStringand there not much has changed over time. By implementing a custom approach, I can add support for more customization options, I can add some kind of plugin system where.intentdefinitionsupport could be added easily etc.But I will think about the design choices when I have the time to actually start working on this.
RSickenberg commentedon Jan 21, 2021
Hello, is this still ongoing?