Repository navigation
Conversation
…re's origin Object.drawFilters pushes the filter texture with the (xMin, yMin) of its bounds as the target's start, but setRZ mapped a zone through the filter matrix (relative to the filtered object's origin, already in texture pixels) and then through the scene viewport. The zone was therefore offset by (xMin, yMin) - e.g. 2px up and left under a Blur/Glow with radius 1 - and scaled a second time when the viewport is scaled. Visible as a single-line TextInput, drawn inside any filtered parent, having the descenders of its text clipped off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bottom of letters was being cut off.
Object.drawFilterspushes the filter texture with the(xMin, yMin)of its bounds as the target's start, butsetRZmaps a render zone through the filter matrix (relative to the filtered object's origin, already in texture pixels) and then through the scene viewport. So inside a filter the zone is:(xMin, yMin): e.g. 2px up and left under aBlur/Glowwith radius 1, sinceboundsExtendmakesxMin/yMinnegativeviewportScale * resolutionScalewhenuseScreenResolutionis set)Symptom: a single-line
TextInputdrawn inside any filtered parent has its descenders (g, p, y, j) clipped off, because itsclipRenderZoneof onelineHeightends up a couple of pixels too high.Fix: when
inFilter, map the zone into the current target's pixels, using the start offset thatpushTargetfolded intoviewX/viewY. Outside a filter nothing changes, and when the start is 0 and the viewport is unscaled the result is the same as before.Tested on HashLink (SDL): descenders that were cut off now render in full.
🤖 Generated with Claude Code