Repository navigation
Support BitmapData.drawScaled on JavaScript - #1380
Open
snowyukitty wants to merge 1 commit into
Open
snowyukitty wants to merge 1 commit into
snowyukitty wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1211.
BitmapData.drawScaled()and itsdraw()wrapper throwNot implementedon JavaScript. Add Canvas2D drawing with source cropping, smooth or nearest-neighbor scaling, default alpha compositing, andNonereplacement. Replacement is clipped to the destination rectangle so transparent pixels do not erase the rest of the bitmap, including when the source and destination overlap. Other blend modes are explicitly rejected, and rectangle bounds follow the existing HashLink implementation.Add a
BitmapDataDrawsample with pixel checks for transparent replacement, background preservation, overlapping self-copy, and alpha compositing. It runs through the existing sample build generator.Validation:
haxe all.hxmlfrom the repository root andhaxe all.hxmlfromsamples/pass, including the new sample's JavaScript, HashLink and DirectX12 builds.