Skip to content

Deprecation fix: Cast a null localPath before substr() in CombineAssets - #2

Closed
austinderrick wants to merge 1 commit into
wip/1.3from
fix/combine-assets-null-local-path
Closed

austinderrick wants to merge 1 commit into
wip/1.3from
fix/combine-assets-null-local-path

Conversation

@austinderrick

@austinderrick austinderrick commented Nov 5, 2026 •

Copy link
Copy Markdown

CombineAssets::prepareRequest() passes a null $localPath to substr() when combine() is called without a local path, which raises "Passing null to parameter #1 ($string) of type string is deprecated". Casting to string keeps the same result ('/').

prepareRequest() passed a null $localPath to substr(), which raises a PHP 8.1+ deprecation (four per homepage). The result is unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant